Received-SPF: pass (google.com: domain of linux-kernel+bounces-63643-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <385ff2e5-ad79-456a-9632-9581c0d26d9a@oracle.com>
Date: Tue, 13 Feb 2024 14:07:57 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 15/15] nvme: Ensure atomic writes will be executed
 atomically
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, ming.lei@redhat.com, ojaswin@linux.ibm.com,
        bvanassche@acm.org, Alan Adamson <alan.adamson@oracle.com>
References: <20240124113841.31824-1-john.g.garry@oracle.com>
 <20240124113841.31824-16-john.g.garry@oracle.com>
 <20240213064241.GC23305@lst.de>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240213064241.GC23305@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?clRBWmZNbEQrei83Q3JUdWIyWXpDVzdNdzhmd296ZW1CMkFRRnc2UnlBT3VL?=
 =?utf-8?B?QkFEdlAwZjUwUEMxSjI2VDg1R01Pd2xPcjF2MGhaTm9GRXN3RkZRdzVnWlhr?=
 =?utf-8?B?YzhQZzN0YjZHMkRzTWNaL0piVTJQY0JMNVArSWFpcHduYy9BdlYwcURUMWxa?=
 =?utf-8?B?QWxLMkdNU21JNGFtbFlucU0zS2s0YUJuMG9IVXowZ3Btc0c2WXA0bFVIeVhR?=
 =?utf-8?B?amZ3RkdlTWwyZWd1eGxWbmdib0RGazIzeWJIN2ZzQWROZUI1dERLMHpuMDFy?=
 =?utf-8?B?a3FZdWZsVmNKNFJHckZZL0hnc3lDQkY0RTJyckhQL2pTSjhqblNqWWozVnor?=
 =?utf-8?B?UDhtVks1OWFSeXFpSmMxbFpITXJyVHROWVpNcExUa0orZS92T0JTMU4vZWRF?=
 =?utf-8?B?a2hwRDZSZkk2SC81Z3BhL1grbUZZWDJLSmE3dlM4bG50ak9NaTRSOTBubHpa?=
 =?utf-8?B?WUFocFowQVF4U2tGSzJBK3hIM1hOWVZNbE8vQnZhSzVXa2pBaVBZNWpidzhQ?=
 =?utf-8?B?a3pObzdRWUVaQVhyUU9ienorVlg0WE83VXpvbEJRU1ZFNHZkZE1kL1FWQ3Zi?=
 =?utf-8?B?cnd2OCtYcE96N1FyRVhVenUzZjhlWXRKb3QyeStQc0U3d0RDTzdXRWRPRmM3?=
 =?utf-8?B?Z3NDUE5aSXZNTVljVnBDaURNYytOcjVLNURBNFBkb3FCdW83TFFCVTcxOXM4?=
 =?utf-8?B?MTk0enZkbEJBenNwellvOTgxYnhtNnM1cklEL2tFblI0OVI5Tk5wOENzZGdY?=
 =?utf-8?B?TlpxQndEck1LWHF1S1lIc0t1ajlROVJlT3dJVy9LNE5ERXViNFVsSWxRYzd2?=
 =?utf-8?B?WUk3M0w4cHgycVMyVmN0R3BlS1pqZUYvSGJZL0NmMzNENzU4WGNSWVVHTUtK?=
 =?utf-8?B?eDBXZXV4eUxJcW9aTldGSTdGRTdRanpTWjJqV1FKbEhiSkYxMldqbEk0a0R4?=
 =?utf-8?B?emNnQXYybU9ReUQrdzdkdHA3MDNEOFppS1NmWE11VUdrNG5nVm82NzhiRHNN?=
 =?utf-8?B?RmRqcUhSa0pXVGZ5OU1wdEovUVpNSDZzR05tbWFQeWNIRDZJczV2dGRsOU02?=
 =?utf-8?B?T1pWMGRBOS81cVEwYlNkeStQRkhBMnc1NDIyRmRtZ0R3ZURGWmVjaEQvblRy?=
 =?utf-8?B?T25zVG83Y2tGZlphSEkzV1oyQjhxa1IzTGR1WnpEL1Fpckh3VkplVWpRMkhZ?=
 =?utf-8?B?MFpmYXpxU2dlcTB6SmVUdHM0ejFJcWtCM05UOG15WUpXcVRaMndpNkN1RW9z?=
 =?utf-8?B?RlZJNXJjTzNobTZBTURYWmVKbTVtTlhEZGpMRHQ0YWJnM1BidnJ5b3Q1Q2Jp?=
 =?utf-8?B?L2p0VENGUk5UcWhrYUhSdk9ubUlVb1dDWE5ySmNHQzJxQTZIV04rSGV2YzE3?=
 =?utf-8?B?SzFrSGYvYmRackxQR1dvNFFxQ1ZaczhHR0lhME9OdTJUZVBrOWRxVmZzVEp0?=
 =?utf-8?B?N0h0RTRHKzNZVFBPTEs4a1NqaENQYkd6UXA1ZUFLNUVzTlg5Y2NxOUd1ZnlK?=
 =?utf-8?B?Q21vSHRjck1mT2JpTTFLUUhHV3ZwNlJ0N3RWK1ZjZWEzaTF6R2VQNTFhK1hm?=
 =?utf-8?B?M1NTMFJESGRFN0E0b0JWTy9TSmJvSVZrQXJCOFVCaFlmbTY5QitSYnNxYXNr?=
 =?utf-8?B?N1ArR3llY2dTSXljOU5tRG9vZXYxczJLUjlRTURIVDBheVhaZ0pzcFVyRmxa?=
 =?utf-8?B?V1lRcmJOMTlnUlZVVVZidEVhaC96NWhsOHpmMmJwZnV0U1doQ0xXb2dvWjRa?=
 =?utf-8?B?OHUvR1FHWWNZUktqY2pIM3VrbHd3ODN5T3NYSlRnOW9lMW9GelJ5R0FRcXdD?=
 =?utf-8?B?OHVITlNwU24rd05vL3Uxcmo2U0ZkQ2t0ZGtXN0o5U0xLcnRNdHlIWHVFZjlR?=
 =?utf-8?B?dkpGMWdiUjNaL0dEVUQ4QS9MSTVTTUhCWTVROVVSd3B4cTl3Y2FoamNQQ1dl?=
 =?utf-8?B?V2haanM1Z2NCa2RwOWhmdmpndzl0NVJRZHlQQitRMVUyOEZpSy92bTlJeit4?=
 =?utf-8?B?UlRqVmg5TXZDbmhPbW9DckRLREwrNzRsT09KbTN3UDBQemtTY1loOTNhMFZv?=
 =?utf-8?B?K1htRVV2OXBtdkRBd2dvaUgxNTBORjlYTUlwUldwbGhLRC9jRDBtTGZERjcy?=
 =?utf-8?Q?84N+6jFiXn4H8oQTi/3zDdl/j?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	eB8fqlNfV/cdHyHieKNqMxKBYDQSL18D2ttudTBVVSVkXkyUZfePzI/8fzcULex7do8C7IrwV28moF2tpaVlNzH7FxNVw48+vmGVBWRfh5AlfCdBHP1FPGb/Yjf7jFIcfAlYDxh88ySWaQHDJw3fs460zqQuD3Y7bqNPgDRp9mp1rPupTAeHl+hbuNqNncusn3zuNgEOKjk7sluANzJLoRkO7hEZG38/FLIo8ydp1ShIJJYuyq0t5eHAWueoFFNjXlW8JqBz0NSp4jbDayCu/6zS1B0SOI9nm28IVdXJQ2uhxx6chWKyBNhMLjSWev0xaVf0awlf+G3ZomhT9d5TDYQN7PEmt3+rLFo3KHglDpc2zjZt+yLvKKxgbn8jla0xXTnT3H36P3fqo1eSRsXcEfchxxfqGAqis1ICxot1B0PQZbR96GWY9sISMPcMbJnJsqZcRAqsG+UYPuqLsrrUvZpRstt3ArDmraqEHlhT0JfsYPu5Ued4AubF/lHt9IXhGCIkj3Ms3P0cIXdA6Rt44SeGrOkSdnTjBDAoh/TLomBmx+LPeUXzPyJvanszafsyhizRKhXhVqSF/dhOgKRGN4oHUXiR3/JjX5McQc+H6Ms=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f500d2d-fdc7-47d3-0ee2-08dc2c9d36ff
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 14:08:12.7506
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RVOaqcZeaNHV6kN78oJNWZ18X7IbbRX0voDjEdmKdU8TLcG4ssDcLW7HywFhsO1ZPVko0oA0YtnLIkIIp7SUOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4485
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-13_08,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=732 phishscore=0 mlxscore=0
 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402130112
X-Proofpoint-ORIG-GUID: g84YTYG9LBSUF4-dPcUGP_HsXWRONxlE
X-Proofpoint-GUID: g84YTYG9LBSUF4-dPcUGP_HsXWRONxlE

On 13/02/2024 06:42, Christoph Hellwig wrote:
> If we don't end up doing the checks in the block layer:
> 
>> +	/*
>> +	 * Ensure that nothing has been sent which cannot be executed
>> +	 * atomically.
>> +	 */
>> +	if (req->cmd_flags & REQ_ATOMIC) {
>> +		struct nvme_ns_head *head = ns->head;
>> +		u32 boundary_bytes = head->atomic_boundary;
> 
> ... please split the checks into a helper. 

ok

> And merge them into the
> previous patch.

Fine, if you prefer that.

>