Received-SPF: pass (google.com: domain of linux-kernel+bounces-63639-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240210175922.137704-1-clamor95@gmail.com> <20240210175922.137704-2-clamor95@gmail.com>
In-Reply-To: <20240210175922.137704-2-clamor95@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 13 Feb 2024 15:07:02 +0100
Message-ID: <CAJZ5v0j3f9xKpE0XBNrv33u68zo5fasEP5yQU_K5qU2oz7RwgA@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] thermal: thermal-generic-adc: add temperature
 sensor function
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Zhang Rui <rui.zhang@intel.com>, Lukasz Luba <lukasz.luba@arm.com>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 10, 2024 at 6:59=E2=80=AFPM Svyatoslav Ryhel <clamor95@gmail.co=
m> wrote:
>
> Existing thermal-generic-adc states to be an adc-based thermal
> sensor, which is not entirely true. It provides a thermal sensor
> cell, but it does not provide an IIO sensor cell, which would
> benefit devices that use adc sensors to detect temperature and
> need a custom calibration table.

After reading this changelog and the subject I have to
reverse-engineer the patch to actually find out what's going on.

In particular, are there any user-visible changes of this and if so,
what are they?

> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  drivers/thermal/thermal-generic-adc.c | 57 ++++++++++++++++++++++++++-
>  1 file changed, 56 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/ther=
mal-generic-adc.c
> index 1717e4a19dcb..7e87d928512c 100644
> --- a/drivers/thermal/thermal-generic-adc.c
> +++ b/drivers/thermal/thermal-generic-adc.c
> @@ -7,6 +7,7 @@
>   * Author: Laxman Dewangan <ldewangan@nvidia.com>
>   */
>  #include <linux/iio/consumer.h>
> +#include <linux/iio/iio.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> @@ -73,6 +74,60 @@ static const struct thermal_zone_device_ops gadc_therm=
al_ops =3D {
>         .get_temp =3D gadc_thermal_get_temp,
>  };
>
> +static const struct iio_chan_spec gadc_thermal_iio_channel[] =3D {
> +       {
> +               .datasheet_name =3D "temp",
> +               .type =3D IIO_TEMP,
> +               .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW),
> +               .indexed =3D 1,
> +               .channel =3D 0,
> +       }
> +};
> +
> +static int gadc_thermal_read_raw(struct iio_dev *indio_dev,
> +                                struct iio_chan_spec const *chan,
> +                                int *temp, int *val2, long mask)
> +{
> +       struct gadc_thermal_info *gtinfo =3D iio_priv(indio_dev);
> +       int ret;
> +
> +       if (mask !=3D IIO_CHAN_INFO_RAW)
> +               return -EINVAL;
> +
> +       ret =3D gadc_thermal_get_temp(gtinfo->tz_dev, temp);
> +       if (ret < 0)
> +               return ret;
> +
> +       *temp /=3D 1000;
> +
> +       return IIO_VAL_INT;
> +}
> +
> +static const struct iio_info gadc_thermal_iio_info =3D {
> +       .read_raw =3D gadc_thermal_read_raw,
> +};
> +
> +static int gadc_iio_register(struct device *dev, struct gadc_thermal_inf=
o *gti)
> +{
> +       struct gadc_thermal_info *gtinfo;
> +       struct iio_dev *indio_dev;
> +
> +       indio_dev =3D devm_iio_device_alloc(dev, sizeof(struct gadc_therm=
al_info));
> +       if (!indio_dev)
> +               return -ENOMEM;
> +
> +       gtinfo =3D iio_priv(indio_dev);
> +       memcpy(gtinfo, gti, sizeof(struct gadc_thermal_info));
> +
> +       indio_dev->name =3D dev_name(dev);
> +       indio_dev->info =3D &gadc_thermal_iio_info;
> +       indio_dev->modes =3D INDIO_DIRECT_MODE;
> +       indio_dev->channels =3D gadc_thermal_iio_channel;
> +       indio_dev->num_channels =3D ARRAY_SIZE(gadc_thermal_iio_channel);
> +
> +       return devm_iio_device_register(dev, indio_dev);
> +}
> +
>  static int gadc_thermal_read_linear_lookup_table(struct device *dev,
>                                                  struct gadc_thermal_info=
 *gti)
>  {
> @@ -156,7 +211,7 @@ static int gadc_thermal_probe(struct platform_device =
*pdev)
>
>         devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
>
> -       return 0;
> +       return gadc_iio_register(&pdev->dev, gti);
>  }
>
>  static const struct of_device_id of_adc_thermal_match[] =3D {
> --
> 2.40.1
>