Received-SPF: pass (google.com: domain of linux-kernel+bounces-63674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7c3e08e8-899b-416c-a0b8-341f00fa9da9@linux.intel.com>
Date: Tue, 13 Feb 2024 09:28:19 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 0/4] Fixes/improvements to metric output
To: Ian Rogers <irogers@google.com>, Peter Zijlstra <peterz@infradead.org>,
 Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>,
 Namhyung Kim <namhyung@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
 Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>,
 John Garry <john.g.garry@oracle.com>, James Clark <james.clark@arm.com>,
 K Prateek Nayak <kprateek.nayak@amd.com>, Kaige Ye <ye@kaige.org>,
 linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240209204947.3873294-1-irogers@google.com>
Content-Language: en-US
From: "Liang, Kan" <kan.liang@linux.intel.com>
In-Reply-To: <20240209204947.3873294-1-irogers@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2024-02-09 3:49 p.m., Ian Rogers wrote:
> A small addition to allow NaNs to be encoded in metrics and then 3
> fixes to various metric related issues.
> 
> Ian Rogers (4):
>   perf expr: Allow NaN to be a valid number
>   perf expr: Fix "has_event" function for metric style events
>   perf stat: Avoid metric-only segv
>   perf metric: Don't remove scale from counts
>

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan


>  tools/perf/util/expr.c         | 20 +++++++++++++++++++-
>  tools/perf/util/expr.l         |  9 +++++++++
>  tools/perf/util/stat-display.c |  2 +-
>  tools/perf/util/stat-shadow.c  |  7 +------
>  4 files changed, 30 insertions(+), 8 deletions(-)
>