Received-SPF: pass (google.com: domain of linux-kernel+bounces-63734-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <25f8fa78-53e1-4b53-a70b-6b758d671452@suse.cz>
Date: Tue, 13 Feb 2024 15:56:14 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 4/5] mm,page_owner: Filter out stacks by a threshold
Content-Language: en-US
To: Oscar Salvador <osalvador@suse.de>, Marco Elver <elver@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
 linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>,
 Andrey Konovalov <andreyknvl@gmail.com>,
 Alexander Potapenko <glider@google.com>
References: <20240212223029.30769-1-osalvador@suse.de>
 <20240212223029.30769-5-osalvador@suse.de>
 <CANpmjNNWv1eDL5MQXtdXnsV=sCp_8MC11xBAgsNt_1K-V30H8Q@mail.gmail.com>
 <Zcs0ruHxL9YOsKN_@localhost.localdomain>
From: Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <Zcs0ruHxL9YOsKN_@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2/13/24 10:21, Oscar Salvador wrote:
> On Tue, Feb 13, 2024 at 09:44:47AM +0100, Marco Elver wrote:
>> On Mon, 12 Feb 2024 at 23:29, Oscar Salvador <osalvador@suse.de>
>> wrote:
>>> +       debugfs_create_file("set_threshold", 0600, dir, NULL, +
>>> &proc_page_owner_threshold);
>> 
>> Can't you also read from "set_threshold", so the name "set_threshold" 
>> is misleading. Why not just "threshold"?
> 
> Yes, it can also be read. I guess I was too focused on the set part.

Maybe name it "count_threshold" so it's more clear of whate exactly it's the
threshold of?

> I will rename that one, plus add the {READ,WRITE}_ONCE.
> 
> Thanks!
>