Received-SPF: pass (google.com: domain of linux-kernel+bounces-63764-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 13 Feb 2024 15:03:06 +0000
In-Reply-To: <20240212-projector-dangle-7815fa2f7415@wendy>
Precedence: bulk
Mime-Version: 1.0
References: <20240212-projector-dangle-7815fa2f7415@wendy>
Message-ID: <20240213150306.2424991-1-ericchancf@google.com>
Subject: Re: [PATCH] riscv/fence: Consolidate fence definitions and define __{mb,rmb,wmb}
From: Eric Chan <ericchancf@google.com>
To: conor.dooley@microchip.com
Cc: aou@eecs.berkeley.edu, ericchancf@google.com, linux-kernel@vger.kernel.org, 
	linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com
Content-Type: text/plain; charset="UTF-8"

Hi Conor,

  Thank you, I should not have just used defconfig without allesconfig.
  It has been corrected in PATCH v2 [0] as follows.

  v1 -> v2: makes compilation pass with allyesconfig instead of
  defconfig only, also satisfy scripts/checkpatch.pl.
  - (__asm__ __volatile__ (RISCV_FENCE_ASM(p, s) : : : "memory"))
  + ({ __asm__ __volatile__ (RISCV_FENCE_ASM(p, s) : : : "memory"); })

  I've updated patch v3[https://marc.info/?l=linux-kernel&m=170783431129245]
  Please let me know if you have any further questions or suggestions.

  [0] https://lore.kernel.org/lkml/20240212105946.1241100-1-ericchancf@google.com/

Sincerely,
  Eric Chan