Received-SPF: pass (google.com: domain of linux-kernel+bounces-63781-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7de12bb2-30ed-4bd1-a9de-2032bcfef686@oracle.com>
Date: Tue, 13 Feb 2024 10:06:07 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2] vdpa: skip suspend/resume ops if not DRIVER_OK
Content-Language: en-US
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>, Si-Wei Liu <si-wei.liu@oracle.com>,
        Stefano Garzarella <sgarzare@redhat.com>
References: <1707834358-165470-1-git-send-email-steven.sistare@oracle.com>
 <CAJaqyWeE3hE3Mv29TL8K6CHTncexdOZXgD+BoehRCamiGfeBcA@mail.gmail.com>
From: Steven Sistare <steven.sistare@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <CAJaqyWeE3hE3Mv29TL8K6CHTncexdOZXgD+BoehRCamiGfeBcA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?T0VrcmRuVnZCYktpR3U2YUVOOTA2Z0FBelhDR2M5U0xqaTdtVzAwQkVoWkdS?=
 =?utf-8?B?UXdkZGREc1Ntd09qWGp2eTJ3Y2JrR0lqVzAxRVlNeWIzR3R0OXQ1L2IvR2lX?=
 =?utf-8?B?Umt2NmZhdGxLN1drMWVJOGpDdmFSQVdFMi9qdWt1dS9jamFHajBYL0w1eStJ?=
 =?utf-8?B?RDUvaW1kYmZXUEtodXJVMlROKzA3bkFDSUZBNzY2MFVmajdPY2tpUGd1czZ4?=
 =?utf-8?B?M2RSTThhd2xTbkFSWjNZRkgyakxSckVyUUdwMHFGR2NFZFc2VzEwKytEaElZ?=
 =?utf-8?B?WHp3byszckYvREdoNHBvTGRGSjRPSy9QRkhsNktBRzVxWVcvOWJqbmR0WlpC?=
 =?utf-8?B?dUJXeFhFL0dDSXJyM1FlN0poWkYzeUlNNWVFMU1lVXFXZFdGWVBQQjhzQkdF?=
 =?utf-8?B?eGt4QnVkcmFKTGxkaWhvdy93RWY3a3dBQTc4a0c0WDl5RHgyWHpaYm9xcG5p?=
 =?utf-8?B?OHpmRU5qeGVDeGpZWEZMa0t6aGRCZ01Najl4cDBad0p4bVdXNnNsc01FTWxr?=
 =?utf-8?B?RmozTVBKTE5tNEZqMHR6K1A3bXE1WmN0V0RqT2k5aTNLakJyL2hwTHNicWNk?=
 =?utf-8?B?WTdMOFZxRmJsSXRNY3hRQmlFWjlnMWJqN1VyaCtodkgwNHVKdHdySlYvM3Fw?=
 =?utf-8?B?OTVId2g2ZWplTzFsdWFzNVF5ZjZyN3pDcVBGMXQwOE5FUEIwWFhPOTNxVWx1?=
 =?utf-8?B?b2t3cXRJSGlZMkorOWY1VUovNDhCM1FDaXoxMEVTajNUTWJVemNVQSt0OUZu?=
 =?utf-8?B?Rndsd083c0s4WnFkc1lFNThycWhTUG5hQW5oOW55WHdXNE56ZS9zS0NUTXRi?=
 =?utf-8?B?UE9mZXJaWU9oc2dDenVtRk1mN0xkeFNSd2FKWXlyMjNBWWpXK0NyaytUQUpF?=
 =?utf-8?B?TkIxdWpRVDM5ekhwSEYyQWZvL2dMNkVRSGRmSm5MNEVPb01heStWUGxvM09B?=
 =?utf-8?B?bDdWdFB4cENaYXpteCt1bVpXVXBsU256QnVURlN0dC9FM2YwYjRkcEFSdWVM?=
 =?utf-8?B?WS80WDdlT01MTGhtVzc1MDdoUEMvV3d4VzN4VGdLZGFmZW1JWTcyVjFjUnR1?=
 =?utf-8?B?RUFhL0NSTHBlR2d0NTZ4eE1rcmlMajVDSzVMZUs0MGJZaURCWDI2WE16dFJI?=
 =?utf-8?B?OWRUay9MRmZUajJ4TmE0ekM3c05HSlZTb3VwVThvaFdmOWhCa1QxQTVHdWVi?=
 =?utf-8?B?ZDBYZUxXbEF1YTRZNXRubHFHOE5KaFc0bzRRVnRRMTh2OU0yVXh0Rjc3V2x2?=
 =?utf-8?B?Z0tsV2NvZmZudzQwd2ZXNmYvVVVNM21xMEUrNWRITEFnQ2JBSzA3NncyZTMx?=
 =?utf-8?B?elZzTFl3Q3JiVmtwUVpqV29CRDJJWWFaeGNDMkI2Q1I4YjF4clBxUVREdlZj?=
 =?utf-8?B?NG0zSFBEdWdsT1Jhb2NLVGtmSEZwYkt6NG55aU1yRWhUem1VL3pESzBTRFRX?=
 =?utf-8?B?dmxnZ25ZbjVTcWpISy9vUjNXNmdVK3pQWnVBaGNOWW1tRnlRRllqc0t6anZO?=
 =?utf-8?B?YklHK2RuR2pFL2EwSXV0alc3RmRNZndYOVlVa054Rk5oTUI0UXVlMU51TEl3?=
 =?utf-8?B?VHVVckNHZ1NBVmdMaDJPdW1qbFRzM0M2c0YyeHloMnBoOE9DSDRFcUdZOVd5?=
 =?utf-8?B?RFdsRUdsQWxVeTFFclE1c3pnMjVsc1NlbUFXOGh4dUl2RkRDc0lxbzliSFRm?=
 =?utf-8?B?cGdvdUVFN1QwM09yazgxaGZFRnNtUGFDTFgzYzBuQTA1WnF6eDdiSkw4elZi?=
 =?utf-8?B?U2p5UFNTRlc0SWpoZmtkTEs2dlh4eENUQmU2aWZFWVF5STJZWXA2V3VsSldH?=
 =?utf-8?B?RVRPNW9uVnVFc2gyOE5sVURoUXBSdlowYkVQdWRNOWNscHR4Rm45akNsNUFj?=
 =?utf-8?B?bnFNSTlUa0hoaWFwQW12RDlWZElkVS91dzJKU3BkdXYrTXZMY3g4dW5lcCtN?=
 =?utf-8?B?TjV5Q1hvaUR4V1d0NnlxQStJM0pxRWQ1ZnNwZmk3ZlNPc2JhSnY0cldQSFFo?=
 =?utf-8?B?b3NGKzVWU2V4TlUvcHlYSkU1RURjR3ZPSTRoaVkrcGVRazFQZkNQUG5vRy9I?=
 =?utf-8?B?bisyM1Fqd3dOOWljd1VwOCtLcUtRelRvb2k5eWRGZTc5KytGaW5vek5HMDdn?=
 =?utf-8?B?SC9nV1FUMXBtby9XZ3RyL2t4Yk5yUDdCc0N3TFlQOHFwZWtjQkdvV2hJeDhl?=
 =?utf-8?B?a2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	TV+ZCMB4Rs4FUPLQtiUg9gujvysGHGxcs8hkn84uAWABGd9Y1Q4DoZdWnSF8Z04zQWeSetlQEee3VJsk887yHXLWZ28mDNjBy2GT1rSesggMngmx2F9PN6PYYS4/Gl1u/PzOyaXmDjuKBSikJiFooQYzi2XCzsLbE7RTpWemFzEmabV3P7Pmyemg2S50FI5yCmrTIHQjtS3p41fu81WdJMhnuJ/U9Y8qG8bOA4E2am5cjJrjyDt5bqVpH78nP/ty4RdZg+1gpr0XhxRpD5M+acJAlcbe+ixYGjcjpnI5dlZZ1BFUTE69dWUZCvqCU9IpjvKhE0hKRncAw2mVYudmfcxQbmcIvI5JCOGWVB9C2yw7O/QY47RiH44NoVrw9diC4CFc12VvTQ6GuCGFYYIgKXjazFEDJHks5UX/U7CK9f1I1eUq6PRMdiV423c/fVypNwG9eafzTTmTGWwWYkc6CBA4dq4Zb359U6sXTKlRFMDKC2+9fvMFbUfvlqs6mnox38Z50DFvdCi6TCdtaSGX+x5aZERQq0V1SJwZBuKoko1D6UMZYh6Kh9WUXoGh6hkbQ53A026MyxMhis9RSZ9Oy/crFrjd6zIkseYnABLwYec=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a6e2172-2ed3-4d99-35b4-08dc2ca551c2
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4684.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 15:06:13.5212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tnud/MJSEqEJzKfOylLR1/2qRr78YoeG2aOSCMP/Z7fQP014AwYu1M8iSNBzi3I8BolFX8m96aVe15Unz9cRtKS3Srwci/fR/qYTzAiRis4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR10MB7614
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-13_08,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 suspectscore=0
 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402130118
X-Proofpoint-ORIG-GUID: NQ0DENHCnT3nombg7upIl2r9l-RsFMPh
X-Proofpoint-GUID: NQ0DENHCnT3nombg7upIl2r9l-RsFMPh

On 2/13/2024 9:58 AM, Eugenio Perez Martin wrote:
> On Tue, Feb 13, 2024 at 3:26 PM Steve Sistare <steven.sistare@oracle.com> wrote:
>>
>> If a vdpa device is not in state DRIVER_OK, then there is no driver state
>> to preserve, so no need to call the suspend and resume driver ops.
>>
>> Suggested-by: Eugenio Perez Martin <eperezma@redhat.com>"
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> 
> Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
> 
> Please include a changelog from previous versions for the next series.
> 
> Thanks!

Will do, thanks - steve

>> ---
>>  drivers/vhost/vdpa.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>> index bc4a51e4638b..aef92a7c57f3 100644
>> --- a/drivers/vhost/vdpa.c
>> +++ b/drivers/vhost/vdpa.c
>> @@ -595,6 +595,9 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v)
>>         const struct vdpa_config_ops *ops = vdpa->config;
>>         int ret;
>>
>> +       if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
>> +               return 0;
>> +
>>         if (!ops->suspend)
>>                 return -EOPNOTSUPP;
>>
>> @@ -615,6 +618,9 @@ static long vhost_vdpa_resume(struct vhost_vdpa *v)
>>         const struct vdpa_config_ops *ops = vdpa->config;
>>         int ret;
>>
>> +       if (!(ops->get_status(vdpa) & VIRTIO_CONFIG_S_DRIVER_OK))
>> +               return 0;
>> +
>>         if (!ops->resume)
>>                 return -EOPNOTSUPP;
>>
>> --
>> 2.39.3
>>
>