Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp41358rdh; Tue, 13 Feb 2024 08:49:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVGX89lhk32AEQzk4URJpbcL9V6xkMJENpoVkfcJtaQO7XmDxyaFJ9kdzyhp7v439ySUyWsIb/rsizskvn6QEETQ1yc+Ems6gTWb/w5iw== X-Google-Smtp-Source: AGHT+IGhHXH79QkVHh+BLkZSGvysJjGSFZFd+cxhiQ+8EKN8UfCcrFze0CujXkBrxcaxRdgVoxsQ X-Received: by 2002:a17:906:830f:b0:a3c:8874:6d2c with SMTP id j15-20020a170906830f00b00a3c88746d2cmr5527670ejx.34.1707842989981; Tue, 13 Feb 2024 08:49:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707842989; cv=pass; d=google.com; s=arc-20160816; b=i/6yS14qbt/LXhtbWACxzY19IHlAxVocXkr2Sm27i2zhqwPqolL0ANeuuIrgSuwOot oE47GrAXY2FBPlLxMfOuceoNrOEAJcISn3QgvSLj9EULaXEi9NxsV0+1JzrBuZES98nM 1TEWRzXxfxmNwmooaUh/KVtkhABcvzMnHv+rQbwZta/6adaBVMEX/NSPchw2ZFzjAT/b R8c1UfE31JRyfUfZ/ufSAlrD8hR8DgqNdOd//6ygcGmrLNU+BoOIZVS9+66Rn62RFk79 kfRpnJ+j1CVmIvPohWk3ZFYrhMT4HkaYwUtBZbH4UY3L6nLcYVPOmXXgl9OS6HGMfIS/ HY0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=QMyITr22VNOez+0Eu6FIvd5XT+rl1JLLwyX/uWCBhQQ=; fh=atVyFI9VxXZoOUOK+GffbdZsnwu6lZuSb12zdHO8qVY=; b=lRX5i1eqxA1GnuKKs488qGWAXNvT80MiG9qbM6geW9xkmgH+YccI2uN1hyiPKunvQI TRneZGvmP1uE3sMtQDQ5tbzC2cgU3i51s73PCatVefXG+wzvqVg5RHtC48mUlyf2TfGh 0FhIdmvCx6FXQ/05uMfhENfzmtdOzs7/dkKAGoO4Mw0V2KC0g/AO3HlhEbx0KuT25kA1 xfuZme8vmnh1c9nn0Ye5ecbgmBHPFXX1+Cm55fKGw9YvzXqRqnEYY/m0E4++Vi5Aa7S6 EQByhbzbs6l1Ku20+neuiweTnoKBKCRTYTgqFl1WzhQcAEkXlghkuSrAj+SvLsHKTsap nRNQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FODxZYvu; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-63936-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63936-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Forwarded-Encrypted: i=2; AJvYcCUBfiXG9u9xkP9SfX/zfG3+gGbn88Qz/lVTy6skohnkXlRfVwVBOze+dPx98crCboSTA4SF6u2Sp74PW3QYz71aJRH2+l2zd3m6yNiQFw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id p14-20020a1709060e8e00b00a3cf1f11276si1012015ejf.320.2024.02.13.08.49.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 08:49:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63936-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FODxZYvu; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-63936-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63936-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BA02A1F265D1 for ; Tue, 13 Feb 2024 16:49:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9EDE060269; Tue, 13 Feb 2024 16:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FODxZYvu" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41B245F54E for ; Tue, 13 Feb 2024 16:47:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707842880; cv=none; b=u8drkd1diH9Hkc/WjgvGzwIzEXWHjORs3T1720su6zYV7U0fpR/v7Z2HPhJ8Iq3Qg4uAPc4bvKh8cGYEzjfw98eXjopeOI9EjpjLY71RcHemPirkTcJhimrPEVMj7plqa8PhUBseovVVqic2rKM2Mrt0598b+U/We9zVXcJ9gIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707842880; c=relaxed/simple; bh=QMyITr22VNOez+0Eu6FIvd5XT+rl1JLLwyX/uWCBhQQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Bf2fcfljQNPWqn4vQKf8jwvEFoX+gLEvNpdg3SDeVDdaNzSMAj/kKO64RCKJE6q6YmSYQFMLiiUhSNUT80/JL+rTuGbEByB885V7Q4HMT9NRLO5RVgPJXk6KqwOoOD2TNIbtSZ0d0a2U7me1pGUBhlGbfFWLPc0ByoEsknAxmCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FODxZYvu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707842878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QMyITr22VNOez+0Eu6FIvd5XT+rl1JLLwyX/uWCBhQQ=; b=FODxZYvuvfvnvqutrYSQgZh8eWSK7zFJ8kCgOIJnJsfUm31LRdrxsUYvC7hinV9aGueNUN yOKTtY+1CiusyxktCUhfrxFAISQM+aYW7kHkQVDhx2MNhKYHQMUURm6GGyWiNNYgffQv4i meUOSLkgY0Otae1URJmy+4GpIzWzt/k= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-w-iK0o4KMcaqwPHBFcDmqQ-1; Tue, 13 Feb 2024 11:47:56 -0500 X-MC-Unique: w-iK0o4KMcaqwPHBFcDmqQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-33b8837355dso715227f8f.0 for ; Tue, 13 Feb 2024 08:47:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707842875; x=1708447675; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QMyITr22VNOez+0Eu6FIvd5XT+rl1JLLwyX/uWCBhQQ=; b=M+CxOnbECwYn3jG2CZBVQGXztX9llyAuMgbx6a4VbQOpZET1KnUQPLuuaD2NXjG5vM MYFD1jLbJnIogCCrA05onrbv9rbwJVVYI2hLcU5lTp6kJeG+xIM1+dIk4PNYeff6hIQy Kgem7u9kwWOHjcqM3jpjHvHIK5kXLx+dpFT3tcTgMnlYwYge7Cd/X2acnlWQ1iPTC07V 25szsq0nBCX5uVei0Ivn8UGEQJAERVqEMKLSM+Jg22EuuLe5y18JOndVVtszRaseisgB kW3CZcwXrS5HDhXkMl4O2ALiDmI+2QZxKCiCwbS9qwt2iDIgU9p6qDyj5sYKjBLXIbEG kpkg== X-Forwarded-Encrypted: i=1; AJvYcCUFBxb7uGg1fmshGTUWWJucVLx/0hNKVNMlwQ0zHLzHyP4iiInb2DKgTOt7AYdSXNZMGIugay4RHtry3m5HRhO1Z99Qk/XXgcKGzTWN X-Gm-Message-State: AOJu0YyWAZ6Jvj/bn/y9u2ZuwEJWyYHK3DPkQCR9cWzlX1CMfvsUOW11 YFqkAikuqwgBW6v+DWBKvyUh+MGJZ7g9fbHCV3ySRxbT16/2OMh8NKQw6Sxnc5fn011wqncrbZj ooigaogVO/kOnvvIorhO5RwH699aWudReK/rsCZp0kfk5ql0bou/5Jyp6HWDvAQFVITBHT6dWjz BQNFRTKHnAOGVcx3fHfa1xiGCg6fatYdChs7bS X-Received: by 2002:a5d:5706:0:b0:33c:e339:6b21 with SMTP id a6-20020a5d5706000000b0033ce3396b21mr317084wrv.3.1707842875448; Tue, 13 Feb 2024 08:47:55 -0800 (PST) X-Received: by 2002:a5d:5706:0:b0:33c:e339:6b21 with SMTP id a6-20020a5d5706000000b0033ce3396b21mr317064wrv.3.1707842875120; Tue, 13 Feb 2024 08:47:55 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <591420ca62f0a9ac2478c2715181201c23f8acf0.1705965635.git.isaku.yamahata@intel.com> In-Reply-To: From: Paolo Bonzini Date: Tue, 13 Feb 2024 17:47:43 +0100 Message-ID: Subject: Re: [PATCH v18 032/121] KVM: x86/mmu: introduce config for PRIVATE KVM MMU To: Sean Christopherson Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, erdemaktas@google.com, Sagi Shahar , Kai Huang , chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 13, 2024 at 3:57=E2=80=AFAM Sean Christopherson wrote: > The only thing that even so much as approaches being a hot path is > kvm_gfn_shared_mask(), and if that needs to be optimized, then we'd proba= bly be > better off with a static_key, a la kvm_has_noapic_vcpu (though I'm *extre= mely* > skeptical that that adds any measurable benefit). I'm okay with killing it altogether. Paolo