Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp53055rdh; Tue, 13 Feb 2024 09:08:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEA5Gsgv5P2tcu6ex4JDMKIFPnXcMTVScdqxM+G4QAGPGqvMZw+wlq3FXk9lmSuJS/F5z61 X-Received: by 2002:ac8:5c0d:0:b0:42c:7ca2:8ab2 with SMTP id i13-20020ac85c0d000000b0042c7ca28ab2mr6962900qti.48.1707844087713; Tue, 13 Feb 2024 09:08:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707844087; cv=pass; d=google.com; s=arc-20160816; b=TJXIK9D97Z8FfSFJD7Gz4Gyxl+K1e5JdTkgT+N+1vN3oS4S1t1cYXwH2cNHKrjjzWK RthullFAYo7UC/+Wl9RrdJSp7ruw5Ud6ayEhhpf6EO6iD74VnKMqOAh5fQtFnxso+37m ostzNNHraDnY5B0kocbrU1/dXUSETMgZia32e9Wy9HP7lGllRBslA1DleQDUKDt1xfrP qOGK52wwFJsSem/BXKPtThbZRHZAynAkVuf3pPKuPAfDRxhFoW5GYFvazaZI+PuDTnz8 EHRivdIaNL13iGHMTPoT2Zj+E4wF+lRP+wLhRN+38e4L76T2XSgKnfs9lGsuEpjU61d+ oFbw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=7kHHn7LpfPpuK1iTHvb85TRpelFcAmFM+jpP1Sm3a+8=; fh=isKvRuP6QBb7GgrGcptaVqU6+oOSK2XWWNQwBE7M000=; b=wtTiMHME1cj6khiYZMEI+Z3N+f3yW/gAyfC5+390EPmU5QWH1X7+W++VRS/DWmqaV/ DKgYMwEs9+oqc8tf6zFO1FGk2OrdwsNHycZwlJb43tkWFSGvmVpD0CapnRE2X4mm3u6n i+cfNVGrXxAwY2aGlWFy0aq2wpKd7zOOJr/YYs+S67xeox2vWGrj0jnu4TLth5XiXnae RjDktjTB6WJizpeC92QkV3kIQLgE7msqzVUgD69swKgykg/MrZawgFt6ewj2pI336hgM MvVtZiZMWy8wiuu5D1L2KuPVw82ngduqs++eoGWwaRTxAq+3NwjUK3nvkjXVm8PB/XPC BFbA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gno0fDW6; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-63963-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63963-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCWWaIvMY1opKX/6mxt9SgnLoPwi8hmJwP7ehvrimsJlSc46I1lidUmIJhl3+sb+RmWJpIHwT1OvJqFwtvXrlmEzwm3sNS/ojXPkbus2Mw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id b7-20020ac85bc7000000b0042c2f47ede5si3515666qtb.467.2024.02.13.09.08.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 09:08:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63963-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gno0fDW6; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-63963-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63963-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 74FB21C232F3 for ; Tue, 13 Feb 2024 17:08:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B24FA5FDAD; Tue, 13 Feb 2024 17:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gno0fDW6" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F5FA5FF01; Tue, 13 Feb 2024 17:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707844070; cv=none; b=ZgrzvSgTapKQpih5NI/xlBbF4erSR8HRnFR6vaYvj4gi0B61O6O2ijmpZNB1OmO+Z2l4yo9xZbmuyDyik7McszHtujqurozJ8HDtxYVA40W2bcsfOWLkDtP20ANQbVjFrpfKhr9WPlsOF48tgBfBKbaMhisfp0QYZJRlk9KwyEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707844070; c=relaxed/simple; bh=ANEPHEelvw/oYZMqg/V604ta9tSM6zDTonLH3J1I6so=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CZ9bZdyHChKhys9n+dXl2n589rC5xwfq777gX9wcmQGpXKTWmIptkTvsoCMbUGC2ZlIG9gh12oDJA+buuYEQ1yFC80HAnOSpRln4Mh3kxWvHemYIfK2/INk/yd0i1dk5lxJn7SZ5zlRxzA+CdM67tSsq6Xk4H4UwnC7rRryhGD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gno0fDW6; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707844069; x=1739380069; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ANEPHEelvw/oYZMqg/V604ta9tSM6zDTonLH3J1I6so=; b=gno0fDW6oPES0BuSBI2XvPYnKx16uwAXIoWtcmi3H5jUGwloqovrOr27 z/f49nO6BJ3+R+i/OgqfhB6IIf4TQLsEIRelRRXkkd9617tm1KE0pa8kb 5DeBHNvcGLIOQg+L4BpW9UZFrBbO2SkTUq0/vTST9l7cahB1jcYMxuECI 2AF9/Rw8vHJywiU8TgGcABgS2Hx2HEIx90odHapkvrvSZStkRMSLk/m1C 3I4PUQfgPF48Y0keRdP46pX4qPK5d4UHu3yyTeHdEXkLpcsMX7t92br0E 27w82Wx17Du9FouNVlCx7lJgiKx7QDerQ8vxrOXPV20X0AJ4GpgxSAC4G g==; X-IronPort-AV: E=McAfee;i="6600,9927,10982"; a="12585031" X-IronPort-AV: E=Sophos;i="6.06,157,1705392000"; d="scan'208";a="12585031" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2024 09:07:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,157,1705392000"; d="scan'208";a="7582684" Received: from kyogendr-mobl.amr.corp.intel.com (HELO [10.209.45.153]) ([10.209.45.153]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2024 09:07:47 -0800 Message-ID: <836c9f30-cd39-4fae-9704-67cf941422b2@intel.com> Date: Tue, 13 Feb 2024 09:07:46 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] x86/cpu: fix invalid MTRR mask values for SEV or TME Content-Language: en-US To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Zixi Chen , Adam Dunlap , "Kirill A . Shutemov" , Xiaoyao Li , Kai Huang , Dave Hansen , Thomas Gleixner , Ingo Molnar , x86@kernel.org, stable@vger.kernel.org References: <20240131230902.1867092-1-pbonzini@redhat.com> <2b5e6d68-007e-48bd-be61-9a354be2ccbf@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/1/24 15:08, Paolo Bonzini wrote: > There is unfortunately an important hurdle for your patch, in that > currently the BSP and AP flows are completely different. Do we even _need_ c->x86_phys_bits for APs? I need to do a bit more grepping, but I only see it being read in show_cpuinfo(). Everything else seems to be boot_cpu_data.x86_phys_bits.