Received-SPF: pass (google.com: domain of linux-kernel+bounces-63971-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <9399299d-332a-837f-358d-5028e50e21e9@intel.com>
Date: Tue, 13 Feb 2024 09:15:44 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH] dmaengine: idxd: make dsa_bus_type const
Content-Language: en-US
To: "Ricardo B. Marliere" <ricardo@marliere.net>, Dave Jiang
	<dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "Greg
 Kroah-Hartman" <gregkh@linuxfoundation.org>
References: <20240213-bus_cleanup-idxd-v1-1-c3e703675387@marliere.net>
From: Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20240213-bus_cleanup-idxd-v1-1-c3e703675387@marliere.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2NhaEFQU1l5R09KQ2pMWXZ5Zk9YaGxRdUkrVnpQV0NnNHBVSjh0U0pGWGxH?=
 =?utf-8?B?WFQrd2F0aC9XcHJmcWhCMUdxK3lqR2N1Y2Q3OHpoZUdRZUdsVzUxeW4zeEtR?=
 =?utf-8?B?aXVxQ1R3M01reG1KUzM5YSt4Y2oyQnRraVZMQk1iRWVnTm52emI2eldPWGtw?=
 =?utf-8?B?Y1E1T2lpOE1PWERWVHROMld3U0VuSFpDM0hzOG5ycXNqQzZBNW8xOWtKbnVV?=
 =?utf-8?B?d2Z6S1VxNGxDenkxRGYwQWlXV0QxUmZteC95cWttWC9NUW1YMVdMa29ZOTd0?=
 =?utf-8?B?Ujl2Y1U2bVA4N09wVzFJRll0YzF3TUFxWitZWDJsKzNZWHlZQXZ0aVBWalFC?=
 =?utf-8?B?VmV3aE1tK1l5Rm5XZ3NPMEtIZlRVMGZXbzhEQVExelBUaVl0dEpxK2R2QjdK?=
 =?utf-8?B?MnpPVXpMU2pUYS84VWVUSTJJRE5lODFFY1Mwc0YvWEMzRUtqcTBpQTU3RHNz?=
 =?utf-8?B?TU1OellsWmJpUjhnd05TdENtY016MFo1VjVtL2F0d1NCT0dxbFpPRW1wZTFV?=
 =?utf-8?B?Y1BKTDJtY1QrRmFWN2NKZitiLzRNcWNscTU4UjBnam5TQ3lJNTBUc3dVRE8v?=
 =?utf-8?B?NUVWa3AvUTlGOVhYUkZ0N2FqZmk2RjhySWZmbFd6bVR6YzhvNldHYWhNZ3pM?=
 =?utf-8?B?MGVXRXpRM01ZR0RYKzNSZUx5MGJ5WXZvamk5WTJCK25RRjNBQklnbjZrN21q?=
 =?utf-8?B?K2NnNGEySFlRUWxndmhKY1RNa1RSN1lxVzVhaFBrWVhsaTZJWGFJRmVUdDF4?=
 =?utf-8?B?ckJwTDRuWS82TnNLZkxtcHIwK1NEd0FjeTJOdmZPYzUvajNuenNqQmcvMmQ4?=
 =?utf-8?B?aGdpWGNjRkwwaVVib1U0Mmg3WVBtd0tIdDdleUhrVXNjMUNoTnFMd1FjR2FG?=
 =?utf-8?B?TTdacVBFR1Z5c0MrdERubTJUdGYxOFNSZGwxWU95TWwrVW9yTzM5a3RvbjZ2?=
 =?utf-8?B?VmlJcWVHZTZQTGxyTjNXOEJZVzQrTWMrNXdaSG1oTllib1JmWjFVenpKZnFI?=
 =?utf-8?B?R2xaaDlsNGNOc1dUSG50K2I4RytJWEp4ajBkZlc0QzV6N1p1TFBHd3ZWSSt5?=
 =?utf-8?B?VTBMRWFWajNrdzNXdzV0RUN1SHM5MU1kbzdSamF4SXR1aloxdkJEWTVybGVz?=
 =?utf-8?B?ZnBlZlVrQ2E2bHBJaHFQcjdrQzQzNU8xUEgzdHFpcmtwZ1d1a1A3TXFISzlm?=
 =?utf-8?B?WmdaNHNZTjJtdEpoT1hBbUVhYW9nb3BCYjVpZ2dpVyt3anNjQU1vNmp2aEl1?=
 =?utf-8?B?Mnh1eklKYUZEQmRiZXFuRXFrTytZdmoxYlRvVkZHR3NFS3hrdWJ5WURBMjNa?=
 =?utf-8?B?cmlFYzIrVW1FTDAwOGFzL3VId2hZM05FdlVhaDNSSWRESmp5a0ovWU5UMlRo?=
 =?utf-8?B?WXlqaDZqMHJSWVBmZDYwSGk4UlhzTWQ3M1FlWVUvV1phK0VTeUtrZVZmYWdt?=
 =?utf-8?B?eGJhT2VFaWhtdmg1UTN2VnJVZURDa3RhejJoSTRhRHF0UmFwY3c2UENkSFQr?=
 =?utf-8?B?cDhFV1VCRENjSmlycitQRFlGa2ZHenlRdlhnYkVzenQ3STRYcFcrNnhBS1Jo?=
 =?utf-8?B?OWNiQnVQdmY0eXRGMVZMVTFOUUZTTHRaelo4VUFzTnFhemY3ZGtWejRmV0hk?=
 =?utf-8?B?T0NUMGlyODhNTGFqRVc4ekt5bUdyajU2MGVaTlFNaFNXMVo3MkZ3LzZnSE41?=
 =?utf-8?B?QUxtZzd1UUtKT2cxNHlkbFpCYW9xYkJIcWZ4QUlLUVNKQzQ5QytUUXRqZmh0?=
 =?utf-8?B?ZENNbG1lRUd0TTd6VXMvbTljWGM2OHIxNVl1TXI3TGt5SEN1SkZJU2dGSnZp?=
 =?utf-8?B?SSs1cDZKcHZydlNCRWVqZDZ2ZWRlZTd0L000alVPZnAzTS9mZkF4VWNwOHFp?=
 =?utf-8?B?QzNCK2dta2c0Skl4WGpIUVU4Z1MyM3h3Um5PNjdabnFjYnZYTHRoYllTSXli?=
 =?utf-8?B?S0UyZDltcVdVUWtqSGpWRjkrRU9nNmtab2k1MkFxbnBpRkRXZ2dHVFprV2hL?=
 =?utf-8?B?MlZ3YkN4d3RIUFhjcTRqdFVJeUZRRzBPbjNwQkJvaEVuZjNIak1NZW1vU1Zy?=
 =?utf-8?B?TmJ6V2lsV3YxS0NKZUw5cDZ2QUdJNDNlbWZIRDNMc3I2MEcvMzljclZxNWxW?=
 =?utf-8?Q?1WPDGd7I7KVwANbLed0EPpMEg?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 34b2b504-03d9-448d-1160-08dc2cb778aa
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 17:16:09.6940
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NGkZS85TSE237US6ekIieDyMsJ4khjV/UjVcNgHx2QTLb3zMYPgTvcSTaYAEph8THP/mwrqncHNSOX4MkTiO4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5253
X-OriginatorOrg: intel.com


On 2/13/24 06:43, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the dsa_bus_type variable to be a constant

nit: s/, move/. Change/

> structure as well, placing it into read-only memory which can not be
> modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

> ---
>   drivers/dma/idxd/bus.c  | 2 +-
>   drivers/dma/idxd/idxd.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/bus.c b/drivers/dma/idxd/bus.c
> index 0c9e689a2e77..b83b27e04f2a 100644
> --- a/drivers/dma/idxd/bus.c
> +++ b/drivers/dma/idxd/bus.c
> @@ -72,7 +72,7 @@ static int idxd_bus_uevent(const struct device *dev, struct kobj_uevent_env *env
>   	return add_uevent_var(env, "MODALIAS=" IDXD_DEVICES_MODALIAS_FMT, 0);
>   }
>   
> -struct bus_type dsa_bus_type = {
> +const struct bus_type dsa_bus_type = {
>   	.name = "dsa",
>   	.match = idxd_config_bus_match,
>   	.probe = idxd_config_bus_probe,
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h
> index 47de3f93ff1e..f14a660a2a34 100644
> --- a/drivers/dma/idxd/idxd.h
> +++ b/drivers/dma/idxd/idxd.h
> @@ -516,7 +516,7 @@ static inline void idxd_set_user_intr(struct idxd_device *idxd, bool enable)
>   	iowrite32(reg.bits, idxd->reg_base + IDXD_GENCFG_OFFSET);
>   }
>   
> -extern struct bus_type dsa_bus_type;
> +extern const struct bus_type dsa_bus_type;
>   
>   extern bool support_enqcmd;
>   extern struct ida idxd_ida;
> 
> ---
> base-commit: de7d9cb3b064fdfb2e0e7706d14ffee20b762ad2
> change-id: 20240213-bus_cleanup-idxd-8feaf2af5461
> 
> Best regards,

Thanks.

-Fenghua