Received-SPF: pass (google.com: domain of linux-kernel+bounces-63959-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 13 Feb 2024 12:06:09 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Lokesh Gidra <lokeshgidra@google.com>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        selinux@vger.kernel.org, surenb@google.com, kernel-team@android.com,
        aarcange@redhat.com, peterx@redhat.com, david@redhat.com,
        axelrasmussen@google.com, bgeffon@google.com, willy@infradead.org,
        jannh@google.com, kaleshsingh@google.com, ngeoffray@google.com,
        timmurray@google.com, rppt@kernel.org
Subject: Re: [PATCH v5 3/3] userfaultfd: use per-vma locks in userfaultfd
 operations
Message-ID: <20240213170609.s3queephdyxzrz7j@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Lokesh Gidra <lokeshgidra@google.com>, akpm@linux-foundation.org,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, selinux@vger.kernel.org,
	surenb@google.com, kernel-team@android.com, aarcange@redhat.com,
	peterx@redhat.com, david@redhat.com, axelrasmussen@google.com,
	bgeffon@google.com, willy@infradead.org, jannh@google.com,
	kaleshsingh@google.com, ngeoffray@google.com, timmurray@google.com,
	rppt@kernel.org
References: <20240213001920.3551772-1-lokeshgidra@google.com>
 <20240213001920.3551772-4-lokeshgidra@google.com>
 <20240213033307.zbhrpjigco7vl56z@revolver>
 <CA+EESO5TNubw4vi08P6BO-4XKTLNVeNfjM92ieZJTd_oJt9Ygw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CA+EESO5TNubw4vi08P6BO-4XKTLNVeNfjM92ieZJTd_oJt9Ygw@mail.gmail.com>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Q2tmbk15WEJqSjBuM2xjcWxCWHlPTjNBN1pVNjNKbVdMaHVZZ0tNbGFqRnkx?=
 =?utf-8?B?L1lDTk9vRGNTNCs5TkxoUFlCZHpHaDVSWDU4N2RGUjc0RTZsSEhXZDlmZkU0?=
 =?utf-8?B?YUtEOXRnRXlKNUdTNWlFVS90T1lZaEdlSml3eDBLUHRIaHNjKzJLc0NBOEda?=
 =?utf-8?B?V1BadUIvYlFKaWVQcmJBd2RGbzdSZUo2MmpROUhDamhvWGlHVTYzd242enlF?=
 =?utf-8?B?QmRMYkI4OWZaSFFOaFU1ODdRMFpnWENtaTJTN2JHenNnbzlCNFZYSmYrT0Ux?=
 =?utf-8?B?ZkEwYi8xR2JuWTZYYnhLM21pK3hLYlZsSVJudk1VbGRoU3g5ZHV1a0luNHlW?=
 =?utf-8?B?c0hnNEhKNzBCYzAzaWtVVnVIOVVXNHM1RE1OVGtDeWNoWVJnczFWSzhXYnpa?=
 =?utf-8?B?c2pQR1J1aGtEaUFOMEc3VG1RUzdENzFqMElvYjNPZVB1OEJHNFQrai9GSlRG?=
 =?utf-8?B?SHdLOEE5WUNEVDUxSzMrUUJmU09UTkhKRE9FWSt1NzlxdDJmZEdJeDFnOHhG?=
 =?utf-8?B?SnJCTlJmVVIrSzc4Vk5zLy9VQ2xibmNlNTRRRlNXUW5wanJodzVUM240ZmdS?=
 =?utf-8?B?S3lxcGhkYWZXSFpCZUhVUmUrQjNibkszOEFsTTdHUERTbVBGQ1ZjeTNKWVJh?=
 =?utf-8?B?K0F5VmdDY2FmWVB4MlNvcHFBdW9jOE9yOVozaTBkbTVZR1o4MXpNaGtWcE5R?=
 =?utf-8?B?TWp4SFh1TExkNFVoU0F1Q1Btb0dtTHBmQUhwdFlCZEdscStXYXN0U2dNa1pN?=
 =?utf-8?B?VnpHWTdNVlBXdHE3TzRuMnJPdGdlSCs2RmhwQldWMTJhWU9HUW5QU1ptdlVw?=
 =?utf-8?B?bDVucW5MSGFjVktaUWQya1UxZFdST0IwWndwb0Vac01LL3FBWWFvUVNKMGg1?=
 =?utf-8?B?ZFcvUCtrSVZpVzhCVGtieGV0cVR6L2dPekRJdnh1aktoS2ViYW5iSkVSYXNU?=
 =?utf-8?B?RVJITmdlK2U4YjZJM2pTMlVFL2xVMTY1WXdyTkJzVTM1S054dWZHYk9BQTla?=
 =?utf-8?B?WjlkN0hDL0krRHFPbnFLZ25zQmptc3VSMkxBVUl3MjNkMjJLdTZDWUcyZG9n?=
 =?utf-8?B?c0tjNkFMM2JDeUNnRGZ3SkpQUUY5S2ptcDg2UjkwYUlSUGpmbkFGNmZ6ZUF1?=
 =?utf-8?B?ejhUdjloa2M5ZkRhYmJPM2E4bllsVGM0L3QvRGROSUtwMFF5Y0plS0UvQWk3?=
 =?utf-8?B?NDBQeVdBMGV2K29odlBIYUlyc1o1RDBOR3JrK0k5Wnd5WlhpS2QyN2ZjaUZV?=
 =?utf-8?B?Nkc1bHFndi9JWGZadURXdDk5QUQ4cS9yYUVCR0U3WEdKUXVCNytCazAzZXlE?=
 =?utf-8?B?SGNEZUlsWU1rRWsrNEVPWkZKNUlKMy8vZGlpVWlZb1dtMjZXekNtb0xWeUxU?=
 =?utf-8?B?dUVJQjdCRHFHcXJNREVVMStiNk0xeDYxLzFwTEtwMW9MSUZBUHhFL09SY0Nt?=
 =?utf-8?B?YmJ6bVBEU21TY0VNMHVTVHhaTGg3R3NnNGM0cDFjSm1KT0loRkhNTmpDdFdZ?=
 =?utf-8?B?a1lGZ09vaS9vaTd6T3dHTkkyN1hwRURYU1JsYTVPNnlSZjVWbUt4MTZZcGRo?=
 =?utf-8?B?NnhJWUZIOTdPb0xmSXljVjB1elZmNkZWRkR2RWVFY0NkWk15dFJVK013blBx?=
 =?utf-8?B?VklPOWRkZm91TTRPU2YzRUtrSDA4b3J6SjBKNDNUVTZkVktFdGMyMHJhbEVn?=
 =?utf-8?B?SEpLZzY4eE41VzJwdWlzQ2EwWjdlTWl2K0Nvb1hWTWRmS3dZaUVmT2swS1ZE?=
 =?utf-8?B?ZTFqZXZVZjZKcmxyczFSOE1BUDJHNVFlMmhjOGNvS25zTmpFUDZ5VzhGTmYz?=
 =?utf-8?B?YTAvdnBhOGNza2ZYQzFFK2V2QXNhR1IzeE1Cc3ZIUTd4V3pvVTVrSng3YU1k?=
 =?utf-8?B?YkpESndwazRhSlBWTWR6blRXelp6SmthWE4wVy96NzBIZzVZWmZhQmVYcitH?=
 =?utf-8?B?Y3NFRzBWeUR0UU42SU9WZGpTOWF5UmRIMHB4RFAxL0dCd2J2aGpJTmFaMGht?=
 =?utf-8?B?dmhQaC9SMmdBMFZScXF3VGZ4Ylo2bWFtZkdYTXM1NysxQ3ZCOFhsZ2FudTRn?=
 =?utf-8?B?T1B0R3BpV3RWa1V6MlFrRGQ0TGRxLzl1QjRwVjE4VzlJYzVwZCtkWEhEY1pp?=
 =?utf-8?B?VVIxMlFDV3lDVDZxaTRVc3NHTnE3a2FWWE9OKzFqb1Z5MmxDTEJiQ0R4eXh3?=
 =?utf-8?B?TGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	08k/7c3Y5DI1EbU5E192C2ZesHBC9lfd3sbToDK3KIIBF9/sXJ2863j0zwtkws4BV1wQlpNY/s6acVNoL8qlJn+6wKIvUJbaUeUCWq0oykhBrUyPOGVQwBQ8chgQ1vOjE+PeKmeVzvimLKGHwh5YFXkNk1fSYTRkl/VfgecHeTF4cpm7USS6N5PSRrJ4EHfe6fFGI85JAcrwXXEqZvMmRk9+DsS5GSLrpv7AVGSQggy6KU23IIieNwGQCRg23PNIzuybcmQn5z+Bj621X87GDfc52I8I9n69uY/I5PCTfxEb89VnZithzbtJsrH2mV0kZ8eb6WgCTi46E8SL2MYAPx883R0/EyK06nKmZLevMlkwCqxv/7Bnk0OqPD/Uk5Rlm1Jr0ZirTSZY7fj+jUymeoA8ljvwYU9DRKlUTrtsbs0KHGyFvFGqeuy3wjB8AKRyFsfQkYzGVdDdc2hXoClUUFiH6jjHuGWimZ344bgItBZkTs9gL20msVlkn/YY+TaTWZEb6HfQmD+MMbaXOx4iX0XrlfiQ8Y5SEHM1My4jt3N2ziAp9c/9Lw1/wHdObpjWzNoAhw1CDOU9joFRU68giezNL32QVkd2rYc5ZRvL6cw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44da5c60-7447-40a7-9d25-08dc2cb6148c
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 17:06:12.1542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fkIE9Ec53I3hPAT7svvfcuAMPBsPnvE5rCurMjf5H63vgN7hWJ0rhE0b2RUT4MJN8eyZpvCAp4hNwzMY1zUXZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7229
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-13_10,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=488 phishscore=0 mlxscore=0
 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402130134
X-Proofpoint-ORIG-GUID: yUIHXhUrrqkk-YlnN-Fz_mglv7-QHmAP
X-Proofpoint-GUID: yUIHXhUrrqkk-YlnN-Fz_mglv7-QHmAP

* Lokesh Gidra <lokeshgidra@google.com> [240213 06:25]:
> On Mon, Feb 12, 2024 at 7:33=E2=80=AFPM Liam R. Howlett <Liam.Howlett@ora=
cle.com> wrote:
> >
> > * Lokesh Gidra <lokeshgidra@google.com> [240212 19:19]:
> > > All userfaultfd operations, except write-protect, opportunistically u=
se
> > > per-vma locks to lock vmas. On failure, attempt again inside mmap_loc=
k
> > > critical section.
> > >
> > > Write-protect operation requires mmap_lock as it iterates over multip=
le
> > > vmas.
> > >
> > > Signed-off-by: Lokesh Gidra <lokeshgidra@google.com>
> > > ---
> > >  fs/userfaultfd.c              |  13 +-
> > >  include/linux/userfaultfd_k.h |   5 +-
> > >  mm/userfaultfd.c              | 392 ++++++++++++++++++++++++++------=
--
> > >  3 files changed, 312 insertions(+), 98 deletions(-)
> > >
> > ...

I just remembered an issue with the mmap tree that exists today that you
needs to be accounted for in this change.

If you hit a NULL VMA, you need to fall back to the mmap_lock() scenario
today.

This is a necessity to avoid a race of removal/replacement of a VMA in
the mmap(MAP_FIXED) case.  In this case, we munmap() prior to mmap()'ing
an area - which means you could see a NULL when there never should have
been a null.

Although this would be exceedingly rare, you need to handle this case.

Sorry I missed this earlier,
Liam