Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757412AbXLXCvX (ORCPT ); Sun, 23 Dec 2007 21:51:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756420AbXLXCvJ (ORCPT ); Sun, 23 Dec 2007 21:51:09 -0500 Received: from scrub.xs4all.nl ([194.109.195.176]:2418 "EHLO scrub.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753684AbXLXCvF (ORCPT ); Sun, 23 Dec 2007 21:51:05 -0500 From: Roman Zippel To: "H. Peter Anvin" Subject: Re: [PATCH] Avoid overflows in kernel/time.c (version 5) Date: Mon, 24 Dec 2007 01:14:12 +0100 User-Agent: KMail/1.9.7 Cc: Andrew Morton , Linux Kernel Mailing List , Linux Arch Mailing List , Ralf Baechle , Sam Ravnborg , Paul Mundt , Richard Henderson , Michael Starvik , David Howells , Yoshinori Sato , Hirokazu Takata , Geert Uytterhoeven , "William L. Irwin" , Chris Zankel , Jan Engelhardt References: <200712180541.lBI5fnqB028037@tazenda.hos.anvin.org> In-Reply-To: <200712180541.lBI5fnqB028037@tazenda.hos.anvin.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712240114.13431.zippel@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 23 Hi, On Monday 17 December 2007, H. Peter Anvin wrote: > kernel/timeconst.pl | 340 I agree with Jan that it would be better to put this into scripts. In the long term we could also detect some of the simple special cases, so we can finally inline some of these functions again, this would mean the generated file would go into include/linux/ and the script should be in scripts/. > + my ($b,$n,$d) = @_; I noticed this already in the old script, using something else than single letter variables would increase readability considerably. bye, Roman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/