Received-SPF: pass (google.com: domain of linux-kernel+bounces-64001-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 13 Feb 2024 17:43:35 +0000
In-Reply-To: <e094857d-41c8-4064-8475-a5a43e315f6d@bytedance.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240210-zswap-global-lru-v1-0-853473d7b0da@bytedance.com>
 <20240210-zswap-global-lru-v1-1-853473d7b0da@bytedance.com>
 <ZctnRnNMOwQNn_3j@google.com> <e094857d-41c8-4064-8475-a5a43e315f6d@bytedance.com>
Message-ID: <ZcuqR7KeBPuarevU@google.com>
Subject: Re: [PATCH 1/2] mm/zswap: global lru and shrinker shared by all zswap_pools
From: Yosry Ahmed <yosryahmed@google.com>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, 
	Nhat Pham <nphamcs@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="us-ascii"

> >> @@ -353,30 +353,16 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor)
> >>  	if (ret)
> >>  		goto error;
> >>  
> >> -	zswap_alloc_shrinker(pool);
> >> -	if (!pool->shrinker)
> >> -		goto error;
> >> -
> >> -	pr_debug("using %s compressor\n", pool->tfm_name);
> >> -
> > 
> > Why are we removing this debug print?

This pr_debug() was introduced when dynamic zswap pools were introduced,
and it was supposed to be printed right after the compressor is
initialized. IOW, it is supposed to be after the call to
cpuhp_state_add_instance() succeeds. The call to zswap_alloc_shrinker()
was mistakenly added above that pr_debug() call.

Anyway, I just realized you are now removing all failure cases between
than pr_debug() and the zswap_pool_debug() below, so there is no need to
keep both. You are right.

I am wondering if these debug prints are useful at all now, but that's a
question for another day :)