Received-SPF: pass (google.com: domain of linux-kernel+bounces-64041-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <705ebfb9-e9a6-4dc1-8974-2fa8d93ca45a@kernel.org>
Date: Tue, 13 Feb 2024 18:58:41 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [GIT PULL] tracing/tooling: Fixes for v6.8-rc4
To: Steven Rostedt <rostedt@goodmis.org>,
 Linus Torvalds <torvalds@linux-foundation.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>, John Kacur
 <jkacur@redhat.com>, limingming3 <limingming890315@gmail.com>,
 LKML <linux-kernel@vger.kernel.org>
References: <20240212170107.60da326a@gandalf.local.home>
 <CAHk-=wjQ9BJKBPi3sJN2Dy5jVwPO03u9aOc6-g8AnLcGq-E4-g@mail.gmail.com>
 <20240213124858.0faf6207@gandalf.local.home>
Content-Language: en-US, pt-BR, it-IT
From: Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <20240213124858.0faf6207@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2/13/24 18:48, Steven Rostedt wrote:
> On Tue, 13 Feb 2024 09:32:26 -0800
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 
>> On Mon, 12 Feb 2024 at 14:00, Steven Rostedt <rostedt@goodmis.org> wrote:
>>>
>>> Tracing tooling updates for 6.8-rc4:  
>>
>> Bah. I've pulled this, but since I did a new system install due to a
>> disk upgrade some time ago, I once again don't have libtracefs-devel
>> installed.
>>
>> And guess what? The dependency rules are - once again  - completely
>> broken, and trying to build this gets the bad old unhelpful error
>>
>>    latency-collector.c:26:10: fatal error: tracefs.h: No such file or directory
>>
> 
> Hmm, that's not from this pull request. But still needs to be fixed.

I did not catch that because it is in the tracing dir, but not on rtla. It is an old
sample code, still... bad it was not covered. Sorry for that :-(.

> 
>> with no help for the user.
>>
>> Yes, I know what to do. That isn't the point. And no, this isn't new
>> to this pull request, it's just that on this machine I haven't tried
>> building the tracing tools in a while.
>>
>> Let's not make the user experience for people who want to do kernel
>> builds any worse than it has to be.
>>
>> Side note: instead of the (clearly broken) special Makefile rules, can
>> you please just take a look at the perf code instead?  In fact, maybe
>> it's time for the kernel tooling people to try to unify and come to an
>> agreement about these things, and share more of the code.
>>
>> Because unlike the tracing tools, the perf tools seem to generally get
>> this part of the build system right, despite (or probably due to)
>> having a lot *more* (and more complex) library dependencies.
> 
> Daniel is mostly maintaining this work.
> 
> Daniel, can you talk with Arnaldo and be able to collaborate with him on
> consolidating the build process?

Sure, I have a good relation with Arnaldo, and he is aware of my work as well.

-- Daniel