Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp85541rdh; Tue, 13 Feb 2024 10:05:46 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWPWW9UOHAacWMbc9mcV/Ljhz+EHNwT+YpCg3gMvjZ+Pm9VaPGNLTk80Ixr26kcdx77JAxYU1hPxS0TGIPVR0Nghp/htW2P6CdKdQOsSQ== X-Google-Smtp-Source: AGHT+IH6L/dAHJdF1VXbbjgU3CeLDZFyUTXRN6jOxV2KZw+6Hf27bg0aho7dwQZRtKtj4fcU29Ae X-Received: by 2002:a05:6214:1309:b0:68c:746f:734b with SMTP id pn9-20020a056214130900b0068c746f734bmr308342qvb.26.1707847546410; Tue, 13 Feb 2024 10:05:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707847546; cv=pass; d=google.com; s=arc-20160816; b=P3uPQXQ8TUKVr6CWL7RFnjpnkeqitrBJ7vqYQ+HbzbkIOsnveORUUnXP9+Pa0/VEYr cHu7xGODNy3UVR63vChXAI1lFBGMZraQyK3J7Ghx10kITTXTcjPohHMLytpFSdIwFXr4 x+tzGDKAQgwMakzDb4PZ97BPAjMhD07OTW3MPeTZ0uiAY7FXXLUvkugYVY8qvijNdFuT fN8s5/q1Cl86j9INEiXYRlBH0SrDzQLTg7/nXt/dBFkLPzZXNGGSkBslkZ2B3R+ppjHI DLP8SxBw73J/EM6L2CRR3n+qB3FTqcxcyDDOpQNNbIGAqa+SPLmReWYJheHhbh5XNNU6 y+Gw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Z683nDiAFWMFqkS6fxiNDX7S2dAqX+dZ9gXZkcwbwXs=; fh=iNE5Gu2pIm15EvmmU7t+GOVfweKcUOjihTLft4CrHU0=; b=JfsuXhrV+5PGIgGhdGil26uEUYX9VZn1HPaPWo9F4mZE6y0RCb0Urb5LvBASSoG//S LA12Ld6jkBxze2+UIV9IzkSFWPly//jfOKKTMk0YXJHtD6AM7YqkMoEo+0buMU9xx0J6 mhsimYBnPMgKkNG124FOzhf3AV9BDTq4uvJ+EDsOz3w4AL9ldSj95RGxQN8oPpEu5Bu3 3UBh05+b3ZO8Kx6IheuC3xoTTJ0OJA9ypuRiRqjb3hhyxA5Z26PdOjPYhmQ3uqePF9xp AmAQ+qYKtLNM7lZiuZRQvlkriBfsMWGXv9WU/3wqfLjfNjoSaZfgg9Hl3FdiSGmN96qG urxA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WYsy4lZu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-64049-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64049-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUSV0lhT1df+Y7tSjKn4or/ryvNUgvLzi5ss4n6sKB0t9pdzuiZbA2ueOViMDYa3KcISb+4u9AKwyEEKibfhJz8J2U4gX8UdxAS1xaqiA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id m11-20020ad45dcb000000b0068ee6ce5c28si1847381qvh.162.2024.02.13.10.05.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 10:05:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64049-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WYsy4lZu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-64049-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64049-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C7AA81C21400 for ; Tue, 13 Feb 2024 18:05:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2A033605AE; Tue, 13 Feb 2024 18:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WYsy4lZu" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C903605A3; Tue, 13 Feb 2024 18:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707847499; cv=none; b=SMvMvcwjcjH/7NuLMj4ua6m1I4gse8l14Mx5QgVpTqjdDQHMoIrsU8Nm2NylLADPPXVtL74ThYSWGhPySwIOlbQ/AySl/6m9H+S2Xc5va1q4NKf7sM3qk+dTU8C67ybV3D7JFSVf2uR7XNACPKFUQzKhhKk7HMzlFYow4kVwSCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707847499; c=relaxed/simple; bh=QcYIDSiCp33r8BU8FmPB//SjKuQcfdO/ovF933HfSR0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vFT0LS704obkYFhMysJF2ub1TOjiuh/RxatYagFnNBXF5VSZBEVpeA5hBXZKH5+Y0i7oSjVF6pN7aD2MK+E/MVWVvS41tW/aHO6SUiXwzFvXjkJZp572aMGJ9bZ3kPlTAXZAXiEQurH35lYLDepuB7NV+EI7IAknW8K8SuEnc7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WYsy4lZu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22B20C433C7; Tue, 13 Feb 2024 18:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707847498; bh=QcYIDSiCp33r8BU8FmPB//SjKuQcfdO/ovF933HfSR0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WYsy4lZuf3g58s8VpVgwI7cVjG5uF7Qa2eo1nxCkDfnZr4/o36pygCwWDZejklHzi OeFJY9XVFDnZ0W4GVozJnViVjQ4C4CcztMhkG9KofurM4VHEoHYazoX00ogQBAbIYq 0JXqo4DmZQiW/SrbWAP5vb8ZpAPTFUmEE3fS5nYR7qQN8KREaN1GxOUg23CMqHlXgq q5UEwjLwqdTaB/X7pn2O4W5RzcQCBxsmFE8bNGuNAJDoNlDLI5Cx+6KSpI4DO85roV gQVjDZA9BHOJAjzBDuP67j9xlhQdaTNMpBGFYJxxIQVq/nwbMFVP/AuEsaA0sXdTMS ig8OXTK0lRCXg== Date: Tue, 13 Feb 2024 10:04:57 -0800 From: Jakub Kicinski To: Eric Dumazet Cc: Breno Leitao , davem@davemloft.net, pabeni@redhat.com, Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , weiwan@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, Jonathan Corbet , Randy Dunlap , Bjorn Helgaas , Johannes Berg , Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= , "open list:TRACING" Subject: Re: [PATCH net-next v3] net: dqs: add NIC stall detector based on BQL Message-ID: <20240213100457.6648a8e0@kernel.org> In-Reply-To: References: <20240202165315.2506384-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 13 Feb 2024 14:57:49 +0100 Eric Dumazet wrote: > Please note that adding other sysfs entries is expensive for workloads > creating/deleting netdev and netns often. > > I _think_ we should find a way for not creating > /sys/class/net//queues/tx-{Q}/byte_queue_limits directory > and files > for non BQL enabled devices (like loopback !) We should try, see if anyone screams. We could use IFF_NO_QUEUE, and NETIF_F_LLTX as a proxy for "device doesn't have a real queue so BQL would be pointless"? Obviously better to annotate the drivers which do have BQL support, but there's >50 of them on a quick count..