Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp99949rdh; Tue, 13 Feb 2024 10:31:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXX6cQHP0NFYrLIdRkMhFaltQjh2iVURGjQvL6/o9/Rzocb+EdY7xYJtdFR9OnNNS7ncIUzWBLMsFyUzeSzLr5Fvk4Dxui4lwuqMTG0Vg== X-Google-Smtp-Source: AGHT+IFgTcK15LPnNMR6Rjijz7ga2lIO+UnKdAG0MLXYs0F3pbaBscNgaar53OqosjAcgx1yWMot X-Received: by 2002:a05:6a00:1a90:b0:6e0:6e9b:2866 with SMTP id e16-20020a056a001a9000b006e06e9b2866mr86524pfv.12.1707849063619; Tue, 13 Feb 2024 10:31:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707849063; cv=pass; d=google.com; s=arc-20160816; b=rBc+EnhYhx/uiyk5shwcPGIIBGCk/ztnSGI36lvIVZNJ5u1WRa1x/gybF2T6ExGo6R oeLNSgFfBTH7WeSmqVzOZHOR7S3oLClHPwLrV7AwJtbdCDPwjcd/PWImaASXHeEd+93H El5LIaI2iKAU21o686ice9nyob5M/1BwGM27rFbKGkvvj0lbuXmdiMlygAZvIsdfQPsn kMRxvvEsEW71NBPnqUvJpgVfK/+Q6oDRrzNr1iuGdXnp6oDHWVyHwBrST/A5X+1Cpf+8 hSi5NSMD7fDEx/uxBWo04tqXRc5BdivJUMWh5nrhHNErY6pd3ds82lPo0/Q8N9jZTz8B G1Pw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=uHSjEZZv5LhPxGfb2xIn9VtOM3pAfHSS36rJfvlkgS8=; fh=XAnwi6xqD7ZJobsNe2dZxZLVOYpUlIRFMsiuZRqCM74=; b=oqIGv925Ahs3kCPpp3P6cy3QpXxPvCh2c3khrBrdY8kLdC8CL6149BRbc3hOljEonZ bqqlS2ls+k2kUwfnK4KRsJi5aQXoVXsbmVr34WnaIiFndJD6kVVtPh9+B1j6UymBaHUO 9p+cmw2x3f0cuYAeJ56B8ssPMFkUE2deEGuFFfB3LRPV7b50al1WTTh9eLoqAN9s5vGK joAbQA+Gn5pkZ/uuifpBV7AScdkbL+I+60l7uP3/5gvOF5Y2n7Pi5VlDIoa+tHXNpMda trQsjF8nilHmj8zGGH5XvLzVcjZLyUQPpVBW8AD1GpLVQvbrsaJLUNOTJBdDtUE4DMez p3FA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=GZWk6ttF; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-64045-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64045-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com X-Forwarded-Encrypted: i=2; AJvYcCVEUchaPpE/3yvATsPMhWLpE3aTcCmBaChmoWtZadkyybqw38aRjXVSBxATPL5fX1iyxrGZN+DsncV3pE1u59Cexvcc+STCwhS+9LY+Ow== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id o27-20020a63921b000000b005dc42fd2ea5si2265382pgd.889.2024.02.13.10.31.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 10:31:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64045-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=GZWk6ttF; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-64045-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64045-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5659EB21D50 for ; Tue, 13 Feb 2024 18:02:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 55B0E60B96; Tue, 13 Feb 2024 18:00:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="GZWk6ttF" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1F065FF0A; Tue, 13 Feb 2024 18:00:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707847240; cv=none; b=XTkSiZ1sHlMH8X7a1rWCLMY5LC2/MrhwtY87nDQi/rISYaHgLvwIvcKbieysibXtgqqj3rdC8Y4ZoUDHZj/1C41bdQr6OoGHdgzP9ztUdjzeqIsCnDpz8isUBj9FmrvKfVWvyaLBlOF1P/Tnf7Nw0/f/CZpkSyGSEnd0mrksslI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707847240; c=relaxed/simple; bh=rkUZTdLpAhXFhh41eEds83V0BfyHReOoNOl3qPszZvA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=dUBO/WjgQaSWSbdvwnFJIlMINYuk9Rsd/pw5s5Wb/NpYeM+RhixQ0L0zmDyr+MS0QR47uitdtNOOW8jznH0yYIQ7V1PxBmo2pgiNP7ST0YlfgqW7yYqWAsCQwAW0YXrU3IVNPs2accjnCnuNK7RamU0WV5wKbd7mbCM3dtlQdGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=GZWk6ttF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41DDAvjj029424; Tue, 13 Feb 2024 18:00:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=uHSjEZZv5LhPxGfb2xIn9VtOM3pAfHSS36rJfvlkgS8=; b=GZ Wk6ttFRJOi+4P/1ZuZpUj3dwKvYyFk/DQTvsbaNGAgpPaokcw//qqYysedh4jDtj 9vT1WZ/CQhFzIhAyhZ2I6QBQLq8fVG1Wy7gMdVZ4PxASbjhjZwPxyxqq2xb3f/mc mHe/9MX1uEv02GBt93Ie2F7rWWhN1EqY+ZneAolpIRiwBohmag/JPLQYOzeArBkP 1JGqVI4+BDY0NUQRwlUPPeZ9XgtLTV7LlNayDqneoFZOT4mmk5bV4V9IJcm3yfLQ OuvA07H8NtT+hZFH6rBR/Zt0Hdi7TVsTeE9yylUZF7pwU2xgaDcgpja6Ef4HJsuh bA6DChb6Bhpwk5IT+2dA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w7q2y2q65-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 18:00:16 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41DI0FWC015189 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 18:00:15 GMT Received: from [10.110.23.109] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 13 Feb 2024 10:00:14 -0800 Message-ID: <343710b1-f0f4-5c05-70e6-3c221cdc9580@quicinc.com> Date: Tue, 13 Feb 2024 10:00:13 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: drm/msm: DisplayPort regressions in 6.8-rc1 Content-Language: en-US To: Johan Hovold , Rob Clark , "Dmitry Baryshkov" , Kuogee Hsieh CC: Sean Paul , Marijn Suijten , David Airlie , "Daniel Vetter" , Bjorn Andersson , , , , , , , References: From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: IDbmomjLwl_cvJs5QxFrpwNYt3hwSqIG X-Proofpoint-ORIG-GUID: IDbmomjLwl_cvJs5QxFrpwNYt3hwSqIG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-13_10,2024-02-12_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 clxscore=1011 adultscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402130141 Hi Johan Thanks for the report. I do agree that pm runtime eDP driver got merged that time but I think the issue is either a combination of that along with DRM aux bridge https://patchwork.freedesktop.org/series/122584/ OR just the latter as even that went in around the same time. Thats why perhaps this issue was not seen with the chromebooks we tested on as they do not use pmic_glink (aux bridge). So we will need to debug this on sc8280xp specifically or an equivalent device which uses aux bridge. Thanks Abhinav On 2/13/2024 3:42 AM, Johan Hovold wrote: > Hi, > > Since 6.8-rc1 the internal eDP display on the Lenovo ThinkPad X13s does > not always show up on boot. > > The logs indicate problems with the runtime PM and eDP rework that went > into 6.8-rc1: > > [ 6.006236] Console: switching to colour dummy device 80x25 > [ 6.007542] [drm:dpu_kms_hw_init:1048] dpu hardware revision:0x80000000 > [ 6.007872] [drm:drm_bridge_attach [drm]] *ERROR* failed to attach bridge /soc@0/phy@88eb000 to encoder TMDS-31: -16 > [ 6.007934] [drm:dp_bridge_init [msm]] *ERROR* failed to attach panel bridge: -16 > [ 6.007983] msm_dpu ae01000.display-controller: [drm:msm_dp_modeset_init [msm]] *ERROR* failed to create dp bridge: -16 > [ 6.008030] [drm:_dpu_kms_initialize_displayport:588] [dpu error]modeset_init failed for DP, rc = -16 > [ 6.008050] [drm:_dpu_kms_setup_displays:681] [dpu error]initialize_DP failed, rc = -16 > [ 6.008068] [drm:dpu_kms_hw_init:1153] [dpu error]modeset init failed: -16 > [ 6.008388] msm_dpu ae01000.display-controller: [drm:msm_drm_kms_init [msm]] *ERROR* kms hw init failed: -16 > > and this can also manifest itself as a NULL-pointer dereference: > > [ 7.339447] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > > [ 7.643705] pc : drm_bridge_attach+0x70/0x1a8 [drm] > [ 7.686415] lr : drm_aux_bridge_attach+0x24/0x38 [aux_bridge] > > [ 7.769039] Call trace: > [ 7.771564] drm_bridge_attach+0x70/0x1a8 [drm] > [ 7.776234] drm_aux_bridge_attach+0x24/0x38 [aux_bridge] > [ 7.781782] drm_bridge_attach+0x80/0x1a8 [drm] > [ 7.786454] dp_bridge_init+0xa8/0x15c [msm] > [ 7.790856] msm_dp_modeset_init+0x28/0xc4 [msm] > [ 7.795617] _dpu_kms_drm_obj_init+0x19c/0x680 [msm] > [ 7.800731] dpu_kms_hw_init+0x348/0x4c4 [msm] > [ 7.805306] msm_drm_kms_init+0x84/0x324 [msm] > [ 7.809891] msm_drm_bind+0x1d8/0x3a8 [msm] > [ 7.814196] try_to_bring_up_aggregate_device+0x1f0/0x2f8 > [ 7.819747] __component_add+0xa4/0x18c > [ 7.823703] component_add+0x14/0x20 > [ 7.827389] dp_display_probe+0x47c/0x568 [msm] > [ 7.832052] platform_probe+0x68/0xd8 > > Users have also reported random crashes at boot since 6.8-rc1, and I've > been able to trigger hard crashes twice when testing an external display > (USB-C/DP), which may also be related to the DP regressions. > > I've opened an issue here: > > https://gitlab.freedesktop.org/drm/msm/-/issues/51 > > but I also want Thorsten's help to track this so that it gets fixed > before 6.8 is released. > > #regzbot introduced: v6.7..v6.8-rc1 > > The following series is likely the culprit: > > https://lore.kernel.org/all/1701472789-25951-1-git-send-email-quic_khsieh@quicinc.com/ > > Johan