Received-SPF: pass (google.com: domain of linux-kernel+bounces-64137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1707080349.git.dxu@dxuuu.xyz>
In-Reply-To: <cover.1707080349.git.dxu@dxuuu.xyz>
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date: Tue, 13 Feb 2024 11:09:29 -0800
Message-ID: <CAEf4Bzb8dvboBVe-qN4+KEG_=phcMxCL25dr0ysjdVx5-MentQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next v2 0/2] bpf, bpftool: Support dumping kfunc
 prototypes from BTF
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, andrii@kernel.org, 
	olsajiri@gmail.com, quentin@isovalent.com, alan.maguire@oracle.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 4, 2024 at 1:06=E2=80=AFPM Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> This patchset enables dumping kfunc prototypes from bpftool. This is
> useful b/c with this patchset, end users will no longer have to manually
> define kfunc prototypes. For the kernel tree, this also means we can
> drop kfunc prototypes from:
>
>         tools/testing/selftests/bpf/bpf_kfuncs.h
>         tools/testing/selftests/bpf/bpf_experimental.h
>
> Example usage:
>
>         $ make PAHOLE=3D/home/dxu/dev/pahole/build/pahole -j30 vmlinux
>
>         $ ./tools/bpf/bpftool/bpftool btf dump file ./vmlinux format c | =
rg "__ksym;" | head -3
>         extern void cgroup_rstat_updated(struct cgroup *cgrp, int cpu) __=
weak __ksym;
>         extern void cgroup_rstat_flush(struct cgroup *cgrp) __weak __ksym=
;
>         extern struct bpf_key *bpf_lookup_user_key(u32 serial, u64 flags)=
 __weak __ksym;
>
> Note that this patchset is only effective after the enabling pahole [0]
> change is merged and the resulting feature enabled with
> --btf_features=3Ddecl_tag_kfuncs.
>
> [0]: https://lore.kernel.org/bpf/cover.1707071969.git.dxu@dxuuu.xyz/
>
> =3D=3D=3D Changelog =3D=3D=3D
>
> From v1:
> * Add __weak annotation
> * Use btf_dump for kfunc prototypes
> * Update kernel bpf_rdonly_cast() signature
>
> Daniel Xu (2):
>   bpf: Have bpf_rdonly_cast() take a const pointer
>   bpftool: Support dumping kfunc prototypes from BTF

I've applied patch #1 as it's a good change regardless. Please send v2
for patch #2.

>
>  kernel/bpf/helpers.c    |  4 ++--
>  tools/bpf/bpftool/btf.c | 45 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 47 insertions(+), 2 deletions(-)
>
> --
> 2.42.1
>