Received-SPF: pass (google.com: domain of linux-kernel+bounces-64140-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Feedback-ID: i51094778:Fastmail
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] i2c: pasemi: split driver into two separate modules
From: Sven Peter <sven@svenpeter.dev>
In-Reply-To: <20240212111933.963985-1-arnd@kernel.org>
Cc: Andi Shyti <andi.shyti@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
 Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,
 Christophe Leroy <christophe.leroy@csgroup.eu>,
 "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
 "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
 Hector Martin <marcan@marcan.st>, Alyssa Rosenzweig <alyssa@rosenzweig.io>,
 Wolfram Sang <wsa@kernel.org>, Olof Johansson <olof@lixom.net>,
 linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
 linuxppc-dev@lists.ozlabs.org, asahi@lists.linux.dev,
 linux-arm-kernel@lists.infradead.org
Date: Tue, 13 Feb 2024 20:13:34 +0100
Message-Id: <A4AE8C4C-C37E-4026-A3CC-E613754307D6@svenpeter.dev>
References: <20240212111933.963985-1-arnd@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>


>=20
> On 12. Feb 2024, at 12:19, Arnd Bergmann <arnd@kernel.org> wrote:
>=20
> =EF=BB=BFFrom: Arnd Bergmann <arnd@arndb.de>
>=20
> On powerpc, it is possible to compile test both the new apple (arm) and
> old pasemi (powerpc) drivers for the i2c hardware at the same time,
> which leads to a warning about linking the same object file twice:
>=20
> scripts/Makefile.build:244: drivers/i2c/busses/Makefile: i2c-pasemi-core.o=
 is added to multiple modules: i2c-apple i2c-pasemi
>=20
> Rework the driver to have an explicit helper module, letting Kbuild
> take care of whether this should be built-in or a loadable driver.
>=20
> Fixes: 9bc5f4f660ff ("i2c: pasemi: Split pci driver to its own file")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Reviewed-by: Sven Peter <sven@svenpeter.dev>

thanks, totally forgot about this!


Sven


> drivers/i2c/busses/Makefile          | 6 ++----
> drivers/i2c/busses/i2c-pasemi-core.c | 6 ++++++
> 2 files changed, 8 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile
> index 3757b9391e60..aa0ee8ecd6f2 100644
> --- a/drivers/i2c/busses/Makefile
> +++ b/drivers/i2c/busses/Makefile
> @@ -90,10 +90,8 @@ obj-$(CONFIG_I2C_NPCM)        +=3D i2c-npcm7xx.o
> obj-$(CONFIG_I2C_OCORES)    +=3D i2c-ocores.o
> obj-$(CONFIG_I2C_OMAP)        +=3D i2c-omap.o
> obj-$(CONFIG_I2C_OWL)        +=3D i2c-owl.o
> -i2c-pasemi-objs :=3D i2c-pasemi-core.o i2c-pasemi-pci.o
> -obj-$(CONFIG_I2C_PASEMI)    +=3D i2c-pasemi.o
> -i2c-apple-objs :=3D i2c-pasemi-core.o i2c-pasemi-platform.o
> -obj-$(CONFIG_I2C_APPLE)    +=3D i2c-apple.o
> +obj-$(CONFIG_I2C_PASEMI)    +=3D i2c-pasemi-core.o i2c-pasemi-pci.o
> +obj-$(CONFIG_I2C_APPLE)        +=3D i2c-pasemi-core.o i2c-pasemi-platform=
o
> obj-$(CONFIG_I2C_PCA_PLATFORM)    +=3D i2c-pca-platform.o
> obj-$(CONFIG_I2C_PNX)        +=3D i2c-pnx.o
> obj-$(CONFIG_I2C_PXA)        +=3D i2c-pxa.o
> diff --git a/drivers/i2c/busses/i2c-pasemi-core.c b/drivers/i2c/busses/i2c=
-pasemi-core.c
> index 7d54a9f34c74..bd8becbdeeb2 100644
> --- a/drivers/i2c/busses/i2c-pasemi-core.c
> +++ b/drivers/i2c/busses/i2c-pasemi-core.c
> @@ -369,6 +369,7 @@ int pasemi_i2c_common_probe(struct pasemi_smbus *smbus=
)
>=20
>   return 0;
> }
> +EXPORT_SYMBOL_GPL(pasemi_i2c_common_probe);
>=20
> irqreturn_t pasemi_irq_handler(int irq, void *dev_id)
> {
> @@ -378,3 +379,8 @@ irqreturn_t pasemi_irq_handler(int irq, void *dev_id)
>   complete(&smbus->irq_completion);
>   return IRQ_HANDLED;
> }
> +EXPORT_SYMBOL_GPL(pasemi_irq_handler);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Olof Johansson <olof@lixom.net>");
> +MODULE_DESCRIPTION("PA Semi PWRficient SMBus driver");
> --
> 2.39.2