Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp191304rdh; Tue, 13 Feb 2024 13:48:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX75guuOG0DyfwjP3VFbNiOMRFoaPZ5ZSHPLLULc4TXIZ6Jz+XBoIh9Gb9q5SuAMjDhBpFuSZ0NjkpPknCr5e1kzozTeP8muDrS2moFng== X-Google-Smtp-Source: AGHT+IHuF346cGFCQ0KBRwlBHBg70TFewrprpJiayPp+FSP1Jy7LCam1iedUgloO/Mr5x3+DIgWZ X-Received: by 2002:a17:90b:2341:b0:297:18fa:eaaa with SMTP id ms1-20020a17090b234100b0029718faeaaamr732233pjb.4.1707860894741; Tue, 13 Feb 2024 13:48:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707860894; cv=pass; d=google.com; s=arc-20160816; b=hJAOXqBH/+79eD/M2ShDohFjAhlU838706HHIzA1bjrH1+UeO3khcq1F0Hn00BVYNP AUPjnb5ShqeLnZzaI9CVIOaSddz94xZ4E0T4YXC3UD0Mjfdf1NwfrAyXfXmtV0L9ZocY Wn0/tftIqAXbTr/jwcXCN0VB/4Wf4WMs6DMuC2tP0qnW0CNV4Vrx4yLloKPDkBbTpNFZ xsiZ6HVOlXWt6PLrMk56IbwuGXBllK3Nk6b2NQteALDi094/Fs+GZb4GKevnDb3PA4mV tgQvIa+cx/Y8ibN1Lyhvn44LbrwOgch8/elBBaiHtzoRxJw1SNMo0fWwf8/qnezVuh5w 6jXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=hPKvVthMBWAzdAWbIPUJR/Iy8plEfEcAcGfAR1gE6mA=; fh=75KYQPVbnzjQBhN0T+f/MRopdkBeikxxrllSocfEYV4=; b=dC5lhnYW//9lt1Axu5QweLWcqysq3XGK2bAqBkk8sUXrH2NWywA9ar8wPv+1/QKtWF //kHtXEClqyQv0uyztmpGz0BvRckDZPopUtxpcvuiZSCHXgyqTciTIQuL0FGeSDzeWQ9 ZVFocapn0A8NRe2uatqCjdIHmJRGr8N/AXOy2R8I63JEGE22pBER9qEfRd9xHyPaX/xz rKgVmbni7ynxVoc6Z8dlymzj4Zs0oFr2qwoOgxld7/kxmb3wsaUkvO2FsBZf+kI2Vom9 8R7Q+kh4X/3sK6nAyuSk2pH6WDw9MrXPXo/MBJs+IlLgra0I8d5lyCLb6vxDrgPiDsLy r/Cg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mPLvwzG+; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-64339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64339-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCV4Nl2BJbTnT083pkkMv64vY0zF5slR+j0UxYXDdEbu1tGn0/yHOEYGzQvK7yuTNjT8AZ7EhL0b3NItURbtPA9VQrvFXQ0djwbNi4CyBg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id qe13-20020a17090b4f8d00b00296fcb6d8f8si2654574pjb.179.2024.02.13.13.48.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 13:48:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mPLvwzG+; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-64339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64339-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0A35528EDEC for ; Tue, 13 Feb 2024 21:37:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 37AD761673; Tue, 13 Feb 2024 21:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mPLvwzG+" Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDB63612F9 for ; Tue, 13 Feb 2024 21:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707860232; cv=none; b=cGeHFLSs+FbBCEWoO4ohnezZ1ZT+vkfHKbjR3s8qPlXFCJOmVuZg7EAvaRDO7ewcSvRPY+NtEUvZZCJpgkhcoI0wzQqSu1urWny7P1Cek4uoJYBUzedPpXQ5ZENgy6S80SGPb4izrk8jej/hPT/PItGt1OhpTjVz3ttQHVdmmvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707860232; c=relaxed/simple; bh=hPKvVthMBWAzdAWbIPUJR/Iy8plEfEcAcGfAR1gE6mA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=WXcuoTEPPDswCHhAhmaXt2749KGcBmHw4yh2ds50O8nFvtJss1K1n18qghZqqmgfUTUBafZH26Io1nMI4nfllsv78NnUopIzeWHbtveeAp6NmjG6rm07HFqL8J0/QGNB/zJB9Nt5EA/9969f04zkoV77zFRQ4P1i+bFKyKL91kA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mPLvwzG+; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-dcbef31a9dbso1322202276.1 for ; Tue, 13 Feb 2024 13:37:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707860230; x=1708465030; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hPKvVthMBWAzdAWbIPUJR/Iy8plEfEcAcGfAR1gE6mA=; b=mPLvwzG+dAg/ZrBSskb2yaAqP1pj/EP61lY1fsx/EM7lL4aK4EbFHBRiFliToUaK1h QhVPYIXILxhPmDWiibFPnqRczQrNzyZbUfpYpIhnQnBiEPqHk7UAbNh+JEY1I8CCAYe0 sbs5fMT29hx1ng9/0rstitr6Xi451W7KSWg8gc2ac4MlSdINbROvsKZKHh0YAOgmn3i4 hqIlb9EpBkFgP34FOF17rRMhpYHDKyYl276TledgapAs/3KuZkhnxMdOPkxLWx8oHqB0 ib1dWPIFRVrRxnpcIY7rWH+/O8CvgCKU6Dbz9mPTDxf/XDvax6y/OJ7gNfDwWHszZRrJ HKpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707860230; x=1708465030; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hPKvVthMBWAzdAWbIPUJR/Iy8plEfEcAcGfAR1gE6mA=; b=YyZ6iSahJaf7WNxJ/risoQ6DOHgv7wq3JC6Ag0cI3ilSHDpLbo1pIW+L5uCuCiQPh4 rHGpitnaeAkjl6Jio1kuqm1WzddSjo3dGlOEfqW+9Glk9445/bJM1Y4GSTdP191mdil+ ZkEgfhKkQLH7d3bxadcwI0FMYV/Z1aSUMVfxCgvmbWVs8vNP0olnzYwe+b36UxvOl7pK DegHs7fEem5j0FZNnDL00KpDf5cxP6KQDrbkYGS1aP8HEagpxPJeYJGeDc6yrNwQr5HE 3ZPJBpJMxX7F9vYqkclfLm9gbNV7piVAvq1JurabsnmXX6cyfALwQlLqzBUKn863DF+1 vdaA== X-Gm-Message-State: AOJu0Yx+AzT7JuAVNbkiefN/dKBsEp5+mp7LCmUG+O5LxeS8z3ZRbkXV 16SXZSrxtRxaoUAnk1DxBjUdDwFV5frIP86K59h9vDWQQu/bz3c+4EZIrik5qrCc0+24b3AAOBv v3l1RGm5nHR85tSeVcSu3wfSOd/aJegbWvoQzrw== X-Received: by 2002:a25:210:0:b0:dcd:65fa:ea06 with SMTP id 16-20020a250210000000b00dcd65faea06mr383635ybc.24.1707860229766; Tue, 13 Feb 2024 13:37:09 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240211101421.166779-1-warthog618@gmail.com> In-Reply-To: <20240211101421.166779-1-warthog618@gmail.com> From: Linus Walleij Date: Tue, 13 Feb 2024 22:36:58 +0100 Message-ID: Subject: Re: [PATCH] gpio: uapi: clarify default_values being logical To: Kent Gibson Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, andy@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 11, 2024 at 11:14=E2=80=AFAM Kent Gibson = wrote: > The documentation for default_values mentions high/low which can be > confusing, particularly when the ACTIVE_LOW flag is set. > > Replace high/low with active/inactive to clarify that the values are > logical not physical. > > Similarly, clarify the interpretation of values in struct gpiohandle_data= . > > Signed-off-by: Kent Gibson After the fixes pointed out by others: Acked-by: Linus Walleij Yours, Linus Walleij