Received-SPF: pass (google.com: domain of linux-kernel+bounces-64462-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Zi Yan <ziy@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: "\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>,
 linux-mm@kvack.org, "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 Yang Shi <shy828301@gmail.com>, Yu Zhao <yuzhao@google.com>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 =?utf-8?q?=22Michal_Koutn=C3=BD=22?= <mkoutny@suse.com>,
 Roman Gushchin <roman.gushchin@linux.dev>,
 "\"Zach O'Keefe\"" <zokeefe@google.com>, Hugh Dickins <hughd@google.com>,
 Mcgrof Chamberlain <mcgrof@kernel.org>,
 Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 0/7] Split a folio to any lower order folios
Date: Tue, 13 Feb 2024 17:31:00 -0500
Message-ID: <F4470D3A-DC2C-4A6A-B65C-1C94D732A60E@nvidia.com>
In-Reply-To: <659e1abb-40d0-42ba-ba0a-8256d7eb1c5a@redhat.com>
References: <20240213215520.1048625-1-zi.yan@sent.com>
 <659e1abb-40d0-42ba-ba0a-8256d7eb1c5a@redhat.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_13390F71-957B-4974-917E-22BA13AE02CE_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?vsl03gJ+pL2Xh7Hdb/heTWcLxed4dq++Jh8KLuGcGgd5ZpKsPp2L4Oe1xEYH?=
 =?us-ascii?Q?RKUkBNwinnP/XtFCEZTLeSpJZTnaoDuj0aqfUHmMc0EoLw9mg/nzZe6zNUIq?=
 =?us-ascii?Q?y65o1453cNWOBF2voeY/AE5arF+WfYwC7qx4sL7FafAsEELDHEsGUacJLsOh?=
 =?us-ascii?Q?cz+GjhQr2beuoEySjpEWgU9VLhJMPVA0zW9nU4e8M52O9eHpYn1R/Ab/eLjH?=
 =?us-ascii?Q?RpLNvl8mAyS9v4N6F4RDIre7L2fpGj7t9rquOQIn7mVwLrASw5/+V4Alf/Lh?=
 =?us-ascii?Q?JTX4rPbHa6yWxQRa4mj9RUl86rBbMM4HKDxZh670MKVkc9bZ4RgOhGxOQiFM?=
 =?us-ascii?Q?GM2CpxbC/u2T0WbOXYGWVUxgRnyFmPTj9m5JHMDXF40d0ZP6mUtQQz+7XSkn?=
 =?us-ascii?Q?UylV1mmoQJn0aA8KMysa5CCq/3N7BWyMa38ZHD/mCGJMlyHXebgwv4aHCxOC?=
 =?us-ascii?Q?kRiFIoEl3epoX0KK6jP0j0hNmWYWtOe/wWxNkhqXfZsLg+/Oq02HMufRB+s7?=
 =?us-ascii?Q?awfXlNmVJ8mHiTsbP+qhOZexZLiV00O6fHi/A6Zvhr2C0dDQxekYrfsHNYJZ?=
 =?us-ascii?Q?k11l74dMM2nKdHwna+pywUYEbXalFdpsxHJMZZZxQ0rsSP6kGy9fBxUg1tMD?=
 =?us-ascii?Q?8dFptufYpCVt+I+qe8MhRVSLAHfZZBGzYa76Sh+fwDyXBdF55pY6BXvgOUSl?=
 =?us-ascii?Q?wbWh1l/+wsCvG3o25i6027qozxHaRLerCDA2QUNAGjuwgm3KbRyaaIx2TFyH?=
 =?us-ascii?Q?F5MmTbljUtoAI/rq3nBmKU/TmRV7ESjubLX9LdE70tOJSjzd8+H02W4QLF3H?=
 =?us-ascii?Q?6EREWpfMzGVKbU/1MeaDnybPDBsKYIgTFOZ0kdJRpEOiEALQIT2He4ctLenT?=
 =?us-ascii?Q?L/TZsrw0eZ8NGF+GVVrjSK6xO+cNVRLziAnKGNLYzyEUrqHmxEM30+tINhi4?=
 =?us-ascii?Q?GMBgJ1lGAvdqvnDX9W6yEGoYQqKt7AsldTDIrk6rAgWYTpcSgtrbxhERblxY?=
 =?us-ascii?Q?He2HMJOR4GF3c3TJMrPHboQV8acfFaFZZWXCAK0Uaz88OwrzhpJVrTVZ3hmp?=
 =?us-ascii?Q?P1gnFLUnNNLufX4X0zFLxZz3VH8yRAIzcHADOzYT2ZuKSjxrIXXu+gfg8f/4?=
 =?us-ascii?Q?52K3CaBb5BN7/SKhGiEAwy4RhUwFFSsz0UeVBPa3cAtXltlIpFyHCUxv9b9B?=
 =?us-ascii?Q?Iw58JKwzmD4/qQ5JEpFIioJ0+D24OV45Z0Dq+A5kObYzWEKfFwUq6xIFGutr?=
 =?us-ascii?Q?N+HVnYqhuUM3EKPfP7sUCnjK1X0RALRW5YIh+3FfOr328mUOjIOw9aPZl0dA?=
 =?us-ascii?Q?I2rLgpOv4g3l+ZSiz43iVDAUEjlxDH/CQAzYZv0pdFRPkwEp1uQixzFJVdVn?=
 =?us-ascii?Q?RnRPouApvn3xJbNudYPRyM8zvnISPcuV5dTooc7c1Tw+Lw5IUhgIdlHAVvUd?=
 =?us-ascii?Q?NRO2vM4047tUSXgnPvRov44LIqczwmp3z4+OJrNvJ3jdABP4llLQOzdSOQ1m?=
 =?us-ascii?Q?YxAbCVMdzJQEhtkIUKHIHh52BEICmUV1fDRgKtO0imHjViLiWWfgTnyssj5Z?=
 =?us-ascii?Q?+NfI8E42i3Azf0F011DZT2U6DIVc/G2sX8JN31Ox?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8493b2a8-e25d-4f15-1a78-08dc2ce37681
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 22:31:03.8212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rZLe1NDUgfQfXW79CVvTeans8itLZuZjTWdFWMTiaPp14yNFBaVoY1ntHOI/GkzE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5879

--=_MailMate_13390F71-957B-4974-917E-22BA13AE02CE_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 13 Feb 2024, at 17:21, David Hildenbrand wrote:

> On 13.02.24 22:55, Zi Yan wrote:
>> From: Zi Yan <ziy@nvidia.com>
>>
>> Hi all,
>>
>> File folio supports any order and multi-size THP is upstreamed[1], so =
both
>> file and anonymous folios can be >0 order. Currently, split_huge_page(=
)
>> only splits a huge page to order-0 pages, but splitting to orders high=
er than
>> 0 is going to better utilize large folios. In addition, Large Block
>> Sizes in XFS support would benefit from it[2]. This patchset adds supp=
ort for
>> splitting a large folio to any lower order folios and uses it during f=
ile
>> folio truncate operations.
>>
>> For Patch 6, Hugh did not like my approach to minimize the number of
>> folios for truncate[3]. I would like to get more feedback, especially
>> from FS people, on it to decide whether to keep it or not.
>
> I'm curious, would it make sense to exclude the "more" controversial pa=
rts (i.e., patch #6) for now, and focus on the XFS use case only?

Sure. Patch 6 was there to make use of split_huge_page_to_list_to_order()=
=2E
Now we have multi-size THP and XFS use cases, it can be dropped.

--
Best Regards,
Yan, Zi

--=_MailMate_13390F71-957B-4974-917E-22BA13AE02CE_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXL7aUPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUeQwP/RMkvJ3oGo5mYQVh6hBkj0FlEK/gFyX8fcRt
rFIYgrthGL0H3efj6259sLXczM4YRzvfZKyu2bAFLphQOwtgIa++Lez3lPMXRhbw
8rz4ni/uDhYmeQyNR78piZ6Zruyl3iuIAR/zfTWzhZtcv4nTsTdpvaLyDkL4Jpay
U7AnpJggZrRfkVmfXK9l40Y8rHqtFoRKFxzy8ZfYj/cNC+IDTxxXu08f1XoStunQ
VQAbMC0ycxQchZFC19GV20HlyxmIKX3Oq6AYUt3q1WMHiZ0yh6FEMTs5HXh2oZHU
UTWjAeK2txDkVhm+EJyrmjKYSHaPvIDME/nEVdSOBMUVtSoKB5xiEObsgGoCCdPw
UKnFafcsU65DtYvFQB7lvQ8uUtl8DGTDY8U451q4Z+BHErne9Iy6yCGv+Xb0+Ws6
JMrSlhfCyxnpSANDtvGUJOUOH+MUpKzScacl1M+M/0LBD8eXYfWVron9tVy57r4+
9sc3IDq2hr/DsuFD65MfTFzyP9wj56CxrF1HXIVahO5Vb9eTACNM06Vo3Jk38AOX
oA8z2PTdPytQMMmh/rQIoOv/lkQUOV+eYY0pi0Q86ui/gO+nyjJFUvTa5AfRqT3m
kObA5KBQF9yaBllmOU32zGadXyYSQaO3gTksr/ENk55wFUGNd7VNuQl/cJBz8GjW
wt3yFp4s
=UQBV
-----END PGP SIGNATURE-----

--=_MailMate_13390F71-957B-4974-917E-22BA13AE02CE_=--