Received-SPF: pass (google.com: domain of linux-kernel+bounces-64494-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 13 Feb 2024 17:51:38 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com,
 kernel-team@android.com
Subject: Re: [PATCH v17 2/6] ring-buffer: Introducing ring-buffer mapping
 functions
Message-ID: <20240213175138.1bc30513@gandalf.local.home>
In-Reply-To: <20240213155309.01c7c2b2@gandalf.local.home>
References: <20240213114945.3528801-1-vdonnefort@google.com>
	<20240213114945.3528801-3-vdonnefort@google.com>
	<20240213155309.01c7c2b2@gandalf.local.home>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 13 Feb 2024 15:53:09 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 13 Feb 2024 11:49:41 +0000
> Vincent Donnefort <vdonnefort@google.com> wrote:
>=20
> Did you test with lockdep?
>=20
> > +static int __rb_inc_dec_mapped(struct trace_buffer *buffer,
> > +			       struct ring_buffer_per_cpu *cpu_buffer,
> > +			       bool inc)
> > +{
> > +	unsigned long flags;
> > +
> > +	lockdep_assert_held(cpu_buffer->mapping_lock); =20
>=20
> /work/git/linux-trace.git/kernel/trace/ring_buffer.c: In function =E2=80=
=98__rb_inc_dec_mapped=E2=80=99:
> /work/git/linux-trace.git/include/linux/lockdep.h:234:61: error: invalid =
type argument of =E2=80=98->=E2=80=99 (have =E2=80=98struct mutex=E2=80=99)
>   234 | #define lockdep_is_held(lock)           lock_is_held(&(lock)->dep=
_map)
>       |                                                             ^~
> /work/git/linux-trace.git/include/asm-generic/bug.h:123:32: note: in defi=
nition of macro =E2=80=98WARN_ON=E2=80=99
>   123 |         int __ret_warn_on =3D !!(condition);                     =
         \
>       |                                ^~~~~~~~~
> /work/git/linux-trace.git/include/linux/lockdep.h:267:9: note: in expansi=
on of macro =E2=80=98lockdep_assert=E2=80=99
>   267 |         lockdep_assert(lockdep_is_held(l) !=3D LOCK_STATE_NOT_HEL=
D)
>       |         ^~~~~~~~~~~~~~
> /work/git/linux-trace.git/include/linux/lockdep.h:267:24: note: in expans=
ion of macro =E2=80=98lockdep_is_held=E2=80=99
>   267 |         lockdep_assert(lockdep_is_held(l) !=3D LOCK_STATE_NOT_HEL=
D)
>       |                        ^~~~~~~~~~~~~~~
> /work/git/linux-trace.git/kernel/trace/ring_buffer.c:6167:9: note: in exp=
ansion of macro =E2=80=98lockdep_assert_held=E2=80=99
>  6167 |         lockdep_assert_held(cpu_buffer->mapping_lock);
>       |         ^~~~~~~~~~~~~~~~~~~
>=20
> I believe that is supposed to be:
>=20
> 	lockdep_assert_held(&cpu_buffer->mapping_lock);

If this is the only issue with this series, I may just fix up the patch
myself.