Received-SPF: pass (google.com: domain of linux-kernel+bounces-64522-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d587fdcb-776a-4464-a5e0-dc9491504ae9@intel.com>
Date: Tue, 13 Feb 2024 15:14:40 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 02/24] x86/resctrl: kfree() rmid_ptrs from
 resctrl_exit()
Content-Language: en-US
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>
References: <20240213184438.16675-1-james.morse@arm.com>
 <20240213184438.16675-3-james.morse@arm.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240213184438.16675-3-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vm5WOWtQN3VOVWc4UVM3Z1R6MWhIK2g2M2w2SE5IeTJpOG1HY0MyTHRQMEtV?=
 =?utf-8?B?K3dqbzhxR0ZHOFhraFpmb2ZlcUpPK3RUaFpsaG01YVdNa1JVWnZscVBuRldr?=
 =?utf-8?B?aUtaek00bkdsQ0ZlNy9WcHR5MHp2TzcyYXNaNUpURk15K3hoVUE3NDlaMld4?=
 =?utf-8?B?K2lmd2VKM1RhMzRDYit6Nmt5QmRMY00weENLVkhqaVZyVExrdGxXNlFmb0NR?=
 =?utf-8?B?cTB5U3N1RFdjcnluQnF1dERiOEJXbnJXQXBITHBkQUtpc2hCNTVEWXczOC9x?=
 =?utf-8?B?ejFjb2h6YkQyNDF4elhjYVJEdS9hR0dOSnZjMzkrckVTb3Z5ZGJoTVJvK2Ni?=
 =?utf-8?B?QnBnZ2cwM3RFaEhjZ2ZSb0pQTEpWakxvOGduMVQzdFZBZGF5bThpd1BiRGtK?=
 =?utf-8?B?dkdsa1Z6V1NOeVBpcDNPL2U4Tjc4Q3Rnd2xEZGtZanM1MThOanZEcXJJR1VQ?=
 =?utf-8?B?ZzAzOFdQQmtTQVNMcnp3WVBsT3lGNmVyQ0F6ckl6N3kzMHJYMngrdG4zelJP?=
 =?utf-8?B?am1ndTlQMUs0MHl6MXd0VXF2cVNjOGI4dW5Qb0JkWE9BdW0vVkM1ZjRlc0Qw?=
 =?utf-8?B?UkJ2eEN3QlNpS1lhNk8wVHg5K2d0dXJvQUs2ajZOSnIwRXR5V25aaTFtdkVL?=
 =?utf-8?B?N0l6bk1saE0reDRmWEh1cFMvSG5zRjNhU1JMKzdIY1RKdmx3WnEzeHNKc0NU?=
 =?utf-8?B?MUVZcEtFMk1aV0lqbXNSVWFlWlhOWXZTUDMvSjk4SjczNEg2cGhaU3oyVGxn?=
 =?utf-8?B?QzN2bVl1cWNJUFMxNVoxYm5aaVc3Y0ErUC9JU1ptNjNrc3BlRDl2YlNNMTQr?=
 =?utf-8?B?UExmTWtCTUdZSnVJSFQ4cEdvRkJZR0xTS0c4UWhlZ3M2VDFrMnNuK3Z3NGl6?=
 =?utf-8?B?STdoOGlRRDBydWlGclUyaUpqNm94L2JhSnVjSk1TT09ScTN3U0cvWmw0QzBk?=
 =?utf-8?B?YUFwTENaVnRUTWdsek5YcWNHOGhJb045cW1wZVpoa3grd1RHZjhERzU5UWEx?=
 =?utf-8?B?cHFidVN6MzlxcE5sMEhYK1c4NG9JeDNNZ0krQWZsSm1VK0Vtby9sNU9Damlk?=
 =?utf-8?B?MzRkYjEvM2ZUSzR0U1g4SXdheTkvazFmaU10QWFqb2kraVA4WjREb2FYdWpV?=
 =?utf-8?B?R3lYZDBjeDJadXFxUThXR0Y3ZGpKbkh3bEpEbEFMUEh4OW1IRlVKNzI5dTZW?=
 =?utf-8?B?M3VuZndoTjE5SVo0N0dlbHdOcWh3TUZEOGFNOEpGNEVXUHM1MHN1ZkRJbTh2?=
 =?utf-8?B?TURzRnliZ2tkZUZicFJNZFM0UnR2eE0rd0dWNDZyaXlMVkdqMXVkay92Vmx4?=
 =?utf-8?B?WjNMQlJadVRpZEtld1BZSWVTNGo5VzJTSWk5OFJnZS9Da3FWUmhKYWhHVTIx?=
 =?utf-8?B?NkRIVkZXTlNSVVorYmhTdEdzWXJGc2tDRGdkMFhLNk9jdjVhK3BWRGJGS1RZ?=
 =?utf-8?B?b0x5MTQrdTZNOWVMcmM5OXJvY2w1Mkh1UUsrSlZqK2c3M1RHUGt6dHFJUGs0?=
 =?utf-8?B?RVdHbXByblZHR0wzcklQOW9PY2U4SXJiL1pIZEt3SW83M0ZDNG05N09EMTlz?=
 =?utf-8?B?RzFUeWM5M2VGbUlUQjl2VldMSHpOWTVlS3N1cTZJSVB4QWd2RmtrcU5PNk9N?=
 =?utf-8?B?OXFBV0o1anRxek54UlRWalk2RDJqTlU5RkE3TGpGTFFtaHNOVTZDZEtvMmQ0?=
 =?utf-8?B?dDVaem1Bd1hJZGVSZFBsUnhBaGhtbVo4b3dMaHJSY3JRZTJlVXhPRFdMT3ps?=
 =?utf-8?B?WU1GN2lYbWxNNVVkVWlGZGVZNFhDaXhVMStLd2RVRHc0b3pmN3dtSkpLUlZP?=
 =?utf-8?B?QU1QV2pMbWNvYTZmd0hTazVJbitWd3dWc3Vpek91dzBOSWhCRlh5RURyWlM3?=
 =?utf-8?B?dzZlN2IrMHErUFlyZnRoZnEyRW94cVF5OGRGVmhBamJKSm4yS0hSY01IOEFi?=
 =?utf-8?B?b0dWUnZNVjJBdzI3cXhwMzVqeVhFOWYrWm9VVlhJK0VONFFCZzRJMndUYU9x?=
 =?utf-8?B?KzVkbDQxQ0hVSlgvTTlmT0IvbmlzUjBmOVF6ZnFCdlpNdTFLbDdwM3dFSm4y?=
 =?utf-8?B?amFUZUJzcjN4MkZGNjkzNStWbzVPU1pTNlZLOXFpWWlOeHpNVlh1b0F0dVlV?=
 =?utf-8?B?WmU0OEtZWVc5MlFwQ0NWa1AvQjR1WHZaOXBuRkR2UGFQMUJheGhmd1ZjT2hT?=
 =?utf-8?B?UFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ef1fc4b-07e8-4127-9746-08dc2ce98fae
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 23:14:43.1050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +CZjIjP8ZPZW1fa/z+csrO63cML66HknSAQvRCFVIfz+/6z59jqUoEtAH8BzsXKcL0aZGeRPHwzDWpQea0UJ5Gy3BLIIXd4YvcgDltTlPIc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6253
X-OriginatorOrg: intel.com

Hi James,

On 2/13/2024 10:44 AM, James Morse wrote:
> rmid_ptrs[] is allocated from dom_data_init() but never free()d.
> 
> While the exit text ends up in the linker script's DISCARD section,
> the direction of travel is for resctrl to be/have loadable modules.
> 
> Add resctrl_put_mon_l3_config() to cleanup any memory allocated
> by rdt_get_mon_l3_config().
> 
> There is no reason to backport this to a stable kernel.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> Tested-by: Babu Moger <babu.moger@amd.com>
> Tested-by: Carl Worth <carl@os.amperecomputing.com> # arm64
> Reviewed-by: Babu Moger <babu.moger@amd.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette