Received-SPF: pass (google.com: domain of linux-kernel+bounces-64492-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <289ae266-c1a4-796a-1f87-387d8ec98646@quicinc.com>
Date: Tue, 13 Feb 2024 14:48:31 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v15 29/50] ALSA: usb-audio: qcom: Introduce QC USB SND
 offloading support
Content-Language: en-US
To: Takashi Iwai <tiwai@suse.de>
CC: <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
        <perex@perex.cz>, <conor+dt@kernel.org>, <corbet@lwn.net>,
        <lgirdwood@gmail.com>, <andersson@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>,
        <Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>,
        <bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>,
        <konrad.dybcio@linaro.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-sound@vger.kernel.org>,
        <linux-usb@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <alsa-devel@alsa-project.org>
References: <20240213005422.3121-1-quic_wcheng@quicinc.com>
 <20240213005422.3121-30-quic_wcheng@quicinc.com>
 <87wmr8y6hi.wl-tiwai@suse.de>
From: Wesley Cheng <quic_wcheng@quicinc.com>
In-Reply-To: <87wmr8y6hi.wl-tiwai@suse.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Takashi,

On 2/13/2024 2:59 AM, Takashi Iwai wrote:
> On Tue, 13 Feb 2024 01:54:01 +0100,
> Wesley Cheng wrote:
>> +static int __init qc_usb_audio_offload_init(void)
>> +{
>> +	struct uaudio_qmi_svc *svc;
>> +	int ret;
>> +
>> +	svc = kzalloc(sizeof(struct uaudio_qmi_svc), GFP_KERNEL);
>> +	if (!svc)
>> +		return -ENOMEM;
>> +
>> +	svc->uaudio_wq = create_singlethread_workqueue("uaudio_svc");
>> +	if (!svc->uaudio_wq) {
>> +		ret = -ENOMEM;
>> +		goto free_svc;
>> +	}
> 
> Do we need a dedicated workqueue?  I don't mind much, but an own
> workqueue isn't usually needed unless specifically required such as
> the request quantity control or isolation.
> 

I think we can remove this.  I checked the QMI interface implementation 
and looks like they are running all the notifications on its own WQ, so 
doing duplicate work with queuing to our own WQ here in qc_audio_offload.

Thanks
Wesley Cheng