Received-SPF: pass (google.com: domain of linux-kernel+bounces-64611-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <CAK7LNARaW1V5X79BFW5_YTKY+n+OSp+_ACpRxpiw+VOJ+2hf=g@mail.gmail.com>
 <20240213022552.754830-1-andrewjballance@gmail.com> <ZcvKQ3SpLNR9RfIe@bergen.fjasle.eu>
In-Reply-To: <ZcvKQ3SpLNR9RfIe@bergen.fjasle.eu>
From: Justin Stitt <justinstitt@google.com>
Date: Tue, 13 Feb 2024 16:31:42 -0800
Message-ID: <CAFhGd8pvhzehMGh1XEHBct7CGEQuF0CZeneMH3D6cKSRj5UdHQ@mail.gmail.com>
Subject: Re: [PATCH v2] gen_compile_commands: fix invalid escape sequence warning
To: Nicolas Schier <nicolas@fjasle.eu>
Cc: Andrew Ballance <andrewjballance@gmail.com>, masahiroy@kernel.org, 
	linux-kbuild@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, 
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev, morbo@google.com, 
	nathan@kernel.org, ndesaulniers@google.com, skhan@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 13, 2024 at 12:00=E2=80=AFPM Nicolas Schier <nicolas@fjasle.eu>=
 wrote:
>
> On Mon 12 Feb 2024 20:25:52 GMT, Andrew Ballance wrote:
> > with python 12.1 '\#' results in this warning
>
> funny typo: it's Python 3.12 :)

They probably meant Python 3.12.1 and forgot the "3." (or had a vim
moment resulting in its unfortunate removal)

>
> Kind regards,
> Nicolas
>
>
> >     SyntaxWarning: invalid escape sequence '\#'
> >
> > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com>
> > ---
> >  scripts/clang-tools/gen_compile_commands.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clan=
g-tools/gen_compile_commands.py
> > index 5dea4479240b..93f64095fda9 100755
> > --- a/scripts/clang-tools/gen_compile_commands.py
> > +++ b/scripts/clang-tools/gen_compile_commands.py
> > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, fi=
le_path):
> >      # escape the pound sign '#', either as '\#' or '$(pound)' (dependi=
ng on the
> >      # kernel version). The compile_commands.json file is not interepre=
ted
> >      # by Make, so this code replaces the escaped version with '#'.
> > -    prefix =3D command_prefix.replace('\#', '#').replace('$(pound)', '=
#')
> > +    prefix =3D command_prefix.replace('\\#', '#').replace('$(pound)', =
'#')
> >
> >      # Return the canonical path, eliminating any symbolic links encoun=
tered in the path.
> >      abs_path =3D os.path.realpath(os.path.join(root_directory, file_pa=
th))
> > --
> > 2.43.0
> >
>
> --
> Nicolas Schier
>
> epost|xmpp: nicolas@fjasle.eu          irc://oftc.net/nsc
> =E2=86=B3 gpg: 18ed 52db e34f 860e e9fb  c82b 7d97 0932 55a0 ce7f
>      -- frykten for herren er opphav til kunnskap --