Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp284632rdh; Tue, 13 Feb 2024 17:37:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWs80OjY/Pn+Oy4NuutwOdRZLxeD6wZYBtidfoH9J5ic0YSC90ymI/fKmcqc/hTc5j4Si/dp+fp0YApDi17g9X4IhbUtjGbUlLfSzcLMA== X-Google-Smtp-Source: AGHT+IFXz63CoK88EYCS88ctK1b6G5cehq+uku/3wUmMgNWDIu+9yVq5FKOIzDu0FeWtuJI3ialA X-Received: by 2002:a05:6358:7e94:b0:179:24b4:41fb with SMTP id o20-20020a0563587e9400b0017924b441fbmr1121496rwn.3.1707874645973; Tue, 13 Feb 2024 17:37:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707874645; cv=pass; d=google.com; s=arc-20160816; b=I7wXVkveSbacj2zS6glQbW8EaH8RJslOUHEn/O2n9DNiPBSBgklBCTy+BRsK/JrAjx TRJBPyQmzKl4CJtKO/bZ1FRo/DfSXgxDlwK5cPWo7BFLd8hwKXEAd6luloA3cPo+V7Yc tab32Qx9JFZDwNvzexauVeMvbh9KNY3+448SNB67jz7zc2/xT5FvqISlX6CcWzZcsgXN 71DQA3iVjmOGW1ljpBjQRL0D4b1JpG6PCAZEhhy6jcHVdvyntndzUuZF5NgM5DGbkXHt /ubwwA4dBYSs4Fw6bynq9qF64P/e+J+FDooy7SLNvOSvvYvs0AEZTifh6eZ5shP27cgR YhBw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Pz1kdXPSWmqm+D8P7t8vkpnyySpYkaJLd5kBqrENj6k=; fh=mtOIiep1EcbuHf3ibH5zmFtTbpdJ7qJ3kTs2AefesVo=; b=iZ24hzmHSVhdTIXWWJKhpi3C0NhjIN4Dns2+4Z+nEOXS3KbjcBFRUpQOxAowf0ZEDT 6pyb3cZBA2I/VVOBEDHN6h1c8bRrYafbJyGpEX2u6HSsznJN05nnC/8uKQFGoe5LiOB2 mKN5zZ5iEu6I9cnCJ2h2oK58ghXefkkPgw+UCnz0/D0Y/k4LWQ08Yrvg2SFfjNq3k/iQ qdriU3D7dQxxdvqssPA/AVQs2VnKnCrTrKJSbKo1UrSZUOFFFV35B4ZJ4tgtLI85fTm/ QJhcZ5zwsToZl92uUwEVWuOGo5AsbOndcQ4er5dUf1qB5wNcxqplh4SS4bwbY6Xo/xyD UkkA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h4S0KaLb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-64667-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64667-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXp+B3+keKrqhkk3B9Nf21GkbRZRjixBetcjQjgA89XvNqy1F9fLbN9HlXiaGPCThZ1zEPxTBTSH1f5GU2kTge9aXIeuXoyD4TaJcKTuw== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id m22-20020a637d56000000b005dc425a94d9si2765375pgn.369.2024.02.13.17.37.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 17:37:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64667-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h4S0KaLb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-64667-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64667-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 85180B283BE for ; Wed, 14 Feb 2024 01:28:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 802FF11CB6; Wed, 14 Feb 2024 01:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h4S0KaLb" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92B62125AD; Wed, 14 Feb 2024 01:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707873987; cv=none; b=eWJ5lSOusgc1OyXSIpxCSgM0bnmTaSZ4MbPLMUKRwGnbppjUIDqcJ4H+fsQ2CkkRtvbJscAICJjILbuTSwyzb4x6Bn4vDGkvksKTu+/hhefwfeRMxUWZPSeRR7hcigwnR8+hji5GpZcx9FS99wFEiq9YZrePZlGtg+5vWW6CWg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707873987; c=relaxed/simple; bh=QqVN4I8a66LbGVcZBXtseJS+ansGULIYrOKlUjQzjzg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QiBzkROmqitvtF9n8bz9T9MiY5Bm5zyztaDhtKTRfHNgN5fL8Fall+P3V/XcIG6ON/+dpvwIGDm3klIqCW3WGZXc1cvzC8QrmVPbXT3ywn7NBOEzmRNb6LZTk2NdMyuK8/Bis41+pyp3MaV/0C3Y6tqTcb9L76bCresOXsXWeeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h4S0KaLb; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94B06C433C7; Wed, 14 Feb 2024 01:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707873987; bh=QqVN4I8a66LbGVcZBXtseJS+ansGULIYrOKlUjQzjzg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h4S0KaLb1o+OMmx2bXq4SVkektMTrZqjoAhUzxkddpz41QC63VYJiBD/OGQAZ2uOy OcTVy1QAXwVJKls9pKD3jKt9TnIVULm2Jfz65gG2ozqLAzTfjQtg3nBMS58Smjffzd Kfghpib8IrOLEbRpm9NMsEL3i+NRwnh9CZUfuwu5LUcAttrp3YwAkY5aiVv0GtOZNU Y/ddXC2HHDWidMWL7wdR1GBaCWNbn4RkERLSXLu505irkfwZAYeg+3a9eL5OfItqPM HKPNm+WSH0dUf63IYvv9S7SZXYjp/1aaqKSQgJAcrFxHL47vJ1D5sJCKv/tWeS/FaO /ooCo4j6X2nug== Date: Tue, 13 Feb 2024 17:26:25 -0800 From: Jakub Kicinski To: Russell King , Andrew Lunn Cc: Paolo Abeni , Daniil Dulov , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] net: sfp: remove redundant NULL check Message-ID: <20240213172625.73643a36@kernel.org> In-Reply-To: References: <20240211150824.3947-1-d.dulov@aladdin.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 13 Feb 2024 13:43:57 +0100 Paolo Abeni wrote: > On Sun, 2024-02-11 at 07:08 -0800, Daniil Dulov wrote: > > bus->upstream_ops in sfp_register_bus() cannot be NULL. So remove > > redundant NULL check. > > I'm unsure about that?!? in theory drivers could call > sfp_bus_add_upstream()/phy_sfp_probe() with NULL ops, even it that very > likely doesn't make any sense. > > @Russel, @Andrew: WDYT? Since Russell is AFK let me discard this instead of queuing. We'll resurrect if any of the maintainers sends review tags or alike.