Received-SPF: pass (google.com: domain of linux-kernel+bounces-64677-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: =?utf-8?B?7J207Iq57Z2s?= <sh043.lee@samsung.com>
To: "'Christian Loehle'" <christian.loehle@arm.com>, "'Avri Altman'"
	<Avri.Altman@wdc.com>, <linux-mmc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <ulf.hansson@linaro.org>,
	<gregkh@linuxfoundation.org>
Cc: <grant.jung@samsung.com>, <jt77.jang@samsung.com>,
	<dh0421.hwang@samsung.com>, <junwoo80.lee@samsung.com>,
	<jangsub.yi@samsung.com>, <cw9316.lee@samsung.com>,
	<sh8267.baek@samsung.com>, <wkon.kim@samsung.com>
In-Reply-To: <94199ff4-1511-4f67-9794-b93195f8bac9@arm.com>
Subject: RE: [PATCH] mmc: sd: Add a variable to check a faulty device
Date: Wed, 14 Feb 2024 11:01:33 +0900
Message-ID: <000001da5ee9$bc1dee40$3459cac0$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQI2QrZr/hQwBfLmGOt++EZEApv72gJjevE2AlTbwFkCX8p+qAE5reIRsA6megA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20240213051332epcas1p1f45d02dc34d1b95ea5608ab779d6b6cc@epcas1p1.samsung.com>
	<20240213051716.6596-1-sh043.lee@samsung.com>
	<BL0PR04MB65642D0389544F022A1D2222FC4F2@BL0PR04MB6564.namprd04.prod.outlook.com>
	<000101da5e61$f97e8cf0$ec7ba6d0$@samsung.com>
	<94199ff4-1511-4f67-9794-b93195f8bac9@arm.com>

> -----Original Message-----
> From: Christian Loehle <christian.loehle=40arm.com>
> Sent: Tuesday, February 13, 2024 10:35 PM
> To: =EC=9D=B4=EC=8A=B9=ED=9D=AC=20<sh043.lee=40samsung.com>;=20'Avri=20Al=
tman'=20<Avri.Altman=40wdc.com>;=0D=0A>=20linux-mmc=40vger.kernel.org;=20li=
nux-kernel=40vger.kernel.org;=0D=0A>=20ulf.hansson=40linaro.org;=20gregkh=
=40linuxfoundation.org=0D=0A>=20Cc:=20grant.jung=40samsung.com;=20jt77.jang=
=40samsung.com;=0D=0A>=20dh0421.hwang=40samsung.com;=20junwoo80.lee=40samsu=
ng.com;=20jangsub.yi=40samsung.com;=0D=0A>=20cw9316.lee=40samsung.com;=20sh=
8267.baek=40samsung.com;=20wkon.kim=40samsung.com=0D=0A>=20Subject:=20Re:=
=20=5BPATCH=5D=20mmc:=20sd:=20Add=20a=20variable=20to=20check=20a=20faulty=
=20device=0D=0A>=20=0D=0A>=20On=2013/02/2024=2009:49,=20=EC=9D=B4=EC=8A=B9=
=ED=9D=AC=20wrote:=0D=0A>=20>=0D=0A>=20>=0D=0A>=20>>=20-----Original=20Mess=
age-----=0D=0A>=20>>=20From:=20Avri=20Altman=20<Avri.Altman=40wdc.com>=0D=
=0A>=20>>=20Sent:=20Tuesday,=20February=2013,=202024=205:42=20PM=0D=0A>=20>=
>=20To:=20Seunghui=20Lee=20<sh043.lee=40samsung.com>;=20linux-mmc=40vger.ke=
rnel.org;=0D=0A>=20>>=20linux-kernel=40vger.kernel.org;=20ulf.hansson=40lin=
aro.org;=0D=0A>=20>>=20gregkh=40linuxfoundation.org=0D=0A>=20>>=20Cc:=20gra=
nt.jung=40samsung.com;=20jt77.jang=40samsung.com;=0D=0A>=20>>=20dh0421.hwan=
g=40samsung.com;=20junwoo80.lee=40samsung.com;=0D=0A>=20>>=20jangsub.yi=40s=
amsung.com;=20cw9316.lee=40samsung.com;=0D=0A>=20>>=20sh8267.baek=40samsung=
com;=20wkon.kim=40samsung.com=0D=0A>=20>>=20Subject:=20RE:=20=5BPATCH=5D=
=20mmc:=20sd:=20Add=20a=20variable=20to=20check=20a=20faulty=20device=0D=0A=
>=20>>=0D=0A>=20>>>=20In=20mobile=20devices,=20suspend/resume=20situations=
=20are=20frequent.=0D=0A>=20>>>=20In=20the=20case=20of=20a=20defective=20SD=
=20card=20in=20which=20initialization=20fails,=0D=0A>=20>>>=20unnecessary=
=20initialization=20time=20is=20consumed=20for=20each=20resume.=0D=0A>=20>>=
>=20A=20field=20is=20needed=20to=20check=20that=20SD=20card=20initializatio=
n=20has=20failed=20on=0D=0A>=20>>>=20the=20host.=20It=20could=20be=20used=
=20to=20remove=20unnecessary=20initialization.=0D=0A>=20>>=20I=20don't=20se=
e=20where=20you=20are=20using=20this=20new=20init_failed=20field?=0D=0A>=20=
>>=20Maybe=20instead,=20elaborate=20the=20logic=20to=20free_card:=20to=20de=
tect=20a=20broken=20sd.=0D=0A>=20>>=20e.g.=20instead=20of=20just=20if=20(=
=21oldcard),=20if=20(=21oldcard=20=7C=7C=20=21=0D=0A>=20>>=20mmc_sd_alive(h=
ost))=20or=20something.=0D=0A>=20>>=0D=0A>=20>>=20Thanks,=0D=0A>=20>>=20Avr=
i=0D=0A>=20>>=0D=0A>=20>=20Thank=20you=20for=20your=20suggestion.=0D=0A>=20=
>=20I'm=20going=20to=20use=20it=20in=20mmc_rescan=20as=20below.=0D=0A>=20>=
=0D=0A>=20>=20e.g.=0D=0A>=20>=20diff=20--git=20a/drivers/mmc/core/core.c=20=
b/drivers/mmc/core/core.c=20index=0D=0A>=20>=20a8c17b4cd737..461cd75dc7ab=
=20100644=0D=0A>=20>=20---=20a/drivers/mmc/core/core.c=0D=0A>=20>=20+++=20b=
/drivers/mmc/core/core.c=0D=0A>=20>=20=40=40=20-2210,7=20+2210,7=20=40=40=
=20void=20mmc_rescan(struct=20work_struct=20*work)=0D=0A>=20>=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20container_of(work,=20struct=20mmc_ho=
st,=20detect.work);=0D=0A>=20>=20=20=20=20=20=20=20=20=20int=20i;=0D=0A>=20=
>=0D=0A>=20>=20-=20=20=20=20=20=20=20if=20(host->rescan_disable)=0D=0A>=20>=
=20+=20=20=20=20=20=20=20if=20(host->rescan_disable=20=7C=7C=20host->init_f=
ailed)=0D=0A>=20>=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20return;=
=0D=0A>=20=0D=0A>=20I've=20seen=20SD=20cards=20that=20fail=20the=20first=20=
initialization=20attempt=20for=20both=0D=0A>=20'valid'=20reasons=20(e.g.=20=
weird=20insertion=20timing)=20and=20things=20like=20out-of-spec=0D=0A>=20in=
itialization=20time=20from=20the=20card,=20outright=20disabling=20these=20o=
n=20the=20first=0D=0A>=20fail=20is=20a=20bit=20too=20much=20IMO.=0D=0A>=20=
=0D=0A>=20Kind=20Regards,=0D=0A>=20Christian=0D=0A=0D=0AI=20agree=20with=20=
you.=20It's=20a=20bit=20too=20much.=0D=0AIt's=20just=20simple=20example.=0D=
=0A=0D=0AAnyway,=20It's=20difficult=20to=20distinguish=20between=20NO=20car=
d=20and=20a=20faulty=20card.=0D=0AThat's=20why=20I'd=20like=20to=20merge=20=
this.=0D=0AIt=20helps=20that=20we=20check=20if=20it's=20a=20faulty=20card=
=20or=20not=20in=20a=20dump.=0D=0A=0D=0A=0D=0A