Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp311332rdh; Tue, 13 Feb 2024 18:55:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXd/VpY8r0iC7BM49rere55DR6ZTse5rKaf/9XRT1/AthQr0u68xJm/++ZtkRhMacDLoFcxBXkWNgfTiUjtCNpi3VlKZ8QgW74aNsSESw== X-Google-Smtp-Source: AGHT+IEf3wPqD9Q8XKy+eSbJmY/bXdhLL1KC4J/810SqVpkFlhONmZqLBoVJ/oRezAnbakyI8dT0 X-Received: by 2002:a05:6808:1311:b0:3bf:f1da:633 with SMTP id y17-20020a056808131100b003bff1da0633mr1402371oiv.54.1707879314337; Tue, 13 Feb 2024 18:55:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707879314; cv=pass; d=google.com; s=arc-20160816; b=Vc0sgmE9vFU3CdeWjBhLium/nGt4vtB0b9d4GCId7AT+dGWYYeNH4gM1nOy1HMh+4X nRXZsqgiSdKH5SyYxAZecTYpXxAfPvg4Fp0FayihUMNUWKIbNXCc1P0sDuxqSnCB4yhh WkTSG0s39099Oa/yQ7hY1+SgTXbr0t9zvTULUBKa0GbctywmipxhfQswsEP+6mOuzU/l iPlnyxFplD9HzybyMwdnhlnhMB5NWtRTg8eguxZ6Yzo/ucRfprTIywjKTnlIRjvUUJnr VHmxavQ41sVUhtlPR63ZA7ABHZkXzpP09hLNLhUXSPLifGt5t7UOLP4PA08hFq/SqVpR gU9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=18OLb3/aMb1HA0kOAUy49nxLA/y92MjDUGZVtgGrorQ=; fh=bZwCmLJvh5LCYfr8TUsl/kT0ysz4bV26QqN/eH8eJvo=; b=DQzjhnaJ1ri4Y6KdFgw/dTrpfQf1I6xCi1PKzLgKLIgf5rfb5fUrpVCnv1Ku6FwuDx jw665kHa7tWnMNBy8F1gD7SsUaB8XEZpzgwQj43ngA9cYHaDYe3FEKawJMbF29V/ULZl ZV6x8QzzR2OCrPTgl4eDtwQ4OYxtRDlfwV05WpOzK/r7oJIpUBYBqntJtzhQTyoC/deC NqPutvenoSUbV8QGvNUjOgvNJ6z3AZKFi1MuAjUYD8nfhVYnJFqQYA5zay6fS8sGjbmJ r44qgYlXiIniPkl90FeSMNJxMl0KkNxhrPnAcbCs/rrt62waHRuxEFnu1crPQrdpYbEi BUew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JixVEReS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-64695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64695-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWPuktatym5M7tV8Xw4WvSlmOHEN+1HNZQaLuVgMCc1fBXxphL5akstL9SsICsVin2Osjg8AD74FE1qcLdkrDKCg4iLw0RqgrEg6hHaKA== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id r24-20020aa78458000000b006dfee2d9399si7628531pfn.307.2024.02.13.18.55.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 18:55:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JixVEReS; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-64695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64695-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D1BC2B2854C for ; Wed, 14 Feb 2024 02:44:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 476C48F56; Wed, 14 Feb 2024 02:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JixVEReS" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AA6420EB; Wed, 14 Feb 2024 02:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707878669; cv=none; b=U5A4hwtgw++AbxaVIQ4WspX1kwmip/HDnNGDotoj+gi4zlgWYvD0zijyKWi+o9rVApOS/W1VDNiamU16vkr0JHmZFgBEfs+uPNL6c0I0wp2p3WH3R5JgoHXNA/RpIP4au3rFJKRD0pZGHEoCJtYT0Ce0e/sbmb96TTPvyD9GD3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707878669; c=relaxed/simple; bh=F9SLSrJ9tazlMoBwo9qdHzu3gmcgsg3epPk8XMRqOfk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jJy3P1IMXqetM9MNFumnGQQYRfSZZpR3JN3q2AQjQ3wKKR6pDw6v7vZ3viW4b36Ut1HuMlYQ6WxjDlRQJTs//4/amf7kc+x5+AC4RwCBF8u4Yb0R5bZPyTWH/prsBxE1oUEciOZmW+Ev/76NHjHscoC5U2Rh9KtE7z514siqypg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JixVEReS; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 724CEC433F1; Wed, 14 Feb 2024 02:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707878668; bh=F9SLSrJ9tazlMoBwo9qdHzu3gmcgsg3epPk8XMRqOfk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JixVEReSHI1W74Z4j/HBPFYhemampMieVUQhZMp+aFV5N2hbaL0bhkXMFxdmGNhEI 22uBV6A5N227sux9F8n5Qq5t9yLveOhM5M5HReKmnujOiUxRZOsz8jNnQL4VgTIbxZ 2d0qtfXfYvEBuKY3YreWySkIidJuUUqevCNAlAIJFWJqMNh2HQdWR1x2ypASVfnlMU EEyNwPJp2xhG/GDaPl9WBTigYV0AXeMPC/mKvW+DlJQdCQd5dcWzxcb+j4SU/ypcWF 4QY9If8DlOWvZHV3fn/YwXdqYu3Gx+cpTN/FseEg5Rr6thW+OSUWybmycX35N1hJEZ kltLXfp+wqzmA== Date: Tue, 13 Feb 2024 18:44:27 -0800 From: Jakub Kicinski To: John Ernberg Cc: Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , "David S. Miller" , Eric Dumazet , "Paolo Abeni" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next] net: fec: Always call fec_restart() in resume path Message-ID: <20240213184427.5af2d7eb@kernel.org> In-Reply-To: <20240212105010.2258421-1-john.ernberg@actia.se> References: <20240212105010.2258421-1-john.ernberg@actia.se> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 12 Feb 2024 10:50:30 +0000 John Ernberg wrote: > Tested on 6.1 kernel and forward ported. I discovered this when we > upgraded from 5.10 to 6.1, but the resume path in the FEC driver has had > this imbalance since at least 2009. > > This is also why I target the -next tree, I can't identify a proper commit > to blame with a Fixes. Let me know if this should be the net tree anyway. I thought you bisected it to one or two specific changes? I'd put those down as Fixes tags and target net.