Received-SPF: pass (google.com: domain of linux-kernel+bounces-64755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 13 Feb 2024 23:35:06 -0600
From: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Johan Hovold <johan+linaro@kernel.org>, Marijn Suijten <marijn.suijten@somainline.org>, 
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Konrad Dybcio <konrad.dybcio@somainline.org>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH RFT v2 0/3] Fix up SC8280XP idle states
Message-ID: <k7v2qov3m43q7vniqu3w6q64277ea5mf7gvt6fzgj4e3a5uagt@fcsmuu24cfqr>
References: <20230619-topic-sc8280xp-idle-v2-0-cde50bf02f3c@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230619-topic-sc8280xp-idle-v2-0-cde50bf02f3c@linaro.org>

On Wed, Dec 20, 2023 at 11:12:53PM +0100, Konrad Dybcio wrote:
> Comparing the data available in the downstream sources with what's there
> upstream, it was easy to spot some differences. This series aligns what
> we have upstream with what is there on the vendor kernel.
> 
> The big asterisk there is that the downstream sources for SC8280XP can't
> always be trusted. A simple test shows that the lower idle states that
> were previously missing are implemented in the firmware (Linux reports no
> errors and enters them).
> 
> HOWEVER
> 
> The only cluster idle state that's been present until now (the deepest
> one) is now barely used if at all, as the scheduler seems to deem it
> inefficient or so.
> 
> Hence, a request for testing and comments, especially from those who
> use the X13s daily or have reliable setup to measure the power usage.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

What did we conclude on this one? Does the extra state make sense?
The last patch looks useful...

Regards,
Bjorn

> ---
> Changes in v2:
> - Rename the idle states
> - Drop RFC, confirmed with Qualcomm
> - Rebase
> - Link to v1: https://lore.kernel.org/r/20230619-topic-sc8280xp-idle-v1-0-35a8b98451d0@linaro.org
> 
> ---
> Konrad Dybcio (3):
>       arm64: dts: qcom: sc8280xp: Add lower cluster idle states
>       arm64: dts: qcom: sc8280xp: Add missing CPU idle states
>       arm64: dts: qcom: sc8280xp: Fix up idle state periods
> 
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 72 +++++++++++++++++++++++++---------
>  1 file changed, 54 insertions(+), 18 deletions(-)
> ---
> base-commit: 20d857259d7d10cd0d5e8b60608455986167cfad
> change-id: 20230619-topic-sc8280xp-idle-00fc007234c8
> 
> Best regards,
> -- 
> Konrad Dybcio <konrad.dybcio@linaro.org>
>