Received-SPF: pass (google.com: domain of linux-kernel+bounces-64813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <93c77778-fbdc-4345-be8b-04959d1ce929@linux.intel.com>
Date: Wed, 14 Feb 2024 08:58:48 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] PCI / PM: Really allow runtime PM without callback
 functions
To: Bjorn Helgaas <helgaas@kernel.org>, Raag Jadav <raag.jadav@intel.com>
Cc: bhelgaas@google.com, mika.westerberg@linux.intel.com,
 andriy.shevchenko@linux.intel.com, stanislaw.gruszka@linux.intel.com,
 lukas@wunner.de, rafael@kernel.org, ilpo.jarvinen@linux.intel.com,
 linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, sashal@kernel.org
References: <20240213200648.GA1219964@bhelgaas>
Content-Language: en-US
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <20240213200648.GA1219964@bhelgaas>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi

On 2/13/24 22:06, Bjorn Helgaas wrote:
>> Debugged-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Sounds like this resolves a problem report?  Is there a URL we can
> cite?  If not, at least a mention of what the user-visible problem is?
> 
>  From the c5eb1190074c commit log, it sounds like maybe this allows
> devices to be autosuspended when they previously could not be?
> 
> Possibly this should have "Fixes: c5eb1190074c ("PCI / PM: Allow
> runtime PM without callback functions")" since it sounds like it goes
> with it?
> 
I don't think there's known regression but my above commit wasn't 
complete. Autosuspending works without runtime PM callback as long as 
the driver has the PM callbacks structure set.

For example the drivers/i2c/busses/i2c-i801.c has system suspend/resume 
callbacks. I tested this patch by hack-removing them and yes, 
autosuspend doesn't work without this patch.

Raag and Mika noticed the issue when cleaning up empty runtime PM 
callbacks from an another driver which doesn't have any other PM callbacks.