Received-SPF: pass (google.com: domain of linux-kernel+bounces-64972-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <75f08d51-e4e0-4899-8258-81470c044134@oracle.com>
Date: Wed, 14 Feb 2024 09:24:42 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 07/15] block: Limit atomic write IO size according to
 atomic_write_max_sectors
Content-Language: en-US
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-xfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        linux-scsi@vger.kernel.org, ming.lei@redhat.com, ojaswin@linux.ibm.com,
        bvanassche@acm.org
References: <20240124113841.31824-1-john.g.garry@oracle.com>
 <20240124113841.31824-8-john.g.garry@oracle.com>
 <20240213062620.GD23128@lst.de>
 <749e8de5-8bbb-4fb5-a0c0-82937a9dfa38@oracle.com>
 <20240214072610.GA9881@lst.de>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240214072610.GA9881@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?eFUzNmhOc050dGVhRUpCZ3YwNkdKRGJXQmp2dkN2SmJmcVVHd1dYV0YvbG9O?=
 =?utf-8?B?K2VBdklUbzA5S3ppT2NkdFNVdGk0bmY4T3h3NThIbzJnM2JxZ2twVUlZaVhF?=
 =?utf-8?B?MEUzYWdab0xTZDU3UUtqQkx5SEZCN1B6eXNXam5pT09QbmQrWm1mMWNySGpm?=
 =?utf-8?B?emhJSko3LzdzV0U5YnhZNXhQekhrb1AvV0o5WEFFMGRGVit4MXh3djBWM2pl?=
 =?utf-8?B?OXU5aEtnMDN5YzBzcTl2TU5ianFobjRodkxoRTVlWHBiS2VjMHJGeUYrS00y?=
 =?utf-8?B?c1FDYTVkVnBPclgxWTNodXBYUncycUZIME5Xem5wYlBEbUpLeUptWmtKNjJU?=
 =?utf-8?B?Uk9IOFhndHFjYVNDVmpGcVEvdGQ2RlUxcnFVelJKdFpZSWJKMDBKNmxQR052?=
 =?utf-8?B?eTM0OE53UTJRT0pmTW8wVjloV3lLYlFLQVdaMzg5NXcrSFNIdUFycUlZbXJD?=
 =?utf-8?B?UU1QWjBRMkdkR2tNdGZMaEpmUzB5VUxpNTJiZ3RtS3YrZWN4d3IwejJYNVM1?=
 =?utf-8?B?L3ZiWURNVmwwdUdlYjdIY2I2SkZLR3hQb3ZWZ2h5VWQ2Z3lsakkxT2MvRWo4?=
 =?utf-8?B?czBVbkpOc1krRWNPSE0vN29nZ2R5TzBsR1NJUWZGajc2K3Bwai9sZUh6eHBU?=
 =?utf-8?B?SGU0RnRMN2d2WEI5T3ViY1gzRXZ6YkNzcTNNdmV5ZktEWE1PREhwMkgxeEdv?=
 =?utf-8?B?K1R5S1I5K1RRb3cwNFJLVDFVVVBkRXV5ZnptTGNHSkkzcFJPT3pSTTNXNlFk?=
 =?utf-8?B?RXo2UWJMRFJDMEhmWERLZkxDSlNPK3VqTWRZSVdUcm5sSmFqREsvRWZYT1ho?=
 =?utf-8?B?dFZqeG9qaXhjWEx6Ung2dW5IbFhudUdvWUZTRXlZazQrR1lJM1BYRXZUR0hj?=
 =?utf-8?B?a2RGdWYxYWNRNVd4bkdGOGRxLzJEWlZZNkV3NDJmTFpXU1RzaVpGa25ObWVm?=
 =?utf-8?B?T2cvZDBUSHlGZThhay80OUpSVVdidGVOOEZud0NRVmJObVZKUGk3Wno5VFhl?=
 =?utf-8?B?N0RzUTVzaVhGNXV6UXRtTFMxdWQvaEtoWm5kV1UzSVNpaXF4TFhoN2xNQWFT?=
 =?utf-8?B?V3FsU21YcEF5dTFQZGxvbldtZHFHNWIwcmZNeHN4K0V4eFEwREl2VzdyYzZz?=
 =?utf-8?B?d1laZW5VbXJQQzFyYmpaWE1UVHF6RFNCaUVsMjZaRXJXZXdIY2MzOCt1WXdG?=
 =?utf-8?B?cExlaVZsUm9uQlhNZFFNd0czdGhqTHpicXJXN1ZVcXN3QWxLbzZJdCtsMW1u?=
 =?utf-8?B?Qzk1NytGS0ovbFRMdDdTWmZndTdMck5WUlR1ZWdSdllBelg3YWtva3FueU4r?=
 =?utf-8?B?cDVUeGNUS1MwUldOVDM5TlRDNE5pTkxGU0JMZEp2S3hORUVYY3RDSXpTdlhv?=
 =?utf-8?B?UmhGalJ4M2NsMWZ2aG1OZnZkY1lOQVY1d0lPZFZ0eEhzMEJjRlVPUmV0SXA4?=
 =?utf-8?B?REZ3VExZV2Z2amhaSDVtSHhabDVVaVdTWmVaWGE3dExvSlovSXE3MHpoVitJ?=
 =?utf-8?B?R3FUY09wc1lLL3pkL05RQ0dpUUdRLzFlZjNUb3RwR3M3YlJZSkl4VTgyblQz?=
 =?utf-8?B?dng0Si96QXh0bmhjK1Fjem5scFExS2k2d21xYTR2KzNVbVRLZVR0Tkl1Q0lh?=
 =?utf-8?B?UUJqWTdOM2FWT1ZLcWZFc28yK0hzQzVwMjc1ME1OV3JVZk9KdFV4VjB3YmJ1?=
 =?utf-8?B?NFRvdVZ2UmVjVEFocHZpM2xaRlN6VDVTTVdZaVZ0WmVWclNVbUxqUktFUmhW?=
 =?utf-8?B?WVNaRU5sYVA2RmlYUTBjaTRDd3NoMUhVVGtMT29MMk4vVG81bjJGTVp4UWY4?=
 =?utf-8?B?elltUENLZGw2aEhQVDd2VkgvVXlMU1k4WlJ5ZHFTTFhKWWtOWVRTTGRFVVpn?=
 =?utf-8?B?by9vMDhjd3VFM29hYTkxcUpKSFNTc0ZXTjhjdnU5V2F5OUlKY2ZLbHhsNXh1?=
 =?utf-8?B?bm5KUVVWVWQ1ejlWTHR0TGZUYUZsNGRVMmR1YlJvTXMzOVE3SnV5Wm9WdWo2?=
 =?utf-8?B?bjErWWQvQVkwdy9ONVhPQkZvSXR6NjJ2RlJkNXFKQldMV1JXZmFUUnM4Qi9m?=
 =?utf-8?B?M0hhSnV5SXJQeDNTOHY1L1dQb0VpSjVERTFyek9GOHV0Sm1UY3VIN3dFS3dR?=
 =?utf-8?B?QzNWRklCaHlzKzE2cHBzQ0RhQWFzdkk1OXNZVFROT1lTSFNwaTFkeDhuSEIr?=
 =?utf-8?B?bnc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	/UL6dwi+YF/+2iOUEhaXVcEfGo7k5XsiI6qxmLhchxacBY2FVj7rvyx0o+QTmklEN8MMvRf/EHlj/McT7fKwS4Y+TxjvT2fVjX8oPQKjxs5QB8u8wewGs+QzVaRLCxszgQU6vH5Evra09ydxbDs2AB7xTaXJRGgyvqrArInjfNjCE7xzOU5qA+DAERtpSU/WoQS7208WmJlXTG2+Pe8zGvuB+ZKI0WR77jNCx2MkIOdS6+K7gSqliaSeVYGy5XXPw5gOwJ4z8CmvY45pW0NeLn11sh9ED1E/19Rf11K4dK4AeBvyCGAcPL2a3rlKXs54Y/D33zjQM5sAjIDLWCi2bPSmqS4mu8TZXYCPxwxw8STrsW/7vMkWAiEehjwuzroW95lvOoSwnzyZ6/BnuqocMMKJ7A6iiH5VBV6324wo3bPx+pUXV1OHAXhuwGhWD05GCeoCiyFU1lSq6WNwaQ7tp7JeRbZFHQWcQ+amMl6/FvTEm3wvDkcjYjPuO6EB3job9pfW8UPTM80sWdU5nA+fJscUh8md0e5Xxxq5nUIvwnea/ACFTABmjYNfSZqYED/FLvvYoqo9nVZZX7ysRmDHBvcVdl1MQ/6DyGUcH42Jd/Y=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 369c02a7-255c-4db2-8ad1-08dc2d3eca05
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 09:24:48.2161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Y4cX34tRMKi+qbdSXPKqq1kwn4cyN7Sc1VOcpBHOy51/e4U/BqKJe1h7mgesl6vdqj8jGn3IhBhL5wyp2992w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6871
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-14_02,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=990 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402140073
X-Proofpoint-ORIG-GUID: s0awLkMpll6b157E0moajxiMgvQsEPr_
X-Proofpoint-GUID: s0awLkMpll6b157E0moajxiMgvQsEPr_

On 14/02/2024 07:26, Christoph Hellwig wrote:
> On Tue, Feb 13, 2024 at 08:15:08AM +0000, John Garry wrote:
>> I'm note sure if that would be better in the fops.c patch (or not added)
> 
> We'll need the partition check.  If you want to get fancy you could
> also add the atomic boundary offset thing there as a partitions would
> make devices with that "feature" useful again, although I'd prefer to
> only deal with that if the need actually arises.

Yeah, that is my general philosophy about possible weird HW.

> 
> The right place is in the core infrastructure, the bdev patch is just
> a user of the block infrastructure.  bdev really are just another
> file system and a consumer of the block layer APIs.

ok, I'll try to find a good place for it.

Thanks,
John