Received-SPF: pass (google.com: domain of linux-kernel+bounces-65009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b27e4519-a9fc-43bb-be6b-35d69d65755d@toradex.com>
Date: Wed, 14 Feb 2024 10:46:01 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62-main: disable usb lpm
To: Roger Quadros <rogerq@kernel.org>,
 Andrejs Cainikovs <andrejs.cainikovs@gmail.com>, Nishanth Menon <nm@ti.com>,
 Vignesh Raghavendra <vigneshr@ti.com>, Tero Kristo <kristo@kernel.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Aswath Govindraju <a-govindraju@ti.com>,
 Sjoerd Simons <sjoerd@collabora.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, "Bin Liu [EP]" <b-liu@ti.com>,
 "Gunasekaran, Ravi" <r-gunasekaran@ti.com>
References: <20240209130213.38908-1-andrejs.cainikovs@gmail.com>
 <2629cd30-23aa-4f03-8452-ae13297fd6b6@kernel.org>
From: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
In-Reply-To: <2629cd30-23aa-4f03-8452-ae13297fd6b6@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXZQeCtZNkVrUTduS3BSWmxxVnRuWnFqRVF5R3d1QW9GQTh4bXJ5T1l6c0JN?=
 =?utf-8?B?MVZBUE01alFWenFqUFppY3o0YWZQaG8wR3RJWUd4U3UwL3FpTFhDYk04V0Q4?=
 =?utf-8?B?WHZzOU0yZEZiaStPbjFsTmpjRFVaMjdnNms2ZFBidG4yYXFJbnlKUGYwaE5L?=
 =?utf-8?B?clRDbWljNngwMmg1Nk1TUWVSK29IdWlDV3BkNnNSL2NhdnRGUkd2SWFQeDRi?=
 =?utf-8?B?T1BObnhBdEppR01hUCtOL05JTFAzU0s1a3lubVhPR29sUlpwOXZIYzJGY2d4?=
 =?utf-8?B?NEI5MnRBTWdFRVU4Ym5CaWlqQThaWENTZE43QVlzRmxLNGtrRlAvQ3pzZVlM?=
 =?utf-8?B?VWE2Qk5yd3VXMlN0ZHUzM1NoSlFraS9TMythb0h0YkQrTEtWQWJ5UEtITTFU?=
 =?utf-8?B?Z2s4V3pYZEEwUDlLeUcvZVhqV2F6R2hXR1dObnAva0wydjYxaWRmWms0Nzlv?=
 =?utf-8?B?TEFQVytTQmFtTUNENGpvcXMyeit3QnNHeEpod0g3Y2NPTVRnZk9IRmt5Slhs?=
 =?utf-8?B?ZWVJY0FRSEFZS0x5dHlhTUlLNXNwOGFmMEplMEpxT1lxSnhZUldvN0QySGc1?=
 =?utf-8?B?OHRPK0JiQndzN0sxMnhFblVCN0ZpOUY0bExVL1UvcVNWZ2JaNlpXVHpZUjVi?=
 =?utf-8?B?WXM2UjBkZDBHK1JDcTRLelAxcjAvRHpzN09jTmZPOE41NUN1eW5XWnprdms4?=
 =?utf-8?B?L245SjdiYUxkVWs5WHlSTzVUdDFtV3lrR0cwQWhNYW9XRHlwRUxmeTNqeUYz?=
 =?utf-8?B?dFgvMVJOZEJEL1NHbzhzUUg5cElPMUVnNzVCVHZ5TU50YlRmalN6Y0gzbjdp?=
 =?utf-8?B?THZ1SGlpR2VwSngyUTdVZ2c5TGdvU3RDbXUybW93VWNXZUhjdVROVERLMmJj?=
 =?utf-8?B?cERHdlJKYmZ3UjcyeGszWlZEdGtuTndRaFNnYXBVdTF4UnA2dGtTc0dFcnFF?=
 =?utf-8?B?aWdwejArSHU5WE9CY1pQQWJHVW5ycUl5aWFYVGlkV0h2V3JzU3lRZGZmcEVQ?=
 =?utf-8?B?dFliZWlhZlZyZmhvUUc3YXZUNm5jZ1FYclU2TDlYd1pVeHB1VnhMN0FPMDFi?=
 =?utf-8?B?NzBZL3NHTUtsTmN5OTE0azZtZjVHaFdKcXl4bDI5OUNFcjFweWpidXdDZEQ5?=
 =?utf-8?B?c2NGc1Y1SENrR09pKzdhQngyYmkrS0plSzUrREQ4NHdzbEw2WGlnN1MwbXE1?=
 =?utf-8?B?ZVdQSTNjVnhiMEpyU2YwZ1dickhacjNpMkhsajVxdGNnNnJoNEtEQnJBbUhj?=
 =?utf-8?B?bnZSeE9rTHNudzJUWi9MNUV2T21XYzMwNW9wK0NjOVJCMk4zR2luV0U3TzVG?=
 =?utf-8?B?d3ZBaEx2L3l4ZHU1cmtRbVJWdk5WRE1oYytuZlAxS0RlaHRsR0lteGRPRzZu?=
 =?utf-8?B?bzA3bjNNaVFMT1Z3NGQrWlcyNGR4MkpLLzM1aDZueVFlWVJ6NDVycFBGZjNr?=
 =?utf-8?B?czN3d3FZUTNvNC9LMXR2UVBmU3hTWkxIdDB3MGR4ckhUb2V3djdxTnFzZ0VV?=
 =?utf-8?B?MFhlSGttL1EzSG94anRYVVJReHRJNktRNmpYbUVlVkx1TlUydXZSck9paGpi?=
 =?utf-8?B?SUFKdDFldG1VY0xGSWllVGhoN1ZiRzJXT3h6blVwcDlsVTlvYjJGcHZWTmw2?=
 =?utf-8?B?eHZQQjZPUTdZbXZmQ2tRNHcwWnFYblh4NVFPTTljNUI2aUw5cHN2Ym03UkpL?=
 =?utf-8?B?SHNRVmJXV094LzdzbmZUWi9wcUNieDhFQWUzek5Ub09aM3V6V1U1ay9sRFFj?=
 =?utf-8?B?TjhXM1hPaUlvSDVsaGxjeENoaGZqa2lEdGNqUGJwTThDZlI3Mi81L0JHcnRG?=
 =?utf-8?B?ZThLTUt4bE5uODIvckIxNWZmZ3N3cm5tY3paVENGeWxjTlNnSFE1UFNpOXlB?=
 =?utf-8?B?cnpoWHBDNFBaSHQybzFyMVJVOVVqbkF0cWFBMGpneVZVenJrMUNhMklOZHNP?=
 =?utf-8?B?ZVlyYXFRc2hQZDFhbE1SWVNyN1R5VWVTMmRxZmhTckN6S3hJWVRld0JkVkcv?=
 =?utf-8?B?V1JLeXZLeGRBSXJJS2hjRjRNRUFpeU5IMzBYWTU4NzBRMHJ0V0dsZ1ZDUVZF?=
 =?utf-8?B?R0VCYldnTG9pTUhFZklMVDNiblhZSlJIYlhUTGNWaXZnQlFxZ29pM1dUa093?=
 =?utf-8?B?M0tEMnpzYXpRMDllZjZXOWMwdUtvdmVHaGJFK0J3SHhOMTEva3d1RG9uS25H?=
 =?utf-8?B?dGc9PQ==?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7256265b-02ae-4925-acf8-08dc2d41c1f4
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0254.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 09:46:03.1098
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tkJIlU/+K9cbal1zn7Wb9sh6oOmwWeJkDJhe5haNFxuwuJodQupxumwzB6vfv8mFUj5WYow2+oCweBSZuY4NwI06jp7FqzTqHkIxTES41xo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB1123
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: toradex.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 12/02/2024 13:13, Roger Quadros wrote:
> Hi Andrejs,
>=20
> On 09/02/2024 15:02, Andrejs Cainikovs wrote:
>> From: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
>>
>> AM62 USB works with some devices, while failing to operate with others.
>=20
> Could you please share which devices failed to work for you?

Hi Roger,

This USB memory stick is the one that is failing most of the time:
ID 058f:6387 Alcor Micro Corp. Flash Drive (DigiKey 1GB)

I used following test to reproduce the issue: boot without any devices
connected, once booted - connect to PC for gadget mode (RNDIS), and then
unplug cable and connect USB drive.

I did not had any failures with this USB memory stick, btw:
ID 0951:1643 Kingston Technology DataTraveler G3

/Andrejs
>>
>> [  560.189822] xhci-hcd xhci-hcd.4.auto: xHCI Host Controller
>> [  560.195631] xhci-hcd xhci-hcd.4.auto: new USB bus registered, assigne=
d bus number 2
>> [  574.388509] xhci-hcd xhci-hcd.4.auto: can't setup: -110
>> [  574.393814] xhci-hcd xhci-hcd.4.auto: USB bus 2 deregistered
>> [  574.399544] xhci-hcd: probe of xhci-hcd.4.auto failed with error -110
>>
>> This seems to be related to LPM (Link Power Management), and disabling i=
t
>> turns USB into reliable working state.
>>
>> As per AM62 reference manual:
>>
>>> 4.8.2.1 USB2SS Unsupported Features
>>>
>>> The following features are not supported on this family of devices:
>>> ...
>>> - USB 2.0 ECN: Link Power Management (LPM)
>>> ...
>>
>> Fixes: 2240f96cf3cd ("arm64: dts: ti: k3-am62-main: Add support for USB"=
)
>> Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@toradex.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/=
dts/ti/k3-am62-main.dtsi
>> index 464b7565d085..c49fbce5cb70 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> @@ -640,6 +640,8 @@ usb0: usb@31000000 {
>>  =09=09=09interrupt-names =3D "host", "peripheral";
>>  =09=09=09maximum-speed =3D "high-speed";
>>  =09=09=09dr_mode =3D "otg";
>> +=09=09=09snps,usb2-gadget-lpm-disable;
>> +=09=09=09snps,usb2-lpm-disable;
>>  =09=09};
>>  =09};
>> =20
>> @@ -663,6 +665,8 @@ usb1: usb@31100000 {
>>  =09=09=09interrupt-names =3D "host", "peripheral";
>>  =09=09=09maximum-speed =3D "high-speed";
>>  =09=09=09dr_mode =3D "otg";
>> +=09=09=09snps,usb2-gadget-lpm-disable;
>> +=09=09=09snps,usb2-lpm-disable;
>>  =09=09};
>>  =09};
>> =20
>=20
> Instead of this could you please check if this series fixes the issue for=
 you?
> https://lore.kernel.org/all/20240205141221.56076-1-rogerq@kernel.org/
>