Received-SPF: pass (google.com: domain of linux-kernel+bounces-65024-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f7d8dd6d-3c7a-404c-9ccc-1f9904447667@oracle.com>
Date: Wed, 14 Feb 2024 10:10:16 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/6] block atomic writes for XFS
To: Dave Chinner <david@fromorbit.com>
Cc: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>, hch@lst.de,
        djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com
References: <87cyt0vmcm.fsf@doe.com>
 <875feb7e-7e2e-4f91-9b9b-ce4f74854648@oracle.com>
 <ZcvyDnUoC3PvV+p8@dread.disaster.area>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <ZcvyDnUoC3PvV+p8@dread.disaster.area>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?aFFsdkN1NnpEbW9XMXlhdmZ0ZmZyT1RQZ2FJc1BFQWRlWW80QldIN2d3MVh3?=
 =?utf-8?B?dTZuYnhBOGx6YUFSa2xoOEJLVFkwU3pCREpnUzMwWXlNNVNBS3VuSFVzbzlC?=
 =?utf-8?B?NDN0WmJVdE9ta3Bzekp6SWZoQTZ4NkJBRDJpbHB2azBsRHpPNUU1YmZJTGtB?=
 =?utf-8?B?OFhqZC9venBlQ3EzQWp1dlRGTUlLMkxqVWNYWnR2UiszVkN1WnZ0aEt5enc0?=
 =?utf-8?B?TFgvd1MyODBrS2xQOWJBbStUYXR3Yk05eWlrZ1NpMThaYlVxaUlFdTJwcXF6?=
 =?utf-8?B?VXYzZjNCbXRuQVZ5WEFOb2g2Ynk2QVBVUmFRdS8rL3c2UzkxY1M5OFBZbU5j?=
 =?utf-8?B?SmZodXZtTlZtKzhFZUdWVnduWkZqQ3lkb2lYR1dMUTQvYVdOcC9yTnQzOXRJ?=
 =?utf-8?B?ZkQrSGFkazhTb0JTRXpka2FDSTNYZjZYNUpaRGxXVW9uVkkwb3h2Y25qelJo?=
 =?utf-8?B?MDd4MTd2UVpybzgyTEpQc0swV1VINnBsWDlXYkpDSS8rZEo2SUZDZHBsV0dQ?=
 =?utf-8?B?a2pkUFBtNHhXYkVrQTNhNVpETGh0MzZMU2ZZYVRQL3JSWVMwWGhtbnpvQ2c0?=
 =?utf-8?B?ZnpxaHBPUDQ1ZVdkN2VucjgxaHlmazZzSHhYc1Zna3Mra09XbUJzY3ltVGJi?=
 =?utf-8?B?dlczKy9TZUpwRlZLMGRpN3RZemw2QUh1WHlZbDVYVGREOXRLR28zL1hzRjdE?=
 =?utf-8?B?YnhSVC9iWGhCb25CTy9BdDByWm1waGh4Z0pmdXdYVFNJdFg3ZjA4ZnBjbnFE?=
 =?utf-8?B?WGg3QVBJVzVHTWc5aVVVaFJSdkh3aXZ6cGtkY3dLVG9DZXV5S0VOcHU1cG5z?=
 =?utf-8?B?eitlRmtHSys0RURNSGhVODZBbjVpYnBDcUZmR01ibDdGTlR1T2NQYTVUTE1i?=
 =?utf-8?B?MjhwTExrTlVEd3J2NDNYREplc2RqblNQcWZZWWZlTHZLNTlLemRES1FaVDNO?=
 =?utf-8?B?TDFQMnpoVndVaWRZUFJneGpDSWpYM3FUZzhaNDJEQzB4MDduTUlMRWhzcm1z?=
 =?utf-8?B?OUV1UUVuTWhhZ1VISk1xSldyNmFSOVB1UzBPWFZiUVpmRjJGeEVwVVp0cnZi?=
 =?utf-8?B?ZjB2UUJpNTlzOGx4RTVIOEJ5UzlTbnN4UFhFUzVndS9qckpweU5TbXJrUmxM?=
 =?utf-8?B?WmtIcXlDMnpXZG1lM2xWSjNKOExzbDZHdHZLU21JWmxNLy9aMXE5VWhBZmRE?=
 =?utf-8?B?TUJMRXA2N0owc1J4OWZRbU0zalBDdk0vNVoxN1pDV1E0OEJHakp5TlFYOU12?=
 =?utf-8?B?OFdiZWQyYU51a0RtRHNlUkxOejFNYi9sV3Q1WTAwZXU1Z0R4SG8xYldsYlA1?=
 =?utf-8?B?WC9CWEV6ZHYrZHAxcFJSZG1rUmh2WTQvclF4dTU1UTQ2U011MHlITzU0aXpC?=
 =?utf-8?B?OG9IcVpvSG5rNW5OZjlXWFZQQWFqbGg5bmJURHVFR2dRWmlWQ3JobWtmajZh?=
 =?utf-8?B?Vll3TWtnenNaazgwZDhOb2Q5a2FtZ0N0T3REYzhERjlkNHc4RTIxbnlucXdp?=
 =?utf-8?B?d2MxZjJjL3hPb3doOFkrKzFITUtzUzJlb0ZoTHhicTdTRWlPT3JWd0N3eUdt?=
 =?utf-8?B?K2krTlBWUEJFVWZuVU1NUkVrUzBSZVJlSUtTUG1MQXdlbVZnNTJWaUVXd2tJ?=
 =?utf-8?B?eUFkTTlUNkhHYWtlZXlOSU40YjEyTHZYeXU1M1RQemdFNW9nSnFCUWN1QmlD?=
 =?utf-8?B?OGM5VzI3aTc5ZjhKQjlGR0xaTDh4eGMvVlBBQklzUGxHdkViTE1Zbnpjclhy?=
 =?utf-8?B?M3JwNkZITUVWdiswZHY0MVJzbFhBa0hjaGNyTEJSZTNVZkZrSE5mR2tBbGZJ?=
 =?utf-8?B?Mms1RmFQYzhCa2svcEdVdkMweFhFMHY1dFFzUGJlVkxvU0xVWmFUT1VHUCtT?=
 =?utf-8?B?SXYrQTBJRkNaMHVkU1JuU3RISEJKUmNQWGIwTVYyMWxWN3JMQVM1cmZ6eVVI?=
 =?utf-8?B?RE51VlJreW94OGNBdEdpQ1ZOZWRvdzNVSnphVUgzcVJHVldMV091LytVVWFC?=
 =?utf-8?B?Q0FIMnJJdkNkVlk5MmtiUjE3V3pVTGxJZlFiQzRkcEZkZmRkdVgvdERQUG0v?=
 =?utf-8?B?VEtrcDlsT1pMbThGZkQwQ2wyZTcrRUZjdmJNTnM3bzZ2L0JjVTVnU2wwMlNO?=
 =?utf-8?Q?ZutUINlNQ29INv0s1GElmx64g?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	+FzL8Ci/7vUCgSidhFHdeP4K0x848Zv7KcjxyAwwleYaiy5EbcTY2mUk+uPHM78By3EoJZTRMh5LMqY9YZc/ufs/KeeVvDd5CHHsDKJEbGVvCW9GmuXmsbi6oD6dDYnkWPEm+JlzSnkBNWt7lyeASwzXvsCInkJwu8su7OEg/Pr33j5QNAvdRRYN2gpcQ8x8f443fXCyUL2OcPy5Gh8szboDVL02MA7B82jktetOA4R2P8/xnw2JirLTQLtL5bNrHw4Jj/L66j2P0XUCggzaGOTUzqjAFEyIYA8gaU2mDFI7b0ZYjRi3rOBKvN9QFUISz8A7FNdK5+a1cTwmuKjV/0BU9/hcM+Zk0EceHo9NkK7wP955NMn2maUMqmOrwZ+lGNstU4qKjhD/owkNwBcfjP4XxVU8EN1YdwwIdU8yLsEXadqXXy45zW0fKpQeFDrWqGP6V9uBaA1WL+mUBWYItM3t7KT5wdP/fql9YH13abOw8v/gnl8XO3+Ti/KD90AedoNE8nMlAevZEhiWtyKYrnTM5fRwAyec+GKhfWu1w6OFS2bR9HICx6TAWYnemMPhBcoXdZYWwUgdsETfk0ZuKz6KcImzb4acKlmDdHPpOqM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbf25e2b-e0d6-4682-f2dc-08dc2d45269d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 10:10:20.5596
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0R0rv9bRbAcrIbDy+vyQEwqL5UmmRzRQfcS8zSVDmBeOhv/8y++c3qtbPKPD3L/haMthdt8oYMZgpMRA7h8uDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB7499
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-14_04,2024-02-12_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402140079
X-Proofpoint-GUID: vllnYyUPJsSAr91tqMpYC9gJ6-aCuOmQ
X-Proofpoint-ORIG-GUID: vllnYyUPJsSAr91tqMpYC9gJ6-aCuOmQ

On 13/02/2024 22:49, Dave Chinner wrote:
>> Does xfs_io have a statx function?
> Yes, it's right there in the man page:
> 
> 	statx [ -v|-r ][ -m basic | -m all | -m <mask> ][ -FD ]
>                Selected statistics from stat(2) and the XFS_IOC_GETXATTR system call on the current file.
>                   -v  Show timestamps.
>                   -r  Dump raw statx structure values.
>                   -m basic
>                       Set the field mask for the statx call to STATX_BASIC_STATS.
>                   -m all
>                       Set the the field mask for the statx call to STATX_ALL (default).
>                   -m <mask>
>                       Specify a numeric field mask for the statx call.
>                   -F  Force the attributes to be synced with the server.
>                   -D  Don't sync attributes with the server.

ok, I can check that out and look to add any support required for atomic 
writes extension.

Thanks,
John