Received-SPF: pass (google.com: domain of linux-kernel+bounces-65034-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
Precedence: bulk
MIME-Version: 1.0
Message-Id: <2780b965-02fe-41fd-ae16-98f7619aeed2@app.fastmail.com>
In-Reply-To: <20240131033028.3099156-1-dawei.li@shingroup.cn>
References: <20240131033028.3099156-1-dawei.li@shingroup.cn>
Date: Wed, 14 Feb 2024 11:17:06 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Dawei Li" <dawei.li@shingroup.cn>,
 "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Serge Semin" <fancer.lancer@gmail.com>,
 "kernel test robot" <lkp@intel.com>, linux-kernel@vger.kernel.org,
 "Dawei Li" <set_pte_at@outlook.com>
Subject: Re: [PATCH v2] misc: eeprom/idt_89hpesx: Convert data structures to LE
 explicitly
Content-Type: text/plain

On Wed, Jan 31, 2024, at 04:30, Dawei Li wrote:
> Kernel test robot reports following sparse warnings:
>>> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: sparse:
>    incorrect type in assignment (different base types) @@
>    expected unsigned short [addressable] [assigned] [usertype]
>    memaddr @@     got restricted __le16 [usertype] @@
>
>    drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
>    expected unsigned short [addressable] [assigned] [usertype]
>    memaddr
>
>    drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
>    restricted __le16 [usertype]
>
>    .....
>
> For data structures needs cpu_to_le* conversion, their prototype need
> to be declared with __le* explicitly.
>
> Declare data structures to __le* explicitly to address the issue:
> - struct idt_eeprom_seq::memaddr
> - struct idt_csr_seq::csraddr
> - struct idt_csr_seq::data
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>