Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp475813rdh; Wed, 14 Feb 2024 02:34:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWNF/iieNA1tqL0w9za1KnNSM4hMZsP00Q3BBBqlKhzEsqJTQdbyntUGc5sB3A8CoM4dilnjwdoG8RC/Uv0oBh+WTiiivJnFobbkFAmHw== X-Google-Smtp-Source: AGHT+IHyioIX/hONc1mxh6OjtgW+2dXXOftYwOnWCcwS8H1yOCCybeYMWPmQJ6Etk0ieN8lf7kqc X-Received: by 2002:a05:6102:243a:b0:46e:d972:e39c with SMTP id l26-20020a056102243a00b0046ed972e39cmr2028629vsi.25.1707906873973; Wed, 14 Feb 2024 02:34:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707906873; cv=pass; d=google.com; s=arc-20160816; b=XgyZzE6tW0FrODTGq/YF010PSCecOJz1FqiaZ00MX+u/DD6nR16DYb9T+gvxki6Y98 ZcnRXWlrao+2DD2lHW+r+kg9cgNmqPg15k6m/awZc1oBF0grDGw9wz2FgiHz0XbkS7+Q 7dSrmbCO13aqSRdOGseAi0eOHl1Fbsilg5HZu9rrA7RpPWx2vs/mS8gC6nw8LWaDOzda z4g9FZZq9/KR0Oi3gMpcJTJNpSVViWbErz8v6f93o2ENkUfKxSo7K9BycdbFZ/hS+oxQ lvGziV+kwBVkRZU3sCeNBEM+31uDs5YKymEs9QdKX4woEaP8juAiXDxwzeIzMadyeb9D ALSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/G73YZ9Y+2T2wWCfsv8XStDggZBaLxT+N6Wb6sPIUOw=; fh=b00kFTSRxEpviGqYNfu+ho9GeLLNovbiR1P5/7YTOdY=; b=FU0YwXhJArgOYaVrk0lDiX+wuA8tD+m035Jztx75Q27od6bkxLo/tND3fKOjahhh2R PKAl+K6Ufv4J66auQM9ctorU1SME2s7/NU7tuRFNFHesIKObd6XnYb9SDeXCSOwK310J Zv7DBCvQE3U9G+QdWUi6Rzm7o3WwFKGrnwRBLg6jaBpUGuQGPqNyC02O2JY5pGc64RIp YyxNwmu4wJl8KDFRlVBKzIslpbu2KvsPwENVf0evx0xHOYwMAcn4uQArQMPuvo7ozbsb KuLa5LO00nYdS73+RfOM/2nlyHru/Ljp/jkZPTDjNOS8bcqTrUIcfwsQIAWZPGscmHoy rylA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="lDQx2/0g"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-65054-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65054-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org X-Forwarded-Encrypted: i=2; AJvYcCWpu4tW4eIsmPHMWicAGsukE8OjuT9gnAnvWXaYzZ3SzceQkCju3UWN3LDp/qdmDLzTKOxDg09xGx1+BVRXDejzuZXMZzuhE4dtHHcXhA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id c17-20020ac87d91000000b0042c7859cd53si5356982qtd.247.2024.02.14.02.34.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 02:34:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-65054-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="lDQx2/0g"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-65054-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-65054-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7AF7B1C27479 for ; Wed, 14 Feb 2024 10:34:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EB01618028; Wed, 14 Feb 2024 10:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lDQx2/0g" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F085F17543; Wed, 14 Feb 2024 10:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707906863; cv=none; b=exKmn+GqxQmuNYgWcCja2icCx1X+VisJBjwj1/NllKrqAlGyCAx5m8TH5BzqBRuFzRpQASLMkVPJDaK+uPkyXRtPh8htuh6Z7fW7TiBSWDWXit9HadqJGyhQN2ygCdC7oscDxBW4VsAEJpt1KfOuXG0Kg6On5I6oKuK3md1Ywas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707906863; c=relaxed/simple; bh=DkS4pHSLevwnDUiaBlD8B/uLDOdKpNV1qvB47nYEqPw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PUd36Zh0bj7bFA0MPZIV2vC3etC2hcuh/KeaGYvES3fbiwVk8fHPFKsiec4auM9uU0X9gBp6sf5hZl9MCbQiIesyUC8umbKazBx+7ldqA1odtqugjquYOA06kRb0SM+zQpRWOmIsSznXvgHhLPFJxv22lOK4tphvnBFaxGvAx8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lDQx2/0g; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9952C433F1; Wed, 14 Feb 2024 10:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1707906862; bh=DkS4pHSLevwnDUiaBlD8B/uLDOdKpNV1qvB47nYEqPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lDQx2/0giln9bSgIWKwhm0lRPICkGgbmBs5pbsKMA3UOZqGxJHwOO/VlVAXHWqpcY 1Euqnq7GXzADgKEYPs9Pgz8ZbyLvBpEoLFLZJdWPpIYhru9Pi2aQwb9u0NApbuhNmi a+X4ZZVFf9OAxcpZKVSsiM94KPmwTTiLYdD3E5C8= Date: Wed, 14 Feb 2024 11:27:20 +0100 From: Greg Kroah-Hartman To: Eric Dumazet Cc: Christian Brauner , linux-kernel , "Rafael J . Wysocki" , Andrew Morton , netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Subject: Re: [PATCH 0/2] kobject: reduce uevent_sock_mutex contention Message-ID: <2024021444-getaway-partly-e055@gregkh> References: <20240214084829.684541-1-edumazet@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240214084829.684541-1-edumazet@google.com> On Wed, Feb 14, 2024 at 08:48:27AM +0000, Eric Dumazet wrote: > This series reduces the (small ?) contention over uevent_sock_mutex, > noticed when creating/deleting many network namespaces/devices. > > 1) uevent_seqnum becomes an atomic64_t > > 2) Only acquire uevent_sock_mutex whenever using uevent_sock_list Cool, any boot-time measured speedups from this? Or is this just tiny optimizations that you noticed doing reviews? thanks, greg k-h