Received-SPF: pass (google.com: domain of linux-kernel+bounces-65097-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 14 Feb 2024 12:05:41 +0100
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: tony.luck@intel.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, avadhut.naik@amd.com,
	john.allen@amd.com, muralidhara.mk@amd.com,
	naveenkrishna.chatradhi@amd.com, sathyapriya.k@amd.com
Subject: Re: [PATCH 2/2] RAS: Introduce the FRU Memory Poison Manager
Message-ID: <20240214110541.GFZcyehY44eSSYsW2l@fat_crate.local>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-3-yazen.ghannam@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240214033516.1344948-3-yazen.ghannam@amd.com>

On Tue, Feb 13, 2024 at 09:35:16PM -0600, Yazen Ghannam wrote:
> +static inline struct cper_fru_poison_desc *get_fpd(struct fru_rec *rec, u32 entry)
> +{
> +	return &rec->entries[entry];
> +}

This one needs to go too.

> +static inline u32 get_fmp_len(struct fru_rec *rec)
> +{
> +	return rec->sec_desc.section_length - sizeof(struct cper_section_descriptor);
> +}

Oh well, I guess we can keep that one.

> +/* Calculate a new checksum. */
> +static u32 get_fmp_checksum(struct fru_rec *rec)
> +{
> +	struct cper_sec_fru_mem_poison *fmp = get_fmp(rec);
> +	u32 len, checksum;
> +
> +	len = get_fmp_len(rec);
> +
> +	/* Get the current total. */
> +	checksum = do_fmp_checksum(fmp, len);
> +
> +	/* Subtract the current checksum from total. */
> +	checksum -= fmp->checksum;
> +
> +	/* Return the compliment value. */
> +	return 0 - checksum;
> +}

Let's get rid of that one.

Also, I think it is called *complement* value and you simply do

        /* Use the complement value. */
        rec->fmp.checksum = -checksum;

I'd say.

---

diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
index 9eaf892e35b9..f8799beddcc4 100644
--- a/drivers/ras/amd/fmpm.c
+++ b/drivers/ras/amd/fmpm.c
@@ -195,11 +195,12 @@ static u32 do_fmp_checksum(struct cper_sec_fru_mem_poison *fmp, u32 len)
 	return checksum;
 }
 
-/* Calculate a new checksum. */
-static u32 get_fmp_checksum(struct fru_rec *rec)
+static int update_record_on_storage(struct fru_rec *rec)
 {
 	u32 len, checksum;
+	int ret;
 
+	/* Calculate a new checksum. */
 	len = get_fmp_len(rec);
 
 	/* Get the current total. */
@@ -208,15 +209,8 @@ static u32 get_fmp_checksum(struct fru_rec *rec)
 	/* Subtract the current checksum from total. */
 	checksum -= rec->fmp.checksum;
 
-	/* Return the compliment value. */
-	return 0 - checksum;
-}
-
-static int update_record_on_storage(struct fru_rec *rec)
-{
-	int ret;
-
-	rec->fmp.checksum = get_fmp_checksum(rec);
+	/* Use the complement value. */
+	rec->fmp.checksum = -checksum;
 
 	pr_debug("Writing to storage");
 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette