Received-SPF: pass (google.com: domain of linux-kernel+bounces-65102-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 14 Feb 2024 12:10:32 +0100
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: tony.luck@intel.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, avadhut.naik@amd.com,
	john.allen@amd.com, muralidhara.mk@amd.com,
	naveenkrishna.chatradhi@amd.com, sathyapriya.k@amd.com
Subject: Re: [PATCH 2/2] RAS: Introduce the FRU Memory Poison Manager
Message-ID: <20240214111032.GGZcyfqFqsW0j4Yy3a@fat_crate.local>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-3-yazen.ghannam@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240214033516.1344948-3-yazen.ghannam@amd.com>

On Tue, Feb 13, 2024 at 09:35:16PM -0600, Yazen Ghannam wrote:
> +static void init_fpd(struct cper_fru_poison_desc *fpd,  struct mce *m)
> +{
> +	memset(fpd, 0, sizeof(struct cper_fru_poison_desc));
> +
> +	fpd->timestamp	= m->time;
> +	fpd->hw_id_type = FPD_HW_ID_TYPE_MCA_IPID;
> +	fpd->hw_id	= m->ipid;
> +	fpd->addr_type	= FPD_ADDR_TYPE_MCA_ADDR;
> +	fpd->addr	= m->addr;
> +}

Get rid of that one:

diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
index f8799beddcc4..090b60d269e7 100644
--- a/drivers/ras/amd/fmpm.c
+++ b/drivers/ras/amd/fmpm.c
@@ -221,17 +221,6 @@ static int update_record_on_storage(struct fru_rec *rec)
 	return ret;
 }
 
-static void init_fpd(struct cper_fru_poison_desc *fpd,  struct mce *m)
-{
-	memset(fpd, 0, sizeof(struct cper_fru_poison_desc));
-
-	fpd->timestamp	= m->time;
-	fpd->hw_id_type = FPD_HW_ID_TYPE_MCA_IPID;
-	fpd->hw_id	= m->ipid;
-	fpd->addr_type	= FPD_ADDR_TYPE_MCA_ADDR;
-	fpd->addr	= m->addr;
-}
-
 static bool has_valid_entries(struct fru_rec *rec)
 {
 	if (!(rec->fmp.validation_bits & FMP_VALID_LIST_ENTRIES))
@@ -288,7 +277,13 @@ static void update_fru_record(struct fru_rec *rec, struct mce *m)
 
 	mutex_lock(&fmpm_update_mutex);
 
-	init_fpd(&fpd, m);
+	memset(&fpd, 0, sizeof(struct cper_fru_poison_desc));
+
+	fpd.timestamp	= m->time;
+	fpd.hw_id_type = FPD_HW_ID_TYPE_MCA_IPID;
+	fpd.hw_id	= m->ipid;
+	fpd.addr_type	= FPD_ADDR_TYPE_MCA_ADDR;
+	fpd.addr	= m->addr;
 
 	/* This is the first entry, so just save it. */
 	if (!has_valid_entries(rec))

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette