Received: by 2002:a05:7412:2a91:b0:fc:a2b0:25d7 with SMTP id u17csp504066rdh; Wed, 14 Feb 2024 03:34:46 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVQ3+vj5Mm3f1VGc+qiHtDIJ62EIlFlklVrCBGWMKuXXgYOH/bZbs91OfYqYr276K5Fc2/AFcd6kPW9bwXYLZm7nhoCkcmEnjCQE7egSw== X-Google-Smtp-Source: AGHT+IG8npV8rDs5Yj8Ca1bEowU15AqKYdY1VzbB6H76yvcVk9kXM1KWhgzCx5zVbOXVGl0Sxk0A X-Received: by 2002:a92:c143:0:b0:364:1981:f513 with SMTP id b3-20020a92c143000000b003641981f513mr2362397ilh.32.1707910486189; Wed, 14 Feb 2024 03:34:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707910486; cv=pass; d=google.com; s=arc-20160816; b=uo/ERy2aa+dqHeMbWVFng83xkLrkf5MSt4S/3i556YnMN4MQY/1vzChXuruvWCnJn3 +JQoV6LQ3kv6pC114uyTSW/cS8R6zoTXCm1eLRp4AjBcb811Ddd+phErcDTGT+TOVil7 FL9ie3eEXpCGkxtgTJA/QXUGMOd2sq2e88wjcHInLWbasgKd55zTzUESUUxPdmC2kjo5 3toMrVjEgzcKUcxep8r5GvNfJLt7VL95g6hbRjleTFp8uoUmDYwMgRuFh8VvYaonrJo6 GuALIJA8V8qCo8nmGKu2E72D3xtd6RawcgxyIBOujglS+87MncHwvFt+nzYiKCuxJ6lC gAPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kgB1w54Os+DFr02nZaUKpHD/K1vIgMJvD2Vwb8Vk+I8=; fh=IZhguIjHX/SxAZ0BzuZg4IDdeTm8GK9w3Tr+lt8f2ew=; b=Eo7TYcP9JwYI5S18TBIwmQrnpR/QcuFfBxp74hMOLhS9JCnvWXyK16am3QBs4BTRSt 4Lez2beLYEUTbjN97GJXDlQYBUzdpbRsJ7OZp6E16tk4dAbQnxzEu6k4p1CgaJoEIwIV rOdi7FIFPVh7ugyFPQG+VISMFUypRvYt1XXkB1JZurFVnwasU+jVkPphTdWFjubYLOLB NoaaOyMZSZ4VR5RmWJ6TsMXzVbqxCHyowX3ktkDQq7x8utpRFMZ79oL8+hpIyIRZUdwI Nma6ZZr2hfNlK4fSQVlaJqqaLo3MhuyaJj2SOvtXHrkcUQX4Mb6pnc0EzNpPzXYBkelg CJjQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=dKVupMZJ; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-64867-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64867-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCWFuCb2cPqqpCp0lgXHTQY5tBZday6Qu+RewTmtUdcfVCn/bFTrmd2qclDXZgGPmo3WiKlsIPOda/1Nh+aA3hJbobLoQ4l0dQSTGNIAIQ== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id a193-20020a6390ca000000b005cfb2c44526si3587640pge.862.2024.02.14.03.34.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 03:34:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64867-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=dKVupMZJ; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-64867-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64867-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 57F53281696 for ; Wed, 14 Feb 2024 08:29:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D34AA125AF; Wed, 14 Feb 2024 08:29:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dKVupMZJ" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6030F125AB for ; Wed, 14 Feb 2024 08:29:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707899365; cv=none; b=FTwiWPBl4T6oRYrA0qi/kpwTyNGe6hopT5NNHT1b81Yn3NosrXW4s6wT9oWO8F8SxsGZYwF+dppM83VXDLHXfY06zisEerW1iTceExNLURNZ8bH19pCQwePAbyQDrL6blGl9yt6GpGhFe7mH6KVHWWcnyrAiICLmP1Ifj+d1trQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707899365; c=relaxed/simple; bh=lr1cpTq9SDjQGx44axcCjzlI0LjYViMDYTVhzqfBjd4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RsG02oN1XuZA9iWeFLO7QDKtfbh1DziH0qNuTckbBOdecr/LEjSFMAhwIQ5yGs2npUT7wnOhH59/w4OuOg8IWdwcjAit6Hd6Ih40/CyENzLvBdfKC2Pb91AMz5v71jUOeqxMFRklm5O6mXLck3IcSss1GzeuetSrDBmM8pIY8iI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=dKVupMZJ; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kgB1w54Os+DFr02nZaUKpHD/K1vIgMJvD2Vwb8Vk+I8=; b=dKVupMZJPm90DTsuhbaWNd2YTP bhOj1aQ3k0oQ+9HOf/DwfNl+CRVRjmwneXcfbST1Lj91dCOYgZOcMYWIOrKCsI0PAQoLeB903l36z jJY+TjucUI2AekrDPtkIvKwgUu4AWCjajCth6Ndf0+VKw6fbn0G4iBcknrndwVA/VAWEkHy+mPOWQ AcOuPTzzknK6bADKTKiipBQ2q4A+6mneK1IGcnHTqzQiVvZpxTmD8Az1aZQSUkgkDOwj+iaUGkc6d E3psHePQTRGyykuVvYc4gaAqGDTQ9GNf5GCOI4fn8XPpvETlbg/917rokpfkRg7c7ZWGrU26jVCKx j7R0DWbw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1raAdo-0000000C9Ei-2Nne; Wed, 14 Feb 2024 08:29:16 +0000 Date: Wed, 14 Feb 2024 00:29:16 -0800 From: Christoph Hellwig To: Saeed Mahameed Cc: Arnd Bergmann , Greg Kroah-Hartman , Leon Romanovsky , Jason Gunthorpe , Jiri Pirko , Leonid Bloch , Itay Avraham , Jakub Kicinski , Saeed Mahameed , David Ahern , Aron Silverton , Christoph Hellwig , andrew.gospodarek@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 0/5] mlx5 ConnectX control misc driver Message-ID: References: <20240207072435.14182-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207072435.14182-1-saeed@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Chmining in late after a vacation last week, but I really do not understand the discussion this cause. Complex devices need diagnostics, and mlx5ctl and the (free software) userspace tool provide that. Given how it is a complex multi-subsystem driver that exports at least RDMA, ethernet, nvme and virtio_blk interfaces this functionality by definition can't fit into a single subsystem. So with my nvme co-maintainer hat on: Acked-by: Christoph Hellwig to th concept (which is not a full code review!). With my busy kernel contributor head on I have to voice my dissatisfaction with the subsystem maintainer overreach that's causing the troubles here. I think all maintainers can and should voice the opinions, be those technical or political, but trying to block a useful feature without lots of precedence because it is vaguely related to the subsystem is not helpful. Note that this is absolutely not intended to shut the discussion down - if we can find valid arguments why some of this functionality should also be reported through a netdev API we should continue that. E.g. just because we have SCSI, NVMe or product specific passthrough interface we still try to provide useful common interface generically.