Received-SPF: pass (google.com: domain of linux-kernel+bounces-65040-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 14 Feb 2024 12:22:57 +0200 (EET)
To: Vishnu Sankar <vishnuocv@gmail.com>
cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>, 
    Mark Pearson <mpearson-lenovo@squebb.ca>, vsankar@lenovo.com
Subject: Re: [PATCH 2/2] platform/x86: thinkpad_acpi: Fix to correct wrong
 temp reporting on some ThinkPads
In-Reply-To: <20240214052959.8550-2-vishnuocv@gmail.com>
Message-ID: <97fb005c-92bc-790b-80b0-75149a799b4b@linux.intel.com>
References: <20240214052959.8550-1-vishnuocv@gmail.com> <20240214052959.8550-2-vishnuocv@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-2051631955-1707905357=:7959"
Content-ID: <f7c0f68c-a877-b78a-78fb-25cb2650f791@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-2051631955-1707905357=:7959
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <7a7d916c-733b-6bf9-216b-a3ebf981ddf0@linux.intel.com>

On Wed, 14 Feb 2024, Vishnu Sankar wrote:

> Added non-standard thermal register support for some ThinkPads.
>=20
> Some of the Thinkpads use a non-standard ECFW which use different
> thermal register addresses.
> This is a fix to correct the wrong temperature reporting on
> those systems.
>=20
> Tested on Lenovo ThinkPad L13 Yoga Gen2
>=20
> Suggested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>
> ---
> -Improvements as requested.
> -Improved the readability in case TPACPI_THERMAL_TPEC_12.
> -idx < 8 from idx idx <=3D7 to match idx =3D 8
> -KILO used from linux/units.h instead of 1000.

>  static enum thermal_access_mode thermal_read_mode;
>  static bool thermal_use_labels;
> +static bool thermal_with_ns_address;=09/*Non-standard thermal reg addres=
s*/

Comment is missing spaces.

> @@ -6239,6 +6267,20 @@ static int thermal_get_sensor(int idx, s32 *value)
>  =09=09}
>  =09=09break;
> =20
> +=09/* The Non-standard EC uses 12 Thermal areas */
> +=09case TPACPI_THERMAL_TPEC_12:
> +=09=09if (idx >=3D 12)
> +=09=09=09return -EINVAL;
> +
> +=09=09t =3D idx < 8 ? TP_EC_THERMAL_TMP0_NS + idx :
> +=09=09=09=09TP_EC_THERMAL_TMP8_NS + (idx - 8);
> +
> +=09=09if (!acpi_ec_read(t, &tmp))
> +=09=09=09return -EIO;
> +
> +=09=09*value =3D tmp * KILO;

Hmm, MILLI would be much more approriate here? But if this relates to=20
degrees, there is MILLIDEGREE_PER_DEGREE?

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.
--8323328-2051631955-1707905357=:7959--