Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbXLXVyG (ORCPT ); Mon, 24 Dec 2007 16:54:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751783AbXLXVxy (ORCPT ); Mon, 24 Dec 2007 16:53:54 -0500 Received: from slackadelic.com ([65.196.224.53]:60297 "EHLO mail.slackadelic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbXLXVxx (ORCPT ); Mon, 24 Dec 2007 16:53:53 -0500 From: Carlos Corbacho To: Linus Torvalds Subject: Re: x86: Increase PCIBIOS_MIN_IO to 0x1500 to fix nForce 4 suspend-to-RAM Date: Mon, 24 Dec 2007 21:53:47 +0000 User-Agent: KMail/1.9.7 Cc: "Rafael J. Wysocki" , "H. Peter Anvin" , Linux Kernel Mailing List , Greg KH , Ingo Molnar , Thomas Gleixner , Len Brown , Andrew Morton , pm list References: <200712231419.40207.carlos@strangeworlds.co.uk> <200712241444.24031.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200712242153.48906.carlos@strangeworlds.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1629 Lines: 39 On Monday 24 December 2007 18:34:21 Linus Torvalds wrote: > On Mon, 24 Dec 2007, Rafael J. Wysocki wrote: > > Well, having considered that for a longer while, I think the AML code is > > referring to a device that we have suspended already, and since it's in a > > low power state, it just can't handle the reference. > > > > If that is the case, we'll have to find the device (that should be > > possible using some code instrumentation) and move the suspending of it > > into the late stage. > > Yes. My own experimentation (in device_suspend(), calling _PTS() in the AML after each suspend_device() runs, until one device causes it to hang) points to ohci_hcd being the culprit here (with or without any devices attached). With the ohci_hcd module unloaded, the machine suspends just fine[1]. Of course, I'm at a complete loss as to why suspending OHCI would cause a problem for an IO port write. > NOTE! This following patch is just for discussion, and while I think it's > conceptually a good thing to try, I don't think it will help Carlos' > problem. But removing the "pci_set_power_state()" in agp_nvidia_suspend() > might. nvidia-agp cannot be built on x86-64, so it's not the culprit in this case. -Carlos [1] And yes, I double checked the custom DSDT is not loaded this time. -- E-Mail: carlos@strangeworlds.co.uk Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/