Received-SPF: pass (google.com: domain of linux-kernel+bounces-65185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c0c44bc1-758c-4690-a6e3-d3424dfa7172@oracle.com>
Date: Wed, 14 Feb 2024 12:19:11 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/6] fs: xfs: Support FS_XFLAG_ATOMICWRITES for rtvol
Content-Language: en-US
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz, chandan.babu@oracle.com,
        martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com
References: <20240124142645.9334-1-john.g.garry@oracle.com>
 <20240124142645.9334-4-john.g.garry@oracle.com>
 <20240202175225.GH6184@frogsfrogsfrogs>
 <7330574a-edc5-4585-8f1a-367871271786@oracle.com>
 <20240213172205.GA6184@frogsfrogsfrogs>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240213172205.GA6184@frogsfrogsfrogs>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?eHlYVGdlQldIZWhiOXhsYlZXTmRuM1NaYXlFNWpjdVJqa25kTWd3Y3NNZTUz?=
 =?utf-8?B?SEVURHN4Y0JEVmJBWFhiOER3czljSXZxRmN5eDNNN0hBc2d3VDhyaWQ0TERF?=
 =?utf-8?B?aW5oMlpuQktNdXp1RWVsUGprYkMxSWFCcnlLbTU2dnJEMlcwdTR4ZXhVTzN3?=
 =?utf-8?B?cWxQTC8yREg2YjY0MHJOMDVRcTJlQ0ZhSG8wRVplUzZucE80RlpWZ2toT0l4?=
 =?utf-8?B?VXpaejJ6Tk04blpJamxmdHhoZm1CcjVzUmZTT0xSWTRkWk5lcWpwck50TE9Z?=
 =?utf-8?B?dDQycHBwVWZVVkc2eEVVM2RXT1JRanlpeXdyazBlUTlKK3VkTGFXWmhpOUla?=
 =?utf-8?B?QWw3emFFaWhtRjRQZ1c0eWtvWFA3U21CM2VoeXppK0VmZzJGeEhuRFRkQTFk?=
 =?utf-8?B?dTZsTFo1dzBOV3RML3N1OWZ5bnRqVzQwUyt2Q0JxTFNtUU9KcXNacWNXN0NC?=
 =?utf-8?B?RmQvdzJKQlpLaE5kQTFTYXZDQVBVUlpvSjRjc2lmZm11ek9tckowRjFseEdR?=
 =?utf-8?B?cVQzSkFpbnFkQkx2bTJ1cG05akpUMnVuTEo0Y3huTmowaUJsTlhvNlN0M0JG?=
 =?utf-8?B?QVBNSGpIbHVDM3BSeEhPUzB3aW9hRXZsZUI1OHppbVdNVldydE9VTnBwcldR?=
 =?utf-8?B?ZzFVU1FKdDJYNW9UVDV3Zkg3WW4rYXdFd0xpZVlHVWpDTzhKdWhsaVJDMUo5?=
 =?utf-8?B?bW5Kc3BFVnlyKzZDQ0xwa3FySGZaV2hLME9MUElLcGlyZnZuK2pDZFpsQUhY?=
 =?utf-8?B?YU11L0FibnljOGl5L21nU1lHRFNrMHVKOTdpQ1FRdW5HMmNRNzF0TitpTURR?=
 =?utf-8?B?NE55d05vNDB5QkZkVGdvSmFUY1NuZ1RnU1BLdjM4b2xOZVFveUt2VmcxS0N1?=
 =?utf-8?B?akxoYk80NGJKNGVtZnJobDQ1WGdiT3kzVHFvM1RFWVRWOWxkNmFvb3k1aStC?=
 =?utf-8?B?VG9YQlZjaThJMC8vNllyN3RBRVRLWFlyVXhtYUdsRkk1Nm9XbEhWc0ZSbEZD?=
 =?utf-8?B?YmIrUnFoMTQwMjdSNE5vTUpMZ2psbTRwZ1p6a25QQ2JpS3JmRjFncFk4Y2pk?=
 =?utf-8?B?SDY2SE5xWEVEZmhPSnljYThJNUs5YXAwYzNTTWY0d21GUnYzZ3ZlRnFvZjd5?=
 =?utf-8?B?UHhGeTJSc2lZYlhPandBMGhrNHpXRm1sb2E0dVpyV1REcTBhQnFia2gvNkNM?=
 =?utf-8?B?dFVaSlgzOHZpRitTZ0tmUGo1ZzBYY1BleVVZR1NpVGliTWdJMW1HS3M4ZU92?=
 =?utf-8?B?M2tYb3FNZ2twYngwL1BRSTgzb1M0K2RxRlNjc252S0x6Y2d2SUViY21CNWJk?=
 =?utf-8?B?cUprTFRGcW1sYWNPNnZMWUxrN0ZrQW1FM2QwdTRsb282Yi9WdVZ2amZ3b2Nv?=
 =?utf-8?B?MFdrbnRqaEwzbUJpZWN5aCtGTkJxWitranRFdFN2TFB6VzVvMVNDMEJrQ01k?=
 =?utf-8?B?b0lJdU14QkRBc0ErbXpGdE8rdDhnL01BTkpOVzFoSGRiaU84Q3dOcFoyUkFD?=
 =?utf-8?B?MHNGNU9wQjdBTmN1dCtwMnFDRmNWT3pXd1lYK0h1TEZHczFUK01SbW12NFRl?=
 =?utf-8?B?UGgxZVdxVW5OZFlmYUdIR0VXYzFBL0gyZzRWQkdKaXFMSytFNVBvYnJXdThm?=
 =?utf-8?B?cFd6aXR0WE11czAyV0I1S3lpcUpLWkppbk1DRERpZ0Y0MXo1WldtOEMxbGhU?=
 =?utf-8?B?aHJ4TjVSV0tHb3c4MVRNZGVoR2VrOVpGMzFHNlJHSlVKdDZjTytxNXJoNXdv?=
 =?utf-8?B?bW90S3llODZ0aHdQbHkweVlFZVBHL09Uc0lWSGRWRHZ0K3JLT0xiWTFzQkND?=
 =?utf-8?B?MXZieXFMTEhpeDBiZGtBcm1JRTIvQW1OV01NOXBWQmZHMDVaUUhUU1U5VWYr?=
 =?utf-8?B?L2hvRUpHMGRkcUJOQjhOV01hWFJKcG5Va3pTcG14VkVGRWxnWUdaQzlsSDdj?=
 =?utf-8?B?Mm9XN2tBbXZHTUhOSTFUOExuSkw2OUFzRlZtRFpWajd2MDFwbnNCdXhpd3dM?=
 =?utf-8?B?SlRDbU5mUDh1Njhma29weEY5TG1xZk43eUljYk91M1lCVUZvWFRwNlJYSzk5?=
 =?utf-8?B?K0ovekI1T3h5S2lBeUo0K0Q4N1R5SzJMbklKTGd6TG9QYmhxNEhCT2IwTzF3?=
 =?utf-8?Q?jY//RinYqXvEdpKD7jnSJp4Cb?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Bum3yiLD9ROhew8+FOaim6T+LkcdR36UUXSrAdnEbmziXy4gB4arg38M+UebMSeWjBy6ieEtO7Pp3IoBYFGE9h4Vb6i2NKGniEBomyeNUXDzqJLY/3QVPfE0N82As2ti0PEtY/HxD+0So83bB3fHY2UUkdVueCIOSNLESRLkjImCyslpcX69XH7RU7YJ0DC2SvTNUzDe13L/fgq+uAu/JJLUMPIKyOjsuuqNCyNzwgZWmj3RHWGMI72ccieIeYb6ix4Jkzone2CRYJhi4+wzOhc14nF/IibgOwOPCgsj9zg2Fb+pcNh0sjypKp12T3/W4dDpkZKok1xiWW8MjI9avB+iGlJVpaXI9gs5Jozy2IfQ/bIwuAqSAAnoX/+N0bgUbqTiWqBc0Yx8MiQIEEkD113xkXa4RLd8tW3XtJeckTl7vf5UMPHk9L0xW+Nrhum3lmNs0oIJImGgmgKKVPUXkJwr+U2rhkt6sLPWmsBXtOKLaxbAy7jFLT1/syEv3VSUMkBc1Th/7sgvCQeB+Xa2oSb9uxzgAPEgvFCQoPqoTXSy/Q+cURFEQPfLRXhGcoylViSNJNbg/PZianqy0Q3oexTQ3WXLAFgfssefbXNYiQw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 767d82ab-145e-4381-b12e-08dc2d572935
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 12:19:15.8813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pXWi62LYT0ibNct29EVbiQQ0OIqH9W04plGAApzme12fg9ntpmbYcxfw3pd0+Q2asQT7ifPUdsgALpT3yMRnzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4798
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-14_04,2024-02-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 suspectscore=0
 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402140096
X-Proofpoint-ORIG-GUID: hBGKTxn769fYQP6aMYHgwio6Pss_brZd
X-Proofpoint-GUID: hBGKTxn769fYQP6aMYHgwio6Pss_brZd

On 13/02/2024 17:22, Darrick J. Wong wrote:
>> I am not sure what bdev_validate_atomic_write() would even do. If
>> sb_rextsize exceeded the bdev atomic write unit max, then we just cap
>> reported atomic write unit max in statx to that which the bdev reports and
>> vice-versa.
>>
>> And didn't we previously have a concern that it is possible to change the
>> geometry of the device?
> The thing is, I don't want this logic:
> 
> 	if (!is_power_of_2(mp->m_sb.sb_rextsize))
> 		/* fail */

This is really specific to XFS. Let's see where all this alignment stuff 
goes before trying to unify all these checks.

> 
> to be open-coded inside xfs.  I'd rather have a standard bdev_* helper
> that every filesystem can call, so we don't end up with more generic
> code copy-pasted all over the codebase.
> 
> The awkward part (for me) is the naming, since filesystems usually don't
> have to check with the block layer about their units of space allocation.
> 
> /*
>   * Ensure that a file space allocation unit is congruent with the atomic
>   * write unit capabilities of supported block devices.
>   */
> static inline bool bdev_validate_atomic_write_allocunit(unsigned au)
> {
> 	return is_power_of_2(au);
> }
> 
> 	if (!bdev_validate_atomic_write_allocunit(mp->m-sb.sb_rextsize))
> 		return -EINVAL;

As above, I can try to unify, but this alignment stuff is a bit up in 
the air at the moment.

Thanks,
John