Received-SPF: pass (google.com: domain of linux-kernel+bounces-65196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240210204606.11944-1-aford173@gmail.com> <20240210204606.11944-3-aford173@gmail.com>
 <20240214121448.451e2e1c@booty>
In-Reply-To: <20240214121448.451e2e1c@booty>
From: Adam Ford <aford173@gmail.com>
Date: Wed, 14 Feb 2024 06:35:36 -0600
Message-ID: <CAHCN7xKa3svzoRiQZ=KO-zwpmXL7Dw7hOp7B0MF-2EQCQ=f-eA@mail.gmail.com>
Subject: Re: [PATCH V4 2/6] phy: freescale: add Samsung HDMI PHY
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: linux-arm-kernel@lists.infradead.org, marex@denx.de, 
	aford@beaconembedded.com, Lucas Stach <l.stach@pengutronix.de>, 
	Richard Leitner <richard.leitner@skidata.com>, Marco Felsch <m.felsch@pengutronix.de>, 
	Alexander Stein <alexander.stein@ew.tq-group.com>, 
	Frieder Schrempf <frieder.schrempf@kontron.de>, Vinod Koul <vkoul@kernel.org>, 
	Kishon Vijay Abraham I <kishon@kernel.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, 
	NXP Linux Team <linux-imx@nxp.com>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 14, 2024 at 5:14=E2=80=AFAM Luca Ceresoli <luca.ceresoli@bootli=
n.com> wrote:
>
> On Sat, 10 Feb 2024 14:45:58 -0600
> Adam Ford <aford173@gmail.com> wrote:
>
> > From: Lucas Stach <l.stach@pengutronix.de>
> >
> > This adds the driver for the Samsung HDMI PHY found on the
> > i.MX8MP SoC. Based on downstream implementation from
> > Sandor Yu <Sandor.yu@nxp.com>.  According to the TRM, the PHY
> > receives parallel data from the link and serializes it.  It
> > also sets the PLL clock needed for the TX serializer.
> >
> > Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> (v2)
> > Tested-by: Richard Leitner <richard.leitner@skidata.com> (v2)
> > Co-developed-by: Marco Felsch <m.felsch@pengutronix.de>
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron BL
> > Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> [...]
>
> > +static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy)
> > +{
> > +     struct device *dev =3D phy->dev;
> > +     struct device_node *np =3D dev->of_node;
> > +     struct clk_init_data init;
> > +     const char *parent_name;
> > +     struct clk *phyclk;
> > +     int ret;
> > +
> > +     parent_name =3D __clk_get_name(phy->refclk);
> > +
> > +     init.parent_names =3D &parent_name;
> > +     init.num_parents =3D 1;
> > +     init.flags =3D 0;
> > +     init.name =3D "hdmi_pclk";
> > +     init.ops =3D &phy_clk_ops;
> > +
> > +     phy->hw.init =3D &init;
> > +
> > +     phyclk =3D devm_clk_register(dev, &phy->hw);
> > +     if (IS_ERR(phyclk))
> > +             return dev_err_probe(dev, PTR_ERR(phyclk),
> > +                                  "failed to register clock\n");
> > +
> > +     ret =3D of_clk_add_provider(np, of_clk_src_simple_get, phyclk);
>
> As per my v8 review, this function is deprecated:
> https://elixir.bootlin.com/linux/v6.8-rc4/source/drivers/clk/clk.c#L4881
>

When I found out that the entire driver I pulled was the wrong
starting point, and noticed that this version had very little in
common with the previous one, I didn't review the feedback knowing tha
tI would have thrown away any of the tags from it since it was such a
drastic change.  I should have caught it, but I missed it, so
apologies for that.  I will be sure to include this feedback in the
next attempt.


> However:
>
> [Tested using Avnet MSC SM2S-IMX8PLUS SoM on Avnet MSC SM2-MB-EP1]
> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Thanks for testing.

adam
>
> Luca
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com