Received-SPF: pass (google.com: domain of linux-kernel+bounces-65198-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240210204606.11944-1-aford173@gmail.com> <20240210204606.11944-5-aford173@gmail.com>
 <20240214121517.54552a4a@booty>
In-Reply-To: <20240214121517.54552a4a@booty>
From: Adam Ford <aford173@gmail.com>
Date: Wed, 14 Feb 2024 06:36:36 -0600
Message-ID: <CAHCN7xLnXMZJkTjWBP5HW0h2-bUOyeNEL2oO0rnV5tNaz9Hv7A@mail.gmail.com>
Subject: Re: [PATCH V4 4/6] arm64: dts: imx8mp: add HDMI irqsteer
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: linux-arm-kernel@lists.infradead.org, marex@denx.de, 
	aford@beaconembedded.com, Lucas Stach <l.stach@pengutronix.de>, 
	Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, 
	NXP Linux Team <linux-imx@nxp.com>, Catalin Marinas <catalin.marinas@arm.com>, 
	Will Deacon <will@kernel.org>, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 14, 2024 at 5:15=E2=80=AFAM Luca Ceresoli <luca.ceresoli@bootli=
n.com> wrote:
>
> On Sat, 10 Feb 2024 14:46:00 -0600
> Adam Ford <aford173@gmail.com> wrote:
>
> > From: Lucas Stach <l.stach@pengutronix.de>
> >
> > The HDMI irqsteer is a secondary interrupt controller within the HDMI
> > subsystem that maps all HDMI peripheral IRQs into a single upstream
> > IRQ line.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > V2:  Add my (Adam) s-o-b and re-order position under AIPS4
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boo=
t/dts/freescale/imx8mp.dtsi
> > index 0730d4cf9bc4..9b8ab367d774 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -1927,6 +1927,19 @@ hdmi_blk_ctrl: blk-ctrl@32fc0000 {
> >                                                    "hdcp", "hrv";
> >                               #power-domain-cells =3D <1>;
> >                       };
> > +
> > +                     irqsteer_hdmi: interrupt-controller@32fc2000 {
> > +                             compatible =3D "fsl,imx-irqsteer";
> > +                             reg =3D <0x32fc2000 0x44>;
>
> The last register being at offset 0x44, this should be <0x32fc2000
> 0x48> or even <... 0x1000> as the TRM mentions a 4 kB size.

I'll do 0x1000 in the next revision to match the documentation since
there doesn't appear to be any overlap.

adam
>
> [Tested using Avnet MSC SM2S-IMX8PLUS SoM on Avnet MSC SM2-MB-EP1]
> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
>
> Luca
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com