Received-SPF: pass (google.com: domain of linux-kernel+bounces-65230-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <8a580aad-001c-4e88-8f56-271f1835e581@linux.intel.com>
Date: Wed, 14 Feb 2024 14:55:09 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 0/5] DesignWare PWM improvements
Content-Language: en-US
To: Raag Jadav <raag.jadav@intel.com>, u.kleine-koenig@pengutronix.de,
 mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com,
 lakshmi.sowjanya.d@intel.com
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240212130247.9985-1-raag.jadav@intel.com>
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <20240212130247.9985-1-raag.jadav@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2/12/24 15:02, Raag Jadav wrote:
> This series implements 16 channel PWM support for Intel Elkhart Lake
> along with minor cleanups for DesignWare PWM driver.
> 
> Changes since v2:
> - Remove error code duplication from dev_err_probe()
> - Update tags
> 
> Changes since v1:
> - Drop redundant error check
> - Provide dwc_pwm_init_one() to initialize one PWM instance
> - Use dev_get_drvdata() instead of pci_get_drvdata()
> - Use pm_sleep_ptr() instead of use pm_ptr()
> 
> Raag Jadav (5):
>    pwm: dwc: use pm_sleep_ptr() macro
>    pwm: dwc: drop redundant error check
>    pwm: dwc: Add 16 channel support for Intel Elkhart Lake
>    pwm: dwc: simplify error handling
>    pwm: dwc: access driver_data using dev_get_drvdata()
> 
>   drivers/pwm/pwm-dwc.c | 59 ++++++++++++++++++++++++-------------------
>   drivers/pwm/pwm-dwc.h |  5 ++++
>   2 files changed, 38 insertions(+), 26 deletions(-)
> 
I tested on Elkhart lake this patchset and it adds another 8 channel PWM 
instance and the PCI device continue switching between D0 and D3 power 
states depending is some channel enabled or all idle.

Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>