Received-SPF: pass (google.com: domain of linux-kernel+bounces-65260-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 14 Feb 2024 13:17:12 +0000
From: Mark Brown <broonie@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Kent Gibson <warthog618@gmail.com>, Alex Elder <elder@linaro.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 0/4] gpio: fix SRCU bugs
Message-ID: <4c629a0b-95ff-4ad6-af04-61b25d437f89@sirena.org.uk>
References: <20240214084419.6194-1-brgl@bgdev.pl>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PHKFQMsyP2YjnSWd"
Content-Disposition: inline
In-Reply-To: <20240214084419.6194-1-brgl@bgdev.pl>


--PHKFQMsyP2YjnSWd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 14, 2024 at 09:44:15AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>=20
> Here are four fixes to some bugs in recent SRCU changes. The first one fi=
xes
> an actual race condition. The other three just make lockdep happy.

This doesn't fix the issue I reported yesterday when applied on top of
today's next:

   https://lava.sirena.org.uk/scheduler/job/585469

[    1.995518] Unable to handle kernel NULL pointer dereference at virtual =
address 0000000000000078

=2E..

[    2.176162] Call trace:
[    2.178610]  check_init_srcu_struct+0x1c/0xa0
[    2.182974]  synchronize_srcu+0x1c/0x100
[    2.186904]  gpiod_request_commit+0xec/0x1e0
[    2.191183]  gpiochip_request_own_desc+0x58/0x124
[    2.195894]  gpiod_hog+0x114/0x1b4
[    2.199305]  of_gpiochip_add+0x208/0x370
[    2.203232]  gpiochip_add_data_with_key+0x71c/0xf10
[    2.208117]  devm_gpiochip_add_data_with_key+0x30/0x7c
[    2.213261]  mxc_gpio_probe+0x208/0x4b0

--PHKFQMsyP2YjnSWd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXMvVgACgkQJNaLcl1U
h9DroAf/eoRSfe3T0pX2R2UAPt8d7/BSID9HbANJ6umEl9wiMdKWZLXBBle0rNVJ
/GXxwUVieNoywwrzqFjXXVeYkT889xYplvblstaBjiFl0W2FpM+ab09bhIuF/7Vc
SyN0fDZ9uxPZZBNboXagkMIL2+lTdGAPWZSfABNM+HUPiQBhLU3XxBbYS1KqB0XC
RlifSVRr9K0FBN7Wws/u2qNRt0deopzIKXSDyiZLYjCmoYLrUTV3VyGYQK0vOoX7
oit/bnXUgIo9s4Td0tebiRxke7JtX3avSnlBPG2Urr5+r3/kFRMfaBPWifXtuvay
CkzYCKvSBl8H9nmicCjCZzyY6CMpdQ==
=bF5W
-----END PGP SIGNATURE-----

--PHKFQMsyP2YjnSWd--