Date: Tue, 25 Dec 2007 09:25:56 +0100
From: Ingo Molnar <mingo@elte.hu>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
       Linus Torvalds <torvalds@linux-foundation.org>
Cc: travis@sgi.com, LKML <linux-kernel@vger.kernel.org>,
       akpm@linux-foundation.org, suresh.b.siddha@intel.com,
       venkatesh.pallipadi@intel.com, Yinghai.Lu@Sun.COM
Subject: Re: volanoMark 24% regression in 2.6.24-rc6: why a simple patch
	makes it
Message-ID: <20071225082556.GA26342@elte.hu>
References: <1198559645.6362.195.camel@ymzhang>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1198559645.6362.195.camel@ymzhang>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 939
Lines: 24


* Zhang, Yanmin <yanmin_zhang@linux.intel.com> wrote:

> The solution is just to revert patch 
> fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, because other 2 patches 
> which fixed the same issue are already in 2.6.24-rc5.

Linus, please revert fbdcf18df73758, as requested by Yanmin. It was 
noticed before (by Yinghai Lu) that this commit was not needed, but it 
looked a harmless duplication and we incorrectly thought it's only a NOP 
and wanted to fix it in v2.6.25 - but as Yanmin has analyzed it now, it 
creates a sub-optimal sched-domains hierarchy (not setting up the domain 
belonging to the core) when CONFIG_X86_HT=y.

Acked-by: Ingo Molnar <mingo@elte.hu>

nice work Yanmin!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/