Received-SPF: pass (google.com: domain of linux-kernel+bounces-65324-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 14 Feb 2024 14:13:11 +0000
From: Mark Brown <broonie@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, lgirdwood@gmail.com,
	quic_fenglinw@quicinc.com, quic_collinsd@quicinc.com,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: qcom-rpmh: Fix pm8010 pmic5_pldo502ln minimum
 voltage
Message-ID: <dcce3fa9-ecf3-42be-adf6-ca653a79ba2e@sirena.org.uk>
References: <20240214121614.2723085-1-bryan.odonoghue@linaro.org>
 <13baed68-1014-4a48-874a-94027a6dd061@sirena.org.uk>
 <f38468b4-8b16-4180-9738-0a2b557651a1@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="vLUCGveXzK8CcVf7"
Content-Disposition: inline
In-Reply-To: <f38468b4-8b16-4180-9738-0a2b557651a1@linaro.org>


--vLUCGveXzK8CcVf7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 14, 2024 at 02:07:13PM +0000, Bryan O'Donoghue wrote:
> On 14/02/2024 13:25, Mark Brown wrote:
> > On Wed, Feb 14, 2024 at 12:16:14PM +0000, Bryan O'Donoghue wrote:

> > >   	.voltage_ranges = (struct linear_range[]) {
> > > -		REGULATOR_LINEAR_RANGE(1800000, 0,  2,  200000),
> > > +		REGULATOR_LINEAR_RANGE(1808000, 0,  2,  200000),

> > This will also offset all other voltages that get set, is that expected
> > and desired?

> Yep, looks typo in the original submission.

> ldo3, ldo4 and ldo6 should all be 1.808.

Not just that but also note that every voltage step in the range will
have the 8mV offset added.

--vLUCGveXzK8CcVf7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXMynYACgkQJNaLcl1U
h9DLuQf/Z0YYpkjqyW5+exh6l/SA5rqqrxawOT0BgtGEljrdTuxUknHpS4UAuWTb
KAQNpzO5dh9HNHFjUbeaRb5H1Dqqmr8WohegUr1+sntz1aj3VSk29SOSMiQKgYWi
18R6b8hPxOyWUT0Bzg67PxYaXFLpOguH/0R3ZKrTWOWemGT/m5xxvuq84OVWHyHM
5TC6CrqiACcEVSsiJM832GZzkEpSXjkXMZRRTrmgscDNEpp1qjVIpJ5Jb92IGmrb
QSk8cq4koap9Ex/+ctmUCBvS59c8tpPL/Jum51UawfChocAoRnC2oTzMWPm2OkkK
bCxeJZsiXiiV5yxGJJNZBCwfZqBJIg==
=0gZW
-----END PGP SIGNATURE-----

--vLUCGveXzK8CcVf7--