Received-SPF: pass (google.com: domain of linux-kernel+bounces-65329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <d01ef2f5-10d9-410b-a6ec-d5eca05ffda4@amd.com>
Date: Wed, 14 Feb 2024 09:19:13 -0500
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, tony.luck@intel.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, avadhut.naik@amd.com, john.allen@amd.com,
 muralidhara.mk@amd.com, naveenkrishna.chatradhi@amd.com,
 sathyapriya.k@amd.com
Subject: Re: [PATCH 1/2] RAS/AMD/ATL, EDAC/amd64: Move MI300 Row Retirement to
 ATL
To: Borislav Petkov <bp@alien8.de>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-2-yazen.ghannam@amd.com>
 <20240214083623.GZZcx7h_BcIWpoEmMJ@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240214083623.GZZcx7h_BcIWpoEmMJ@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WCtZc045R1FJelNYRytlQWVqZE1IZmo3dkhNOTZrNXlZaWdFNGtoVFZNS3Ex?=
 =?utf-8?B?TEtBTTFFZlVjenVxWFpmMU9VU2YzQms2dDd3azRCOWxXRm5wdTB3OXB4Yzd5?=
 =?utf-8?B?WHlaN2FzdlIyZXhuUVBVOTBTNUo3bVQ2cytxL1E2akZpeStmcHBiczJLbVBo?=
 =?utf-8?B?dG5CM2ZGb3huS2NLaUpVWmN1WUt5bXljZDBINFFBbjlqbHB0OHJzUVd1UDc3?=
 =?utf-8?B?bU9wL2g4Q1pjOXMrUWVyc2dZbVh6ZUdRbk9Ecm1OOUJHZ1daZjNvbW53bVNT?=
 =?utf-8?B?ak1BeXVMZ2JMcXVUeTZwWUFudTZFRmNURytTckY4eGJoY1JoREtwUHpvUFFT?=
 =?utf-8?B?T0phUTBuYkJZT3IydGZ5Skpibjk5M2ZsREwvUnJZb2poYmlBaE01SVcwaWJQ?=
 =?utf-8?B?TjlxR1hFWURpTkczdzdjbzNERUtFS2IyU2VFMStFKzU4Rm91TnF5UnB5TTNs?=
 =?utf-8?B?NWJvQUhQa2k3dzQ2UzlMOG41RHNnZ0pBTVpqUzRrRncwR3g3aDQ3U3Q1a3V4?=
 =?utf-8?B?R2p4TVdQaHNHRlV6RGNxOFArc0I5SW9CNW1YblJUb0srR09kSEdHcTNJM2tn?=
 =?utf-8?B?d21LMEdaUjdGVUV1TUh6eHYvRHh2YlZFRmcra09Ud2p3QUZWV2pqY2lyL1Rq?=
 =?utf-8?B?UDRMeFhLVWVUSHJwOFo4M0ViSk5zS0VUZmRud3JvdFpWaGQ2MVdYL2gwMjk0?=
 =?utf-8?B?SzJWM3BIMkIzYTJFWjRTSVdxMnhCbkRodjJkVkFGWDdxaUpKMXYwbzN5dTNz?=
 =?utf-8?B?Q0lhYnE4c0FSZFl3VnQwMWRMLzdVM2p0ek1Hc3hrVDNqeXg3bjQxL2xYWS9y?=
 =?utf-8?B?cE03K2xtZDNMam5ETUpNQ05jOFJCYUZPWWt5RGJGQ3hRMnp1YjlHbTRHdVF3?=
 =?utf-8?B?TzNjRGZ2cDlJa1NxdXdHVnU1c0V3V0xRK0dMUnNoZGo3bUJhZVpGSjFlb1JI?=
 =?utf-8?B?M3Urak8yaG1UaVRjM3M0bkNXTnRSME9pN2UyQjNYZ2xxUDlWcU5veG42NDA3?=
 =?utf-8?B?MHN6a2dHcHpreEt6Ulg2WUw1SU42V2ZDSHhiQW40SXBCT3JBZE81N0pWdXNR?=
 =?utf-8?B?RjV0RWdsT0ExbmQvZmRvVmh4NCtLRUltM2kvT1BkQ0tsRHR0bEEvM1U3a2sv?=
 =?utf-8?B?RjdPWTMvWHIrWllTTVUzKzdmeFVTVFVMdTVKSXZPVmpWZzlkRnhVT1czZ1lM?=
 =?utf-8?B?QlVsaWVqMURZYUwvTDV0OGpldTQwM0kwcXNLYWdvSlpRcyt5K1hPVTN3L3ZP?=
 =?utf-8?B?UjI4dkxMZXVaKzlZRkZnUXdEN3l0eGhoN2xxZjZBenRMWlE2Lzh2anFIajFR?=
 =?utf-8?B?UERNZmIxUUpaU0JpQlF4cTU4VkZYdTV1NW1yWVp5WHh0ZzBnQmxjTWJOVDdO?=
 =?utf-8?B?VExlUDJrRzRLL3RwSmFFazB5RVd1ZFBnWkJTdDZIYU5SOWVOZ2VSQkVka0hy?=
 =?utf-8?B?eHUrb3pna0t1WEc1OWVvNytDYzdmZkx3RzNxdEVjVDlPbXE5RGxWdUNOdlkr?=
 =?utf-8?B?R3VFU25MNGc0N3QzTWRCd3VDS2Q1ZWxWdWplNDRiRVRLdC8ySE9pMkUxd20y?=
 =?utf-8?B?N3I2a1QyWUFBbnNBYldnT0ZoOVdDRXVQT0tKakg0QWZ6UkFRMHo4ZUNxa1ZN?=
 =?utf-8?B?TFdMUWxTOEhJYTVCQUQrTXloaW5NRk1YaFpTNVRBUzJmQVMzWmoyT2VoNVdp?=
 =?utf-8?B?K1k0djd0NGtXMGNFZm1zcUFiNEg2Y05rKytTU1A5cWRqMlpxZkl2UTJHeWZQ?=
 =?utf-8?B?NHo0ZGFLMDJUdFZtZVpYU2JibjMzNW91MFRKN21NMi9vTm9wWjF0QnhuNVBU?=
 =?utf-8?B?Zk52VDc4VWdLTXl6OEJqRllkUlRMOVdqbG4rZWlhNzc5NmtnT3pIN2ZJQXJP?=
 =?utf-8?B?cG1aT1hXbXBRSzFzTXdzQW1aeUg2REtnenV2L3dyOEJYeTZydS8yQzYyb0ll?=
 =?utf-8?B?b3NiWGswWnVYT0Y3WG1rSGNNMTVoRWJnYndzTmtzMGwwTmV4TTRNS2Z1K0pk?=
 =?utf-8?B?TlM2VC92a0xuN2VsTlh5UUVDbVlaWDlTQnIwSjkxb0gyR21JVEpyaW42b0RC?=
 =?utf-8?B?dnJRK2ovUGdWOWt4SURvWXVrakllZXFTajVyQlhyV3gzODQzTXFONThHN1ZY?=
 =?utf-8?Q?vkdvkLgKbZh2r/RNJApD6kgMb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8268eac1-4425-4db6-460d-08dc2d67ecca
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 14:19:16.0987
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qt0aoEL9roNLv35AZFenGnDpOAUJjECCmbKVm40xHeBm1O6KFDqeTr470lJxIsDqz3MEdEQJaIqoZoaLy9XYTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6011

On 2/14/2024 3:36 AM, Borislav Petkov wrote:
> On Tue, Feb 13, 2024 at 09:35:15PM -0600, Yazen Ghannam wrote:
>> DRAM row retirement depends on model-specific information that is best
>> done within the AMD Address Translation Library.
>>
>> Export a generic wrapper function for other modules to use. Add any
>> model-specific helpers here.
>>
>> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
>> ---
>>   drivers/edac/Kconfig        |  1 -
>>   drivers/edac/amd64_edac.c   | 48 ----------------------------------
>>   drivers/ras/amd/atl/Kconfig |  1 +
>>   drivers/ras/amd/atl/umc.c   | 51 +++++++++++++++++++++++++++++++++++++
>>   include/linux/ras.h         |  2 ++
>>   5 files changed, 54 insertions(+), 49 deletions(-)
> 
> So basically I can zap:
> 
> 8be4984891e0 ("EDAC/amd64: Add MI300 row retirement support")
> 
> from
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/log/?h=edac-amd-atl
> 
> and you can send me a patch which adds the row retirement straight to
> the ATL?
> 

Yes, that's fine.

Thanks,
Yazen