Received-SPF: pass (google.com: domain of linux-kernel+bounces-65356-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3851e21f-f8cb-487b-9ed4-9975949ff922@linaro.org>
Date: Wed, 14 Feb 2024 14:44:56 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] regulator: qcom-rpmh: Fix pm8010 pmic5_pldo502ln minimum
 voltage
Content-Language: en-US
To: Mark Brown <broonie@kernel.org>,
 Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, lgirdwood@gmail.com,
 quic_fenglinw@quicinc.com, quic_collinsd@quicinc.com,
 linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240214121614.2723085-1-bryan.odonoghue@linaro.org>
 <13baed68-1014-4a48-874a-94027a6dd061@sirena.org.uk>
 <f38468b4-8b16-4180-9738-0a2b557651a1@linaro.org>
 <dcce3fa9-ecf3-42be-adf6-ca653a79ba2e@sirena.org.uk>
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <dcce3fa9-ecf3-42be-adf6-ca653a79ba2e@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 14/02/2024 14:13, Mark Brown wrote:
> On Wed, Feb 14, 2024 at 02:07:13PM +0000, Bryan O'Donoghue wrote:
>> On 14/02/2024 13:25, Mark Brown wrote:
>>> On Wed, Feb 14, 2024 at 12:16:14PM +0000, Bryan O'Donoghue wrote:
> 
>>>>    	.voltage_ranges = (struct linear_range[]) {
>>>> -		REGULATOR_LINEAR_RANGE(1800000, 0,  2,  200000),
>>>> +		REGULATOR_LINEAR_RANGE(1808000, 0,  2,  200000),
> 
>>> This will also offset all other voltages that get set, is that expected
>>> and desired?
> 
>> Yep, looks typo in the original submission.
> 
>> ldo3, ldo4 and ldo6 should all be 1.808.
> 
> Not just that but also note that every voltage step in the range will
> have the 8mV offset added.

The documents I have just show sensors attached to ldo3, ldo4 and ldo6 
fixed at 1.808.

I don't think there's any better or different information than a 
+200000uV increment TBH.

---
bod