Received-SPF: pass (google.com: domain of linux-kernel+bounces-65361-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3bc7bef5-9cfc-400a-a1ba-99ebf5d94952@amd.com>
Date: Wed, 14 Feb 2024 09:46:46 -0500
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, tony.luck@intel.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, avadhut.naik@amd.com, john.allen@amd.com,
 muralidhara.mk@amd.com, naveenkrishna.chatradhi@amd.com,
 sathyapriya.k@amd.com
Subject: Re: [PATCH 2/2] RAS: Introduce the FRU Memory Poison Manager
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-3-yazen.ghannam@amd.com>
 <20240214103446.GDZcyXRkyf1bFzMh7L@fat_crate.local>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240214103446.GDZcyXRkyf1bFzMh7L@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bGZEYVB6K21oa3hNZzQ2eEZHVno4MmdsdlF0UGZtRjRpZU4vc2dJOXZYODZm?=
 =?utf-8?B?SnNEaUR6cnUyLys2RzB2ZllaUThMa0NoZVdsbjFHOVB1RnZUN0xqbDVMQ21D?=
 =?utf-8?B?dEg3L08xOGhkbG9KNFROQ1VtSVFWVXJDRjFYZzM4T1BlRzQ5d0J5OXdDWjdK?=
 =?utf-8?B?UG5TRVNTQ1VHNFZFVWhyeDJTTm9zeDk2VHhGKzRhekZsSHl5VlJvSnRsMFdo?=
 =?utf-8?B?YTZ4b2xiMDFPallKeUl1cWZZbzRhZG1uaWxzdmpPakplVzF0S1d3dllvYVEz?=
 =?utf-8?B?RU45elY3TUtZNG9raU1sL3h2Z3ZId0N0YTl0V2k5akNnSmh0MEpQS09PVGcx?=
 =?utf-8?B?ckJkTjZSaTNubGs0U1hFQVlMSHBrY3NrckVVR2gza0J4RFI5V2pSMWNEY2E5?=
 =?utf-8?B?azI1RmRWWmpIeVdadGVMYmZYLy9xdzNIdTg2ZWtSMFQ2bFg0SWREdXN3czF4?=
 =?utf-8?B?UzN4c0FXbElsUzBsTXZXaEJhWWNuZ2dmaTZJZkhpR3AyZEsvMXR6Njh1NmVD?=
 =?utf-8?B?aWhyVlJOWkJVd0NkaFowbGtxaWtVakFFTTNUR1libGhTVUIvUlhxMTY0Ynh5?=
 =?utf-8?B?S1hMVitPN3RqTzVLMGVMeFhBNWR1a1liY0s1ZHJwY21icVNCKy9SelZqK28y?=
 =?utf-8?B?eHRTQVJZVkVIbkVGQnlSYnNmMm9xeFV6VVg2NEVkVHh1UEFmdGNlcDVkelQv?=
 =?utf-8?B?YzVhc2d0M0k2L2dHbHcyUjQ1QXBCZFNZb2s3ZzMxM1FEcHcxTjcxa0h4S0VG?=
 =?utf-8?B?anJobFhRbEloMk5HYUFjK2lTQzhSbjZpSzNSS1BxcHA2em0rUTI2QkJ4aHhM?=
 =?utf-8?B?S1dPMjNaamxjeFp2QlBKY1FmRW9iUGhON29BRFhjZEozU05aVFpnbEljdWtn?=
 =?utf-8?B?elE1dklPNGZEZ1p1TkhabGN5K2FCOGdxOEp0elhYaXpzeE9kanpBUGMrM29p?=
 =?utf-8?B?eERCWnRiZk5Ub0pvYkxvR3lYUC9WNGNFaCtnYWNweXFiOHRLcS9oWitaa2wx?=
 =?utf-8?B?V0ZwY0FtRmpNTGYva2VpZjlYbGZVMktMM3I5NGF6M2pIVkdubmpkSGtjc0Zj?=
 =?utf-8?B?ZHgvd2N2UjJPeTlpY1FpbjErdlQ3TDZ2aS9Kc0hwVDZEVDFpL2Q1Uzllb0JL?=
 =?utf-8?B?Szg0clpZNkhFOXJxQ2Z5OXg0R25sRUxlTGxhR3Z3QlROZU5aVXZRUG5EdjdJ?=
 =?utf-8?B?NzZaY0NCaVlEaDJia0VFb3JXWWVxWDg3eDdaTkRFYmozTnRHZGtUbi82MmNN?=
 =?utf-8?B?TmpUYy9aTDIwT1gxcHZkOWZHMllLdEo0OExydVg3U2pRMTVPaFNyWWhHejVr?=
 =?utf-8?B?OGR1SUJTSEFSeVJjbEQ4MHkrTFVHZHFkSWh5V011RHlvWGE0NWF5WGRWSTRC?=
 =?utf-8?B?R2pQbUlEVUNWNFM1MjdPcjRMSHRUL3NsUTJ4MkhOOCs4b2czQ1ZVZ1VtSHNE?=
 =?utf-8?B?UVBOcjRSdWxWZUl6L2tqaENBTktEcFFIamg0NElUSXhETEtZRWdHSUppbnl1?=
 =?utf-8?B?ZU9lakhwZ1ZiQjg5RERKQkJhbTRDMjVhd3g5ODJqeUVhY2NwRDVOTEtxS0Za?=
 =?utf-8?B?T3NZN2tFZC9qMWcycSsxeCtiNWhkenJVNHliZ2dIT2xnMjRGSmpVL1lMQ216?=
 =?utf-8?B?dkZGSXUwT3RVMWU0dEZYQW9EdGRhUkx2NU9MSWtoUFdwYWtaRG15NzJ2QkpN?=
 =?utf-8?B?SHpoeGl0d2ZlRWRCOTZRVk8yVVp1Q3VJTDREQXdCeEQ3N05LRUtIZ0hEZzFS?=
 =?utf-8?B?eUVmODBvRHVkRDJuRkExZ1FsaXN1cG1IKy9sWVY2blJqdFdoaVEwSjNWOW1K?=
 =?utf-8?B?K05WWlFFK0ZQdFhISitXcURUQ1hXZEZtQlNZRWZBVDJtUkQ3TjRkMmhFeE8v?=
 =?utf-8?B?VUFqU3A1Tnp3MjVxNEd6djgrbC9WYks0NXV3dFpyZUc0b1NqRXptTkxiOVF4?=
 =?utf-8?B?MWphaHNIeklDRHI5MEdVYzBmSW1LditNTmZTL1pob1hwYVNuTmE2ZE11OHA5?=
 =?utf-8?B?aVV4dlNIUzJ3K1czWlk0L1FQTE9pazlVWVVhMytHMURwWnpEd1gwTnRTRXhU?=
 =?utf-8?B?UmpiU3cxaUJVZ3BpZ2Riak1pbE83Wm91bk8rZUlZRjZqaVYzSHBXM1pEaFhy?=
 =?utf-8?Q?PLLJiEDskP46YRAhBNcV9vKh7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b2a00e7-62ba-4426-8518-08dc2d6bc4f9
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 14:46:47.0133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fGeO62RsEIFxqFcPTNaYxa2+yxKV6ROOzNeS4NjzeBhCFPrrzAhDjngPp2myQtpJ/XCPEJwxhjPgTQ/g2rKvEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7633

On 2/14/2024 5:34 AM, Borislav Petkov wrote:
> On Tue, Feb 13, 2024 at 09:35:16PM -0600, Yazen Ghannam wrote:
>> +#include <asm/mce.h>
> 
> ...
> 
>> +static void init_fpd(struct cper_fru_poison_desc *fpd,  struct mce *m)
> 								^^^^^^
> 
> 
> This is a generic thing and thus can't use an x86-ism struct mce,
> remember?
> 

Yep, that's one of the assumptions/limitations I highlighted.

Thanks,
Yazen