Received-SPF: pass (google.com: domain of linux-kernel+bounces-65370-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b1007e63-6c86-4e24-aab6-b0a08acaf7ef@amd.com>
Date: Wed, 14 Feb 2024 09:57:44 -0500
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, tony.luck@intel.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, avadhut.naik@amd.com, john.allen@amd.com,
 muralidhara.mk@amd.com, naveenkrishna.chatradhi@amd.com,
 sathyapriya.k@amd.com
Subject: Re: [PATCH 2/2] RAS: Introduce the FRU Memory Poison Manager
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-3-yazen.ghannam@amd.com>
 <20240214111032.GGZcyfqFqsW0j4Yy3a@fat_crate.local>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240214111032.GGZcyfqFqsW0j4Yy3a@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YzNRN1BRVXNkNHd4RFRpUDA2cEFHbVVqRTJ0aC81MzBuSWg3TGFocTFCWFlQ?=
 =?utf-8?B?eWZCcDZWb2NZTmNySmY1c01JaVkyc2Y3UFYwZkFnSExhVGJXYnFrdWVIQWhT?=
 =?utf-8?B?bjBrNDNzYmtpWXRUaTVHRDg5NEJNbDFpTkZHNHRZS1VaOFVEUG9ucCt2NWl6?=
 =?utf-8?B?MXhIV0U5Ny9IbFFhbjVlZzBpQWxKVW0vdEg5K2JnSHFVV3N0b0g5VHFwTG1B?=
 =?utf-8?B?TzRGRnY0Ni81OWU2eDNBM2Q5VHN2eXdQK3VKckU5SUlBNGtQZWxneFptNXl1?=
 =?utf-8?B?MVlmdExZeFZSWmZLWllGSkk1MTRxVmx4bkFEREg2dE9JUEkzc0M2QnVlU0lh?=
 =?utf-8?B?eng0SmlxNVpNdHlSS3NMcmNvWGJrMXN4TEJ1RGxpVkh2V3h5WDZ6dmJ6UWZh?=
 =?utf-8?B?WHFSU2h4S3lFdzVDdXJRZ3hweGhzZEVGbm5wVUFmZS9uNmZNZ2M2WkR1Mno1?=
 =?utf-8?B?NkdZUWVwMHF5clY2bEdzNkNhRUR1MFZTRGYxT1cvYzRXSjRldmg4WTBRZUY4?=
 =?utf-8?B?YlZvTjgxUUlRT09hc1NZc3J6czlVaWlvcjV3OFBHN1F1dWRpNUp1eFdPVGd5?=
 =?utf-8?B?U3VNRjBsejc1WE5sYWp2WVVYM2QvOXhqNVBXSWg3SWd6UmlrUlN4UkgwMEJD?=
 =?utf-8?B?eWNoclcwdFdQNTFxTDFZMWNEc21FRXlqa0p3SldLcVRwSDJGb1p6NGZGWWxp?=
 =?utf-8?B?bEtRYVJBZlBTaEhsOEJVZUMwMnB6ZzYzaW1sQ2wwd2JvQmZvcEhFeVplSXp4?=
 =?utf-8?B?bEQ1Ukd4dHhSYUtMRnZYOUI3R1JiMERWUXlYdzllNTN0eWk5QXRmN3pJdnQ5?=
 =?utf-8?B?c2hGWjk4YkxLUWd0VmlBN3VHTEl3eXVRcXRuelRjZzJyQmt0R1RHeE1zTjJH?=
 =?utf-8?B?U0xQVi9MbG9JS2gyS3UwbkM4NFVyYXh1enhaZkJtSUVYbWpyRGV4aWM0b0xC?=
 =?utf-8?B?T1dPUXROYW9FM3djTVhJQ2U4QmY5bGxVV1VuTHU5dGtSdW9mOVROMUNHWVNM?=
 =?utf-8?B?L0FyNVI3L0t3elB6bjhseDdldlcrQmtSdnR6amdINUYycDd5cDFlSHd5bmRn?=
 =?utf-8?B?RUtjS1RLZzRUTFFHSVlidjdyc3FuWUtiUFpnUFNobWtEMmxQV0NIZWZ1MHYx?=
 =?utf-8?B?MXZRUTJKTEg2WlpkaFV5bUROY0FyU2V4WHU1YUJlTnpmdGtSc2k1Wnk5M3BC?=
 =?utf-8?B?UlZNYTJRNkxkbHY4N1daWVFWTEFtaEdiUkIyd1ZqRCtHenM0V2dLUHBvZHRW?=
 =?utf-8?B?K05lbjVEdWgwWFcycEcrK010YlhXM2VsS2cvelpuMzZiUjVUU1pnT3Bsb3Zr?=
 =?utf-8?B?SERmZ0RsNUxKSFIzVXVWUHZkWFd5ZWN3Z21JN2FrMitaNmhhemZkRUxlelNt?=
 =?utf-8?B?Rk5pZzZTRnhXYmVLTi91MHBtVDlJa2RiZkE1TW5MeUI1Y1FITUZabEdvRzdi?=
 =?utf-8?B?UFd6U25xWVVrWjVtRDlHeThnaFlBenFkazJRZG1uY2loWGFyeU5UM3pNQWdh?=
 =?utf-8?B?SC9aUXFnWEtXeTVrTWxCRm5jMGlNOXlNeDRKZ3B0bCt0ZUQwcThqanpTZnM2?=
 =?utf-8?B?akdsNGhCb1Mrbi8yRTNWcjRpbnlYVUxpWTVwanA2MFdTa09HY3RZV2ZlanBm?=
 =?utf-8?B?WkZJRWJ5eHhhYzczd2gzRFEweXRXTW4xZERKdHJ0SHphWkg1MGY4bnRoeCtl?=
 =?utf-8?B?MmFxdVBrM0FTTEI4ZHo0ZXcxUEYxOXlISUtSQzFFV1FsbHNBRFZtZFJQQU9p?=
 =?utf-8?B?V2NtaXQrWi9CTnVuTzRDandlazRkTVpTNTZ1SXRKV0MwMDZ3d28wenoyNms2?=
 =?utf-8?B?L2g1UW52R244NmI4NUJKTWZjQXdlNVdDV1ZTQWttVi80Zi9YekY1eWVOamlo?=
 =?utf-8?B?WnZJRWE3UHdTTmRvNm9YQ2taczQ1SUlUN09VVDBpQ3cwbWJEbEgxeW1nUXpK?=
 =?utf-8?B?c0lzc2wyQkNlNFR2bTVBM3ZLY1ltei9VNEloRXcybTZHTTR4R0c5MDdwM0dI?=
 =?utf-8?B?dGxlTDFzUnRISThHUk1xTG9rZ1ZYYjFkdFR6cDZXOVNKOG1kZHVUSllTem9w?=
 =?utf-8?B?OXFXWUtoZGYwaVIvZ3NyZHdHVWMyTTF0Z1BENXBmemFBNFM4ZVFIaitHTU1t?=
 =?utf-8?Q?7qh+liUrbPFSYBewUpdQWcAwB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36437493-9137-43ce-f5b2-08dc2d6d4ce5
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 14:57:44.5628
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +oXhB/qJhhVcby0vnyv1yeS0xCvRrqmDm/EW/oR9p+fCxP/X7TMzUxjFQC/5MzWQ0ROr9djnrZyzzP9yodfb1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7376

On 2/14/2024 6:10 AM, Borislav Petkov wrote:
> On Tue, Feb 13, 2024 at 09:35:16PM -0600, Yazen Ghannam wrote:
>> +static void init_fpd(struct cper_fru_poison_desc *fpd,  struct mce *m)
>> +{
>> +	memset(fpd, 0, sizeof(struct cper_fru_poison_desc));
>> +
>> +	fpd->timestamp	= m->time;
>> +	fpd->hw_id_type = FPD_HW_ID_TYPE_MCA_IPID;
>> +	fpd->hw_id	= m->ipid;
>> +	fpd->addr_type	= FPD_ADDR_TYPE_MCA_ADDR;
>> +	fpd->addr	= m->addr;
>> +}
> 
> Get rid of that one:
> 
> diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
> index f8799beddcc4..090b60d269e7 100644
> --- a/drivers/ras/amd/fmpm.c
> +++ b/drivers/ras/amd/fmpm.c
> @@ -221,17 +221,6 @@ static int update_record_on_storage(struct fru_rec *rec)
>   	return ret;
>   }
>   
> -static void init_fpd(struct cper_fru_poison_desc *fpd,  struct mce *m)
> -{
> -	memset(fpd, 0, sizeof(struct cper_fru_poison_desc));
> -
> -	fpd->timestamp	= m->time;
> -	fpd->hw_id_type = FPD_HW_ID_TYPE_MCA_IPID;
> -	fpd->hw_id	= m->ipid;
> -	fpd->addr_type	= FPD_ADDR_TYPE_MCA_ADDR;
> -	fpd->addr	= m->addr;
> -}
> -
>   static bool has_valid_entries(struct fru_rec *rec)
>   {
>   	if (!(rec->fmp.validation_bits & FMP_VALID_LIST_ENTRIES))
> @@ -288,7 +277,13 @@ static void update_fru_record(struct fru_rec *rec, struct mce *m)
>   
>   	mutex_lock(&fmpm_update_mutex);
>   
> -	init_fpd(&fpd, m);
> +	memset(&fpd, 0, sizeof(struct cper_fru_poison_desc));
> +
> +	fpd.timestamp	= m->time;
> +	fpd.hw_id_type = FPD_HW_ID_TYPE_MCA_IPID;
> +	fpd.hw_id	= m->ipid;
> +	fpd.addr_type	= FPD_ADDR_TYPE_MCA_ADDR;
> +	fpd.addr	= m->addr;
>   
>   	/* This is the first entry, so just save it. */
>   	if (!has_valid_entries(rec))
> 

Okay.

Thanks,
Yazen