Received-SPF: pass (google.com: domain of linux-kernel+bounces-65362-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <34f22a20-8716-4ee4-82f9-b6dd42029a47@amd.com>
Date: Wed, 14 Feb 2024 09:49:18 -0500
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, tony.luck@intel.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, avadhut.naik@amd.com, john.allen@amd.com,
 muralidhara.mk@amd.com, naveenkrishna.chatradhi@amd.com,
 sathyapriya.k@amd.com
Subject: Re: [PATCH 2/2] RAS: Introduce the FRU Memory Poison Manager
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
References: <20240214033516.1344948-1-yazen.ghannam@amd.com>
 <20240214033516.1344948-3-yazen.ghannam@amd.com>
 <20240214105106.GEZcybGu7TkvKzutol@fat_crate.local>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240214105106.GEZcybGu7TkvKzutol@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cEd6MlFtT29WK3FYaUJwTVFpR05qQXJwZDNyNkMrbnplbU9taEJ5cVlJY3dD?=
 =?utf-8?B?aUozSDhFUGJVcldNdVhDWU5rVVg4OFBwOVFLT3lDQUtBcFQ2YW1OU3pGanJJ?=
 =?utf-8?B?bCt3ZmplSE1ZTDJWOU9lb1Z4TkZsanpsRWZHY2hPREZsWTMxVDdtaW1SQlU5?=
 =?utf-8?B?anpDWUluckdGeXhEcElHUmg1eVFWbGpCc3hQZ3pheXF4VXJZVzMyUVlwY1RO?=
 =?utf-8?B?ZGl5MHdKbVg2bHNTYThqQVZ4TC90TUloNmdKQUExMlJjOWR6OHJXcXhXYkpU?=
 =?utf-8?B?Q0p2dEVpREdRZmRqL2Z4R29iQUlMWnBjUm5udzB5SzdJT3Y2aFRhRFpmc0FY?=
 =?utf-8?B?UHZNNnpGT1kwSHh5Q0pibXhLSTViRGEzaGNHK01tWkVWanltM0RNOEthR24r?=
 =?utf-8?B?L3RBZytXRms3aFRjSXRRRmJSQTJtWHRBRDBTbFJVcThaVWo0S0pvZVU5Nlpm?=
 =?utf-8?B?ZG13MFNJd3hoOHhRdjdRcjlqSkd6YmM5L1plakFnWWRpQldlY083ODh1cEVN?=
 =?utf-8?B?amNaVXNPZGpWbHNrVE8zR3hnMy85WWJGcm5rSjdCN0RYOUNsdDdLYWkyWkxW?=
 =?utf-8?B?eEtDd2V3TmRnZ2daTkxXNkJrU1p0Y0dTSVVCSlA1bEpEcTB0dW1VZE1DbXNL?=
 =?utf-8?B?T0k2L3VFVG1TRVN5UVhFL2hUZmt0Y1lkbFZaWDVaMG9LU2RIeC9YczRUa2F1?=
 =?utf-8?B?K2YxTlFvenlPREhjblV3ckY5NzVJQ3VuVHk5Tk9HcVUwSk1pQVhlOXREVnZI?=
 =?utf-8?B?MURQWVZDZUdMdmVaS0VRWWlMaWdQVDVhbVd6dlc3YlhpWHduSjJKdWlhaFY3?=
 =?utf-8?B?OUxyODVZcVRtZ3hLUE51RWZ2cmpjQkxzZmJhM0ZzdkJNVnIrYWFqQnlBRlNL?=
 =?utf-8?B?M2FnMEJPYTZ4QnJQRm01RkhmYW42TjN1Wks4Z2hySElUM09UaU1VNHlneTN0?=
 =?utf-8?B?ZzYrdXNUVWVzaFU2bTByeGFZNWtFY3dFSU5aVm5Pc29CaHNhNXZUYUZGTUNu?=
 =?utf-8?B?a0JWUHRhd0REbGVuQlVxZmtqc3hZTnozL2pON0JNNkpUbk0zYjIvQWtyVTMw?=
 =?utf-8?B?dVlhQ1ZKWitsV0xKclluVHFQbGF5WVNVTTF0OEtBN2dKc1kxY1NEOHBKNjJQ?=
 =?utf-8?B?MDhwR1lsRjlFTHAwT0RWenFDNEpKMlpvaTNPS1FCejRrczROMnBvUml0cGI3?=
 =?utf-8?B?MzdGM1BWV082R0JTZVkzUE1KVEZqWjVPTlpDWU1BSzR3WFVVVWo0YVgzYU9I?=
 =?utf-8?B?eGlpei9wS0t0ZlZ2cXpzdFVVYjhFRm5Yank5c2pmbjYvRmltdzI3YkdpSWti?=
 =?utf-8?B?Mm5vWnBOSGMvU0ZOK0ZnUC8zRCtzbnpDODVtdFI1cHhQb1RmMVh1bm5KdXVO?=
 =?utf-8?B?alE2ZlNhbjNYODVsNVRCVjhSY2NYbHhuWW1KTmpRRU0xOGxqR2hDeXlLekVh?=
 =?utf-8?B?YmNxUkMyQmhXZWlzYUtmU012TzBjaVZ1N3VVZ1BqbUpDVzBpbHJQQitFUUpp?=
 =?utf-8?B?anBWbjhBWlZqQm5kcnRydG5hNHFNN1BiT1g4c3gzem5BMGxuTUJULzBVaUxF?=
 =?utf-8?B?TzdqYUxKYjdYTmVpeFl1QjZIdlVvYmtHNzhHd2xnSXBCdkt1cHBBWFdWTnhK?=
 =?utf-8?B?THdBS3BFbUJYZC9qcE1FVXB5ZGNKU1ZMbUZXV2tpclZYcXFjc1dtd0tUVHEv?=
 =?utf-8?B?Y29tSS9RTzlpU0RDaFBZZzZOck03MFdobFQ2K2liRWc1ZWVITmx5TldhelAz?=
 =?utf-8?B?L3lzOU5SNUFvM0xvK2VNT1dhcVRoanVHUm5KcnJmVzNtRVZMcExrSWhyTmRZ?=
 =?utf-8?B?dE9aZDlmUTYyYzBROVA5NXNLUVZkazBYZzZUKzlHTG9OK2NBWEZOb3hveFRQ?=
 =?utf-8?B?OVRLdWRVQlZrTWRjK0NneW1vUlRMUXJnUkp0UGI0MGhXcENKNHdNazhKZUlG?=
 =?utf-8?B?NkVBTkV4L05oMXhpUkY2VVpGMHQ1STlvQ0w0d3FWdU52RnJCNlJxTUZaM0pZ?=
 =?utf-8?B?RjA2K1pkdkNiMmJkT2xjWDB2QzZoSlo5dmZrM0IyWE5vS25sT25RU1R2UEg2?=
 =?utf-8?B?bFl5dG1ZS211OFF5cDZFQjhnZ2lqU3FMaTdjbld0NFJYMSs1S0J3TFFtNzRI?=
 =?utf-8?Q?EMTI1znHWOtpktEqvEP6sHhh1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef46a9b7-d00e-416f-2215-08dc2d6c205e
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2024 14:49:20.3603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NCsReAaC/215FDEwCi2UaNPPfVURaA5D41uRcbH1hgpZP4P4J6zGZcpQ0rH0mi//4LWYQVg458EGWaHSHSIVdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7633

On 2/14/2024 5:51 AM, Borislav Petkov wrote:
> On Tue, Feb 13, 2024 at 09:35:16PM -0600, Yazen Ghannam wrote:
>> +static inline struct cper_sec_fru_mem_poison *get_fmp(struct fru_rec *rec)
>> +{
>> +	return &rec->fmp;
>> +}
> 
> Let's get rid of those silly helpers, diff for this one below.
> 
> The logic is, you pass around struct fru_rec *rec and inside the
> functions you deref what you need.
>

Okay, agreed.

Thanks,
Yazen